- '.newcomer_task_token' should be string
- '.homepage_pageview_token' should be string, '
- ' should have required property 'newcomer_task_token'
~ 1000 times a day.
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | MMiller_WMF | T252822 [EPIC] Growth: "add a link" structured task 1.0 | |||
| Resolved | kostajh | T273827 Add a link: instrumentation | |||
| Resolved | kostajh | T278177 Add a link: create new Schema | |||
| Resolved | PRODUCTION ERROR | kostajh | T282826 mediawiki.structured_task.article.link_suggestion_interaction errors |
Event Timeline
Comment Actions
Probably the query parameters of the task card link are getting lost somehow. We already had a task about that (invalid tasktype, or something like that?) but I can't find it right now.
Comment Actions
@Tgr I see you moved this to code review, but I don't see any code that can be reviewed here. Is that intentional?
Comment Actions
Change 693195 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Check if task is link-recommendation type before showing onboarding
Comment Actions
Change 693040 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.6] Check if task is link-recommendation type before showing onboarding
Comment Actions
Change 693041 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.5] Check if task is link-recommendation type before showing onboarding
Comment Actions
Change 693040 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.6] Check if task is link-recommendation type before showing onboarding
Comment Actions
Change 693041 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.5] Check if task is link-recommendation type before showing onboarding
Comment Actions
Change 693195 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Check if task is link-recommendation type before showing onboarding
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2021-05-20T18:31:52Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.6/extensions/GrowthExperiments/modules/homepage/addlink/AddLinkOnboarding.js: 7fb129f: Check if task is link-recommendation type before showing onboarding (T282826) (duration: 01m 05s)
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2021-05-20T18:32:12Z] <urbanecm@deploy1002> sync-file aborted: 9edb3f4: Check if task is link-recommendation type before showing onboarding (T282826) (duration: 00m 00s)
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2021-05-20T18:33:21Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.5/extensions/GrowthExperiments/modules/homepage/addlink/AddLinkOnboarding.js: 9edb3f4: Check if task is link-recommendation type before showing onboarding (T282826) (duration: 01m 04s)
Comment Actions
A week and a half later, there are still a few such errors (only a tiny amount though): https://logstash.wikimedia.org/goto/dc3b91426ccf80d45af4c604b67b89cd
Some people kept their browser tabs open for a week? Or maybe related to T284088: Merge preference "Enable the editor help panel" with "Display the newcomer homepage" together? (inconsistent state of various "is this a link recommendation task?" flags when the task is a link recommendation but help panel is disabled?)