LogEventsList.php: PHP Notice: Undefined variable: pageName
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	dancy
	May 13 2021, 9:38 PM

Description

Error

mwversion: 1.37.0-wmf.5
reqId: 589e3a27-06b5-4e3b-9078-df0812e7c33b
Find reqId in Logstash
Find normalized_message in Logstash

normalized_message

[{reqId}] {exception_url}   PHP Notice: Undefined variable: pageName

exception.trace

from /srv/mediawiki/php-1.37.0-wmf.5/includes/logging/LogEventsList.php(770)
#0 /srv/mediawiki/php-1.37.0-wmf.5/includes/logging/LogEventsList.php(770): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.37.0-wmf.5/extensions/CentralAuth/includes/specials/SpecialMultiLock.php(520): LogEventsList::showLogExtract(string, array, string, string, array)
#2 /srv/mediawiki/php-1.37.0-wmf.5/extensions/CentralAuth/includes/specials/SpecialMultiLock.php(106): SpecialMultiLock->showLogExtract()
#3 /srv/mediawiki/php-1.37.0-wmf.5/includes/specialpage/SpecialPage.php(646): SpecialMultiLock->execute(NULL)
#4 /srv/mediawiki/php-1.37.0-wmf.5/includes/specialpage/SpecialPageFactory.php(1396): SpecialPage->run(NULL)
#5 /srv/mediawiki/php-1.37.0-wmf.5/includes/MediaWiki.php(313): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#6 /srv/mediawiki/php-1.37.0-wmf.5/includes/MediaWiki.php(916): MediaWiki->performRequest()
#7 /srv/mediawiki/php-1.37.0-wmf.5/includes/MediaWiki.php(550): MediaWiki->main()
#8 /srv/mediawiki/php-1.37.0-wmf.5/index.php(53): MediaWiki->run()
#9 /srv/mediawiki/php-1.37.0-wmf.5/index.php(46): wfIndexMain()
#10 /srv/mediawiki/w/index.php(3): require(string)
#11 {main}

Notes

16 of these in the last hour. This error is new for wmf.5. There are two variants of the same error message, one occurring at LogEventsList:732

Details

Request URL: https://meta.wikimedia.org/wiki/Special:MultiLock

	Subject	Repo	Branch	Lines +/-
	LogEventsList: always define $pageName	mediawiki/core	wmf/1.37.0-wmf.5	+5 -1
	LogEventsList: always define $pageName	mediawiki/core	master	+5 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	dancy	T281146 1.37.0-wmf.5 deployment blockers
		Resolved	PRODUCTION ERROR	• Pchelolo	T282834 LogEventsList.php: PHP Notice: Undefined variable: pageName

Event Timeline

dancy created this task.May 13 2021, 9:38 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 13 2021, 9:38 PM

dancy added a parent task: T281146: 1.37.0-wmf.5 deployment blockers.May 13 2021, 9:39 PM

RhinosF1 subscribed.May 13 2021, 9:41 PM

dancy renamed this task from PHP Notice: Undefined variable: pageName to LogEventsList.php: PHP Notice: Undefined variable: pageName.May 13 2021, 10:02 PM

dancy triaged this task as Unbreak Now! priority.May 13 2021, 11:39 PM

dancy mentioned this in T281146: 1.37.0-wmf.5 deployment blockers.

Change 690784 had a related patch set uploaded (by Ppchelko; author: Ppchelko):

[mediawiki/core@master] LogEventsList: always define $pageName

https://gerrit.wikimedia.org/r/690784

gerritbot added a project: Patch-For-Review.May 14 2021, 12:02 AM

Change 690784 merged by jenkins-bot:

[mediawiki/core@master] LogEventsList: always define $pageName

https://gerrit.wikimedia.org/r/690784

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.6; 2021-05-18).May 14 2021, 2:00 AM

Change 690808 had a related patch set uploaded (by Jforrester; author: Ppchelko):

[mediawiki/core@wmf/1.37.0-wmf.5] LogEventsList: always define $pageName

https://gerrit.wikimedia.org/r/690808

Jdforrester-WMF updated the task description. (Show Details)May 14 2021, 2:10 AM

In T282834#7087143, @gerritbot wrote:

Change 690784 merged by jenkins-bot:

[mediawiki/core@master] LogEventsList: always define $pageName

https://gerrit.wikimedia.org/r/690784

Issue was introduced in 60734d3b192623 (T278459).

@daniel Perhaps worth a retro to understand why Phan didn't catch this use of conditionally defined variable as being a problem?

Krinkle added a subscriber: daniel.May 14 2021, 2:21 AM

Change 690808 merged by jenkins-bot:

[mediawiki/core@wmf/1.37.0-wmf.5] LogEventsList: always define $pageName

https://gerrit.wikimedia.org/r/690808

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.5; 2021-05-11); removed MW-1.37-notes (1.37.0-wmf.6; 2021-05-18).May 14 2021, 3:00 AM

Maintenance_bot removed a project: Patch-For-Review.May 14 2021, 3:10 AM

Mentioned in SAL (#wikimedia-operations) [2021-05-14T03:13:36Z] <tstarling@deploy1002> Synchronized php-1.37.0-wmf.5/includes/logging/LogEventsList.php: fix PHP notice T282834 (duration: 01m 08s)

Jdforrester-WMF closed this task as Resolved.May 14 2021, 3:16 AM

Jdforrester-WMF assigned this task to • Pchelolo.

Krinkle mentioned this in T283298: Phan failed to catch undefined variable.May 20 2021, 11:52 PM

Krinkle moved this task from Untriaged to May 2021 on the Wikimedia-production-error board.Jun 12 2021, 5:43 PM

Krinkle mentioned this in Blog Post: Production Excellence #32: May 2021.Jun 21 2021, 1:31 AM