Value inserted into ipb_parent_block_id is 0 if a block with autoblock enabled is updated
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Tchanders
	May 14 2021, 6:01 PM

Description

An autoblock is a block against an IP address, spawned from a block against a user account. For an autoblock, the ipb_parent_block_id column holds the ID of the block that spawned it.

All other blocks should have ipb_parent_block_id = null.

However, if a (non-auto)block is updated, it is re-saved with ipb_parent_block_id set to 0.

The bug seems to come from this line: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/9ba56ccb3b85175da3de36e6b9f9c0a30c007d1f/includes/block/DatabaseBlock.php#463

Example from itwiki:

> SELECT COUNT(*) FROM ipblocks WHERE ipb_parent_block_id = 0;
+----------+
| COUNT(*) |
+----------+
|      898 |
+----------+

> SELECT COUNT(*) FROM ipblocks WHERE ipb_parent_block_id = 0 AND ipb_user != 0;
+----------+
| COUNT(*) |
+----------+
|      842 |
+----------+

The first case shouldn't be possible, because no blocks have ipb_id = 0, and the second shouldn't be possible because all blocks against a user account (i.e. ipb_user is nonzero) should have ipb_parent_block_id = null.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	MigrateBlocks: maintenance script for migrating to multiblocks schema	mediawiki/core	master	+165 -0
	DatabaseBlock: don't save parent block id as 0	mediawiki/core	master	+9 -4

Customize query in gerrit

Related Objects

Mentioned In: T350361: Create a maintenance script to populate block and block_target from ipblocks
T282463: Special:AutoblockList shows regular blocks after block edited/reblocking

Event Timeline

Tchanders created this task.May 14 2021, 6:01 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 14 2021, 6:01 PM

Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment-Team board.May 25 2021, 3:55 PM

Niharika changed the subtype of this task from "Task" to "Bug Report".

Change 696544 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] DatabaseBlock: don't save parent block id as 0

https://gerrit.wikimedia.org/r/696544

gerritbot added a project: Patch-For-Review.May 29 2021, 2:25 AM

DannyS712 subscribed.May 29 2021, 2:27 AM

phuedx moved this task from Triage/To be Estimated to Untriaged on the Anti-Harassment-Team board.Oct 18 2021, 2:02 PM

phuedx moved this task from Untriaged to MediaWiki-Blocks on the Anti-Harassment-Team board.Oct 18 2021, 2:07 PM

While Special:ListBlocks has already a check for ipb_parent_block_id null or 0 to filter autoblocks, the check is missing on Special:ListAutoblocks, making it a bit worse.
If the check is in the code there is no need for a maintenance script

Umherirrender mentioned this in T282463: Special:AutoblockList shows regular blocks after block edited/reblocking.Sep 19 2022, 6:39 PM

Change 696544 merged by jenkins-bot:

[mediawiki/core@master] DatabaseBlock: don't save parent block id as 0

https://gerrit.wikimedia.org/r/696544

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.14; 2022-12-12).Dec 7 2022, 9:01 AM

Maintenance_bot removed a project: Patch-For-Review.Dec 7 2022, 9:31 AM

Umherirrender closed this task as Resolved.Dec 8 2022, 9:11 PM

Umherirrender assigned this task to DannyS712.

Restricted Application added a project: User-DannyS712. · View Herald TranscriptDec 8 2022, 9:11 PM

tstarling mentioned this in T350361: Create a maintenance script to populate block and block_target from ipblocks.Nov 5 2023, 10:42 PM

Change 977985 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/core@master] MigrateBlocks: maintenance script for migrating to multiblocks schema

https://gerrit.wikimedia.org/r/977985

gerritbot added a project: Patch-For-Review.Nov 28 2023, 7:41 AM

Change 977985 merged by jenkins-bot: