Page MenuHomePhabricator
Create Task
Maniphest T282894

Rename …master methods in ILoadBalancer to …primary
Closed, ResolvedPublic
Actions

Description

In T278026#7087743, @Lucas_Werkmeister_WMDE wrote:

There are also several ILoadBalancer methods with “master”:

ItemNew nameAvailable inHard-deprecated inRemoved
DBMasterPosDBPrimaryPos1.37N/A1.39
ILoadBalancer::getMasterPos()::getPrimaryPos()1.371.371.38
ILoadBalancer::finalizeMasterChanges()::finalizePrimaryChanges()1.371.371.38
ILoadBalancer::approveMasterChanges()::approvePrimaryChanges()1.371.371.38
ILoadBalancer::beginMasterChanges()::beginPrimaryChanges()1.371.371.38
ILoadBalancer::commitMasterChanges()::commitPrimaryChanges()1.371.371.38
ILoadBalancer::runMasterTransactionIdleCallbacks()::runPrimaryTransactionIdleCallbacks()1.371.371.38
ILoadBalancer::runMasterTransactionListenerCallbacks()::runPrimaryTransactionListenerCallbacks()1.371.371.38
ILoadBalancer::rollbackMasterChanges()::rollbackPrimaryChanges()1.371.371.38
ILoadBalancer::flushMasterSnapshots()::flushPrimarySnapshots()1.371.371.38
ILoadBalancer::hasMasterConnection()::hasPrimaryConnection()1.371.371.38
ILoadBalancer::hasMasterChanges()::hasPrimaryChanges()1.371.371.38
ILoadBalancer::lastMasterChangeTimestamp()::lastPrimaryChangeTimestamp()1.371.371.38
ILoadBalancer::hasOrMadeRecentMasterChanges()::hasOrMadeRecentPrimaryChanges()1.371.371.38
ILoadBalancer::pendingMasterChangeCallers()::pendingPrimaryChangeCallers()1.371.371.38
ILoadBalancer::forEachOpenMasterConnection()::forEachOpenPrimaryConnection()1.371.371.38
ILoadBalancer::waitForMasterPos()::waitForPrimaryPos()1.371.371.38

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove deprecated class Wikimedia\Rdbms\MySQLMasterPosmediawiki/coremaster+2 -8
Remove DBMasterPos as an alias for DBPrimaryPosmediawiki/coremaster+1 -8
ILoadBalancer::forEachOpenMasterConnection: Hard deprecate now it's unused in prodmediawiki/coremaster+1 -1
ILoadBalancer/ILBFactory::hasOrMadeRecentMasterChanges: Hard deprecate now it's unused in prodmediawiki/coremaster+2 -2
ILoadBalancer/ILBFactory::rollbackMasterChanges: Hard deprecate now it's unused in prodmediawiki/coremaster+2 -2
ILoadBalancer/ILBFactory::hasMasterChanges: Hard deprecate as it's unused beyond SMWmediawiki/coremaster+2 -2
ILoadBalancer/ILBFactory::commitPrimaryChanges: Hard deprecate now it's unused in prodmediawiki/coremaster+2 -2
ILoadBalancer/ILBFactory::beginMasterChanges: Hard deprecate now it's unused in prodmediawiki/coremaster+2 -2
ILoadBalancer/IDatabase::getMasterPos: Hard deprecate now it's unused in prodmediawiki/coremaster+4 -4
ILoadBalancer::finalizeMasterChanges/approveMasterChanges: Hard deprecatemediawiki/coremaster+2 -2
ExternalStoreDB: Rename getMaster to getPrimarymediawiki/coremaster+20 -8
DatabaseMysqlBase: Rename getMasterServerInfo to getPrimaryServerInfomediawiki/coremaster+10 -4
RevDelList: Rename reloadFromMaster to reloadFromPrimarymediawiki/coremaster+15 -5
Database: Rename assertIsWritableMaster to assertIsWritablePrimarymediawiki/coremaster+21 -10
ILoadBalancer: Rename forEachOpenMasterConnection to forEachOpenPrimaryConnectionmediawiki/coremaster+39 -24
ILoadBalancer: Rename waitForMasterPos to waitForPrimaryPosmediawiki/coremaster+24 -8
Switch uses of ILoadBalancer::approveMasterChanges to ::approvePrimaryChangesmediawiki/coremaster+9 -9
ILoadBalancer: Rename pendingMasterChangeCallers to pendingPrimaryChangeCallersmediawiki/coremaster+16 -2
ILoadBalancer: Rename lastMasterChangeTimestamp to lastPrimaryChangeTimestampmediawiki/coremaster+16 -3
ILoadBalancer/ILBFactory: Rename hasOrMadeRecentMasterChanges to hasOrMadeRecentPrimaryChangesmediawiki/coremaster+44 -15
ILoadBalancer/ILBFactory: Rename hasMasterChanges to hasPrimaryChangesmediawiki/coremaster+33 -7
ILoadBalancer: Rename flushMasterSnapshots to flushPrimarySnapshotsmediawiki/coremaster+18 -4
ILoadBalancer: Rename hasMasterConnection to hasPrimaryConnectionmediawiki/coremaster+19 -6
ILoadBalancer: Rename runMasterTransactionListenerCallbacks to runPrimaryTransactionListenerCallbacksmediawiki/coremaster+21 -5
ILoadBalancer/ILBFactory: Rename rollbackMasterChanges to rollbackPrimaryChangesmediawiki/coremaster+42 -14
IDatabase: Rename masterPosWait to primaryPosWaitmediawiki/coremaster+40 -13
ILoadBalancer: Rename runMasterTransactionIdleCallbacks to runPrimaryTransactionIdleCallbacksmediawiki/coremaster+21 -5
IDatabase: Rename getTopologyRootMaster to getTopologyRootPrimarymediawiki/coremaster+31 -12
ILoadBalancer/ILBFactory: Rename commitMasterChanges() to commitPrimaryChanges()mediawiki/coremaster+76 -47
ILoadBalancer/ILBFactory: Rename beginMasterChanges() to beginPrimaryChanges()mediawiki/coremaster+46 -19
Rename DB primary position interfaces to DBPrimaryPos and MySQLPrimaryPosmediawiki/coremaster+183 -164
ILoadBalancer: Rename approveMasterChanges() to approvePrimaryChanges()mediawiki/coremaster+19 -3
ILoadBalancer: Rename finalizeMasterChanged() to finalizePrimaryChanges()mediawiki/coremaster+31 -14
ILoadBalancer and IDatabase: Rename getMasterPos to getPrimaryPosmediawiki/coremaster+59 -23
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a project: Patch-For-Review.May 14 2021, 8:06 PM
gerritbot added a comment.May 14 2021, 10:23 PM

Change 691329 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] ILoadBalancer and IDatabase: Rename getMasterPos to getPrimaryPos

https://gerrit.wikimedia.org/r/691329

gerritbot added a comment.May 14 2021, 10:23 PM

Change 691330 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] ILoadBalancer: Rename finalizeMasterChanged() to finalizePrimaryChanges()

https://gerrit.wikimedia.org/r/691330

gerritbot added a comment.May 14 2021, 10:23 PM

Change 691331 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] ILoadBalancer: Rename approveMasterChanges() to approvePrimaryChanges()

https://gerrit.wikimedia.org/r/691331

gerritbot added a comment.May 14 2021, 10:23 PM

Change 691332 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] ILoadBalancer/ILBFactory: Rename beginMasterChanges() to beginPrimaryChanges()

https://gerrit.wikimedia.org/r/691332

gerritbot added a comment.May 14 2021, 10:23 PM

Change 691333 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] ILoadBalancer: Rename commitMasterChanges() to commitPrimaryChanges()

https://gerrit.wikimedia.org/r/691333

Lucas_Werkmeister_WMDE awarded a token.May 17 2021, 8:29 AM
Krinkle edited projects, added MediaWiki-libs-Rdbms, Performance-Team; removed MediaWiki-General.Aug 2 2021, 6:00 PM
Krinkle moved this task from Untriaged to Rdbms library on the MediaWiki-libs-Rdbms board.
Krinkle moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.
gerritbot added a comment.Aug 2 2021, 6:24 PM

Change 691272 merged by jenkins-bot:

[mediawiki/core@master] Rename DB primary position interfaces to DBPrimaryPos and MySQLPrimaryPos

https://gerrit.wikimedia.org/r/691272

gerritbot added a comment.Aug 2 2021, 6:34 PM

Change 691329 merged by jenkins-bot:

[mediawiki/core@master] ILoadBalancer and IDatabase: Rename getMasterPos to getPrimaryPos

https://gerrit.wikimedia.org/r/691329

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.17; 2021-08-02).Aug 2 2021, 7:00 PM
gerritbot added a comment.Aug 3 2021, 3:33 AM

Change 691330 merged by jenkins-bot:

[mediawiki/core@master] ILoadBalancer: Rename finalizeMasterChanged() to finalizePrimaryChanges()

https://gerrit.wikimedia.org/r/691330

gerritbot added a comment.Aug 3 2021, 3:36 AM

Change 691331 merged by jenkins-bot:

[mediawiki/core@master] ILoadBalancer: Rename approveMasterChanges() to approvePrimaryChanges()

https://gerrit.wikimedia.org/r/691331

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.18; 2021-08-09); removed MW-1.37-notes (1.37.0-wmf.17; 2021-08-02).Aug 3 2021, 3:00 PM
dduvall mentioned this in T287988: PHP Warning: Class __PHP_Incomplete_Class has no unserializer.Aug 3 2021, 7:39 PM
gerritbot added a comment.Sep 2 2021, 6:30 PM

Change 691332 merged by jenkins-bot:

[mediawiki/core@master] ILoadBalancer/ILBFactory: Rename beginMasterChanges() to beginPrimaryChanges()

https://gerrit.wikimedia.org/r/691332

gerritbot added a comment.Sep 2 2021, 6:50 PM

Change 691333 merged by jenkins-bot:

[mediawiki/core@master] ILoadBalancer/ILBFactory: Rename commitMasterChanges() to commitPrimaryChanges()

https://gerrit.wikimedia.org/r/691333

gerritbot added a comment.Sep 2 2021, 6:59 PM

Change 716481 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] IDatabase: Rename getTopologyRootMaster to getTopologyRootPrimary

https://gerrit.wikimedia.org/r/716481

gerritbot added a comment.Sep 2 2021, 6:59 PM

Change 716482 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] IDatabase: Rename masterPosWait to primaryPosWait

https://gerrit.wikimedia.org/r/716482

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.23; 2021-09-13); removed MW-1.37-notes (1.37.0-wmf.18; 2021-08-09).Sep 2 2021, 7:00 PM
gerritbot added a comment.Sep 2 2021, 7:20 PM

Change 716514 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] ILoadBalancer: Rename runMasterTransactionIdleCallbacks to runPrimaryTransactionIdleCallbacks

https://gerrit.wikimedia.org/r/716514

gerritbot added a comment.Sep 2 2021, 7:20 PM

Change 716515 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] ILoadBalancer: Rename runMasterTransactionListenerCallbacks to runPrimaryTransactionListenerCallbacks

https://gerrit.wikimedia.org/r/716515

gerritbot added a comment.Sep 2 2021, 7:21 PM

Change 716516 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] ILoadBalancer/ILBFactory: Rename rollbackMasterChanges to rollbackPrimaryChanges

https://gerrit.wikimedia.org/r/716516

gerritbot added a comment.Sep 2 2021, 7:21 PM

Change 716517 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] ILoadBalancer: Rename flushMasterSnapshots to flushPrimarySnapshots

https://gerrit.wikimedia.org/r/716517

gerritbot added a comment.Sep 2 2021, 7:35 PM

Change 716523 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] ILoadBalancer: Rename hasMasterConnection to hasPrimaryConnection

https://gerrit.wikimedia.org/r/716523

gerritbot added a comment.Sep 2 2021, 7:35 PM

Change 716524 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] ILoadBalancer/ILBFactory: Rename hasMasterChanges to hasPrimaryChanges

https://gerrit.wikimedia.org/r/716524

gerritbot added a comment.Sep 2 2021, 7:35 PM

Change 716525 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] ILoadBalancer: Rename lastMasterChangeTimestamp to lastPrimaryChangeTimestamp

https://gerrit.wikimedia.org/r/716525

gerritbot added a comment.Sep 2 2021, 7:35 PM

Change 716526 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] ILoadBalancer/ILBFactory: Rename hasOrMadeRecentMasterChanges to hasOrMadeRecentPrimaryChanges

https://gerrit.wikimedia.org/r/716526

gerritbot added a comment.Sep 2 2021, 9:04 PM

Change 716481 merged by jenkins-bot:

[mediawiki/core@master] IDatabase: Rename getTopologyRootMaster to getTopologyRootPrimary

https://gerrit.wikimedia.org/r/716481

gerritbot added a comment.Sep 2 2021, 9:15 PM

Change 716482 merged by jenkins-bot:

[mediawiki/core@master] IDatabase: Rename masterPosWait to primaryPosWait

https://gerrit.wikimedia.org/r/716482

gerritbot added a comment.Sep 2 2021, 9:15 PM

Change 716514 merged by jenkins-bot:

[mediawiki/core@master] ILoadBalancer: Rename runMasterTransactionIdleCallbacks to runPrimaryTransactionIdleCallbacks

https://gerrit.wikimedia.org/r/716514

gerritbot added a comment.Sep 2 2021, 9:20 PM

Change 716515 merged by jenkins-bot:

[mediawiki/core@master] ILoadBalancer: Rename runMasterTransactionListenerCallbacks to runPrimaryTransactionListenerCallbacks

https://gerrit.wikimedia.org/r/716515

gerritbot added a comment.Sep 2 2021, 9:25 PM

Change 716516 merged by jenkins-bot:

[mediawiki/core@master] ILoadBalancer/ILBFactory: Rename rollbackMasterChanges to rollbackPrimaryChanges

https://gerrit.wikimedia.org/r/716516

gerritbot added a comment.Sep 2 2021, 9:53 PM

Change 716517 merged by jenkins-bot:

[mediawiki/core@master] ILoadBalancer: Rename flushMasterSnapshots to flushPrimarySnapshots

https://gerrit.wikimedia.org/r/716517

gerritbot added a comment.Sep 2 2021, 9:53 PM

Change 716523 merged by jenkins-bot:

[mediawiki/core@master] ILoadBalancer: Rename hasMasterConnection to hasPrimaryConnection

https://gerrit.wikimedia.org/r/716523

gerritbot added a comment.Sep 2 2021, 11:14 PM

Change 716622 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Switch uses of ILoadBalancer::approveMasterChanges to ::approvePrimaryChanges

https://gerrit.wikimedia.org/r/716622

gerritbot added a comment.Sep 2 2021, 11:14 PM

Change 716623 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] ILoadBalancer: Rename pendingMasterChangeCallers to pendingPrimaryChangeCallers

https://gerrit.wikimedia.org/r/716623

gerritbot added a comment.Sep 2 2021, 11:14 PM

Change 716624 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] ILoadBalancer: Rename forEachOpenMasterConnection to forEachOpenPrimaryConnection

https://gerrit.wikimedia.org/r/716624

gerritbot added a comment.Sep 2 2021, 11:14 PM

Change 716625 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] ILoadBalancer: Rename waitForMasterPos to waitForPrimaryPos

https://gerrit.wikimedia.org/r/716625

gerritbot added a comment.Sep 2 2021, 11:14 PM

Change 716626 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Database: Rename assertIsWritableMaster to assertIsWritablePrimary

https://gerrit.wikimedia.org/r/716626

gerritbot added a comment.Sep 2 2021, 11:14 PM

Change 716628 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] RevDelList: Rename reloadFromMaster to reloadFromPrimary

https://gerrit.wikimedia.org/r/716628

gerritbot added a comment.Sep 2 2021, 11:31 PM

Change 716630 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] ExternalStoreDB: Rename getMaster to getPrimary

https://gerrit.wikimedia.org/r/716630

gerritbot added a comment.Sep 2 2021, 11:31 PM

Change 716631 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] DatabaseMysqlBase: Rename getMasterServerInfo to getPrimaryServerInfo

https://gerrit.wikimedia.org/r/716631

gerritbot added a comment.Sep 3 2021, 3:42 AM

Change 716524 merged by jenkins-bot:

[mediawiki/core@master] ILoadBalancer/ILBFactory: Rename hasMasterChanges to hasPrimaryChanges

https://gerrit.wikimedia.org/r/716524

gerritbot added a comment.Sep 3 2021, 3:42 AM

Change 716525 merged by jenkins-bot:

[mediawiki/core@master] ILoadBalancer: Rename lastMasterChangeTimestamp to lastPrimaryChangeTimestamp

https://gerrit.wikimedia.org/r/716525

gerritbot added a comment.Sep 3 2021, 3:44 AM

Change 716526 merged by jenkins-bot:

[mediawiki/core@master] ILoadBalancer/ILBFactory: Rename hasOrMadeRecentMasterChanges to hasOrMadeRecentPrimaryChanges

https://gerrit.wikimedia.org/r/716526

Jdforrester-WMF updated the task description. (Show Details)Sep 3 2021, 5:29 PM
gerritbot added a comment.Sep 3 2021, 8:24 PM

Change 716622 merged by jenkins-bot:

[mediawiki/core@master] Switch uses of ILoadBalancer::approveMasterChanges to ::approvePrimaryChanges

https://gerrit.wikimedia.org/r/716622

gerritbot added a comment.Sep 3 2021, 8:27 PM

Change 716623 merged by jenkins-bot:

[mediawiki/core@master] ILoadBalancer: Rename pendingMasterChangeCallers to pendingPrimaryChangeCallers

https://gerrit.wikimedia.org/r/716623

gerritbot added a comment.Sep 3 2021, 8:37 PM

Change 716624 merged by jenkins-bot:

[mediawiki/core@master] ILoadBalancer: Rename forEachOpenMasterConnection to forEachOpenPrimaryConnection

https://gerrit.wikimedia.org/r/716624

gerritbot added a comment.Sep 3 2021, 8:37 PM

Change 716625 merged by jenkins-bot:

[mediawiki/core@master] ILoadBalancer: Rename waitForMasterPos to waitForPrimaryPos

https://gerrit.wikimedia.org/r/716625

gerritbot added a comment.Sep 3 2021, 8:41 PM

Change 716626 merged by jenkins-bot:

[mediawiki/core@master] Database: Rename assertIsWritableMaster to assertIsWritablePrimary

https://gerrit.wikimedia.org/r/716626

gerritbot added a comment.Sep 3 2021, 8:47 PM

Change 716628 merged by jenkins-bot:

[mediawiki/core@master] RevDelList: Rename reloadFromMaster to reloadFromPrimary

https://gerrit.wikimedia.org/r/716628

Jdforrester-WMF updated the task description. (Show Details)Sep 3 2021, 8:54 PM
gerritbot added a comment.Sep 3 2021, 9:23 PM

Change 716630 merged by jenkins-bot:

[mediawiki/core@master] ExternalStoreDB: Rename getMaster to getPrimary

https://gerrit.wikimedia.org/r/716630

gerritbot added a comment.Sep 3 2021, 9:23 PM

Change 716631 merged by jenkins-bot:

[mediawiki/core@master] DatabaseMysqlBase: Rename getMasterServerInfo to getPrimaryServerInfo

https://gerrit.wikimedia.org/r/716631

gerritbot added a comment.Sep 4 2021, 12:56 AM

Change 717743 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] ILoadBalancer/IDatabase::getMasterPos: Hard deprecate now it's unused in prod

https://gerrit.wikimedia.org/r/717743

gerritbot added a comment.Sep 4 2021, 12:57 AM

Change 717744 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] ILoadBalancer::finalizeMasterChanges/approveMasterChanges: Hard deprecate

https://gerrit.wikimedia.org/r/717744

gerritbot added a comment.Sep 4 2021, 12:57 AM

Change 717745 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] ILoadBalancer/ILBFactory::beginMasterChanges: Hard deprecate now it's unused in prod

https://gerrit.wikimedia.org/r/717745

Jdforrester-WMF updated the task description. (Show Details)Sep 7 2021, 4:27 PM
gerritbot added a comment.Sep 7 2021, 5:52 PM

Change 717743 merged by jenkins-bot:

[mediawiki/core@master] ILoadBalancer/IDatabase::getMasterPos: Hard deprecate now it's unused in prod

https://gerrit.wikimedia.org/r/717743

gerritbot added a comment.Sep 7 2021, 5:52 PM

Change 717744 merged by jenkins-bot:

[mediawiki/core@master] ILoadBalancer::finalizeMasterChanges/approveMasterChanges: Hard deprecate

https://gerrit.wikimedia.org/r/717744

gerritbot added a comment.Sep 7 2021, 5:54 PM

Change 717745 merged by jenkins-bot:

[mediawiki/core@master] ILoadBalancer/ILBFactory::beginMasterChanges: Hard deprecate now it's unused in prod

https://gerrit.wikimedia.org/r/717745

Jdforrester-WMF updated the task description. (Show Details)Sep 7 2021, 6:48 PM
Jdforrester-WMF updated the task description. (Show Details)
gerritbot added a comment.Sep 7 2021, 7:13 PM

Change 719334 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] ILoadBalancer/ILBFactory::beginPrimaryChanges: Hard deprecate now it's unused in prod

https://gerrit.wikimedia.org/r/719334

gerritbot added a comment.Sep 7 2021, 7:22 PM

Change 719339 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] ILoadBalancer/ILBFactory::rollbackMasterChanges: Hard deprecate now it's unused in prod

https://gerrit.wikimedia.org/r/719339

Jdforrester-WMF updated the task description. (Show Details)Sep 7 2021, 7:23 PM
Jdforrester-WMF updated the task description. (Show Details)Sep 7 2021, 7:26 PM
gerritbot added a comment.Sep 7 2021, 7:55 PM

Change 719347 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] ILoadBalancer/ILBFactory::hasMasterChanges: Hard deprecate as it's unused beyond SMW

https://gerrit.wikimedia.org/r/719347

gerritbot added a comment.Sep 7 2021, 7:55 PM

Change 719348 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] ILoadBalancer/ILBFactory::hasOrMadeRecentMasterChanges: Hard deprecate now it's unused in prod

https://gerrit.wikimedia.org/r/719348

gerritbot added a comment.Sep 7 2021, 7:55 PM

Change 719349 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] ILoadBalancer::forEachOpenMasterConnection: Hard deprecate now it's unused in prod

https://gerrit.wikimedia.org/r/719349

Jdforrester-WMF updated the task description. (Show Details)Sep 7 2021, 7:57 PM
gerritbot added a comment.Sep 8 2021, 2:03 PM

Change 719334 merged by jenkins-bot:

[mediawiki/core@master] ILoadBalancer/ILBFactory::commitPrimaryChanges: Hard deprecate now it's unused in prod

https://gerrit.wikimedia.org/r/719334

gerritbot added a comment.Sep 8 2021, 2:04 PM

Change 719339 merged by jenkins-bot:

[mediawiki/core@master] ILoadBalancer/ILBFactory::rollbackMasterChanges: Hard deprecate now it's unused in prod

https://gerrit.wikimedia.org/r/719339

gerritbot added a comment.Sep 8 2021, 2:04 PM

Change 719347 merged by jenkins-bot:

[mediawiki/core@master] ILoadBalancer/ILBFactory::hasMasterChanges: Hard deprecate as it's unused beyond SMW

https://gerrit.wikimedia.org/r/719347

Jdforrester-WMF updated the task description. (Show Details)Sep 8 2021, 3:28 PM
gerritbot added a comment.Sep 8 2021, 8:52 PM

Change 719348 merged by jenkins-bot:

[mediawiki/core@master] ILoadBalancer/ILBFactory::hasOrMadeRecentMasterChanges: Hard deprecate now it's unused in prod

https://gerrit.wikimedia.org/r/719348

gerritbot added a comment.Sep 8 2021, 8:52 PM

Change 719349 merged by jenkins-bot:

[mediawiki/core@master] ILoadBalancer::forEachOpenMasterConnection: Hard deprecate now it's unused in prod

https://gerrit.wikimedia.org/r/719349

Jdforrester-WMF added a project: MW-1.38-release.Sep 8 2021, 8:53 PM
Jdforrester-WMF updated the task description. (Show Details)

OK, everything's hard-deprecated in time for the 1.37 cut. Nothing more to do until ~ 1.38.0-wmf.10 when we can merge the removals, potentially.

Jdforrester-WMF moved this task from Blocker to To deprecate or remove on the MW-1.38-release board.Sep 8 2021, 8:54 PM
Jdforrester-WMF added a comment.Mar 2 2022, 7:34 PM

If we're dropping these for 1.38, we need to make this decision in the next few days. The release cut is in 12 days' time.

Reedy removed a project: Patch-For-Review.Mar 9 2022, 8:52 PM
Zabe subscribed.EditedMar 27 2022, 6:58 PM

The methods have already been dropped a bit ago: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/755760

The only thing left is the DBMasterPos class alias.

gerritbot added a comment.Mar 27 2022, 7:00 PM

Change 774018 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Remove DBMasterPos as an alias for DBPrimaryPos

https://gerrit.wikimedia.org/r/774018

gerritbot added a project: Patch-For-Review.Mar 27 2022, 7:00 PM
Jdforrester-WMF closed this task as Resolved.Mar 27 2022, 8:32 PM
Jdforrester-WMF removed a project: MW-1.38-release.
Jdforrester-WMF updated the task description. (Show Details)
gerritbot added a comment.Mar 27 2022, 8:49 PM

Change 774018 merged by jenkins-bot:

[mediawiki/core@master] Remove DBMasterPos as an alias for DBPrimaryPos

https://gerrit.wikimedia.org/r/774018

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.5; 2022-03-28).Mar 27 2022, 9:00 PM
gerritbot added a comment.Sep 26 2023, 1:11 PM

Change 961104 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/core@master] Remove deprecated class Wikimedia\Rdbms\MySQLMasterPos

https://gerrit.wikimedia.org/r/961104

gerritbot added a comment.Sep 26 2023, 2:26 PM

Change 961104 merged by jenkins-bot:

[mediawiki/core@master] Remove deprecated class Wikimedia\Rdbms\MySQLMasterPos

https://gerrit.wikimedia.org/r/961104

Maintenance_bot removed a project: Patch-For-Review.Sep 26 2023, 2:32 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.29; 2023-10-03).Sep 26 2023, 3:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits