Page MenuHomePhabricator

Remove use of deprecated hook EditPageBeforeEditToolbar
Open, Needs TriagePublic

Description

Some extension still using EditPageBeforeEditToolbar hook which trigger a deprecation notice and selenium are failing, which makes the whole extension broken.

  • @deprecated 1.36 Use one of the many other EditPage hooks instead
  • T278563

Search: https://codesearch.wmcloud.org/search/?q=%5CbEditPageBeforeEditToolbar%5Cb&i=nope&files=&excludeFiles=&repos=

  • TinyMCE (now fixed in Version 1.1 released May 26, 2021)
  • JsonData
  • LiquidThreads (running the hook, not using it)

Event Timeline

In T278563: Deprecate the EditPageBeforeEditToolbar hook, I identified that these usages were solely to disable the old edit toolbar. (Except liquidthreads, which just invokes the hook). The handlers can be safely removed.

Mainframe98 renamed this task from Remove/Replace use of deprecated hook EditPageBeforeEditToolbar to Remove use of deprecated hook EditPageBeforeEditToolbar.May 14 2021, 9:44 PM

Fix now added to TinyMCE extension