Page MenuHomePhabricator
Create Task
Maniphest T282902

Remove use of deprecated hook EditPageBeforeEditToolbar
Open, Needs TriagePublic
Actions

Description

Some extension still using EditPageBeforeEditToolbar hook which trigger a deprecation notice and selenium are failing, which makes the whole extension broken.

  • @deprecated 1.36 Use one of the many other EditPage hooks instead
  • T278563

Search: https://codesearch.wmcloud.org/search/?q=%5CbEditPageBeforeEditToolbar%5Cb&i=nope&files=&excludeFiles=&repos=

  • TinyMCE (now fixed in Version 1.1 released May 26, 2021)
  • JsonData
  • LiquidThreads (running the hook, not using it)

Related Objects

Event Timeline

Umherirrender created this task.May 14 2021, 9:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 14 2021, 9:35 PM
Mainframe98 added a subscriber: Mainframe98.May 14 2021, 9:44 PM

In T278563: Deprecate the EditPageBeforeEditToolbar hook, I identified that these usages were solely to disable the old edit toolbar. (Except liquidthreads, which just invokes the hook). The handlers can be safely removed.

Mainframe98 renamed this task from Remove/Replace use of deprecated hook EditPageBeforeEditToolbar to Remove use of deprecated hook EditPageBeforeEditToolbar.May 14 2021, 9:44 PM
aoxomoxoa added a subscriber: aoxomoxoa.Wed, May 26, 9:43 AM

Fix now added to TinyMCE extension

aoxomoxoa updated the task description. (Show Details)Wed, May 26, 9:44 AM
Aklapper removed a project: MediaWiki-extensions-TinyMCE.Wed, May 26, 10:03 AM
Aklapper updated the task description. (Show Details)
Aklapper added a project: Technical-Debt.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL