Page MenuHomePhabricator

PictureGame: Unbreak SQLite support
Open, Needs TriagePublicBUG REPORT

Description

Turns out that currently (or more precisely, since actor support was added to the extension in e08c06f0accdbb13257f451edb15592ef46dad61 for T227345) PictureGame breaks on SQLite because, for consistency with the existing fields and index names, the new fields and one index were named actor, which coincidentally is the name of the actor table, too, and SQLite seems to confuse table names and identically named index names.

What would be the best/easiest way to remedy this? (Of course the correct, even if not very easy, solution is to rename both tables' fields to contain the abbreviated table name as a prefix, so that eg. picturegame_images's actor field becomes pi_actor (or pgi_actor) etc. but that's a fair amount of work, considering that the extension isn't broken on MySQL/MariaDB, which is what most production-grade sites use.)