Now and in the past the patch set of Kartographer contains changes to lib/external/mapbox/style.css which are not wanted [1]
Example: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Kartographer/+/691667/1
Log: https://libraryupgrader2.wmcloud.org/logs2/272688
Am not not sure which fixer is running here?
This is because of rEKARf4affd2db58d: styles: Remove obsolete vendor prefixed properties (cc @Volker_E @Krinkle)
When you run npm test it runs npm run build-lib which copies the files out of upstream node_modules/ and exports it into lib/external. However it looks like the style.css was modified without doing it upstream first, so now any run of npm run build-lib will revert back to the upstream state, as LibUp ends up doing.
So either we revert that change or make it so npm test or npm run build-lib stops reverting back.
Asking again here, if revert is necessary, let's go for it?!
I thought that I checked via git blame before proposing the patch and thought to spot changes to the file by WMF devs. But I might have been falsely ignoring it in this case.
Change 692079 had a related patch set uploaded (by Legoktm; author: Legoktm):
[mediawiki/extensions/Kartographer@master] Revert "styles: Remove obsolete vendor prefixed properties"
Change 692079 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Revert "styles: Remove obsolete vendor prefixed properties"
Change 692080 had a related patch set uploaded (by Legoktm; author: Legoktm):
[mediawiki/extensions/Kartographer@REL1_36] Revert "styles: Remove obsolete vendor prefixed properties"
Change 692080 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@REL1_36] Revert "styles: Remove obsolete vendor prefixed properties"