Page MenuHomePhabricator

VoteNY PostgreSQL tests failing on CI (due to the inconsistent/non-standard DB table name?)
Open, Needs TriagePublic


VoteNY introduces a new database table, Vote (note the uppercase V) (see also T153012: Rename Comments database table to be in line with convention).
Comments introduces three new DB tables, Comments, Comments_block and Comments_Vote (note the uppercase letters).

For PostgreSQL the table name thus needs to be "quoted" due to these uppercase characters and this is being done e.g. in /extensions/VoteNY/sql/vote.postgres and last I checked (which admittedly was a while ago) VoteNY was usable with a PostgreSQL backend; ditto for Comments. However on WMF CI the tests are failing, see e.g.

I'm not sure how to proceed here without attempting to fix T153012 which is a massive pain.

Event Timeline

Change 692022 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Comments@master] Quote all places with table names in postgres sql files

If you have to quote it on "CREATE TABLE" it should be quoted on "CREATE INDEX" as well.

The next problem is that field "Comment_actor" is not quoted in the "CREATE TABLE", but the "fieldExists" check possible not checking lowercase ...

[I have no idea if the new abstract schema would do it right when the postgre files are generated]

Change 692022 merged by jenkins-bot:

[mediawiki/extensions/Comments@master] Quote all places with table names in postgres sql files