Page MenuHomePhabricator

DiscussionTools does not detect signature when using {{Section resolved|1=~~~~}}
Closed, ResolvedPublic


When Discussion Tools (specifically the Reply tool) is used to add the template {{Section resolved|1=~~~~}}, it does not detect the signature and skip adding one (intended functionality), but instead duplicates it.

Steps to reproduce

  1. Go to with Microsoft Edge Dev version 92.0.884.2, on Windows 10 version 20H2
  2. Make sure you are logged in with New Vector as the skin
  3. Under any section, click on "Reply" for any of the comments
  4. In the editing area, paste in {{Section resolved|1=~~~~}}
  5. Click "Reply"

Actual results
The signature is duplicated. See diffs 1, 2, 3, 4, 5, 6, 7, and 8.

Expected results
Reply tool detects the signature, and skips adding a duplicate one.

Event Timeline

Oh, an additional note as well: DiscussionTools doesn't detect signatures in many cases, not just with the Section Resolved template.

Change 759841 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Improve detecting already signed comments

Change 759841 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Improve detecting already signed comments

As expected, only one signature is added. No duplicates:

Screenshot 2022-03-12 at 02.13.47.png (748×1 px, 119 KB)

What it used to look like:

Screenshot 2022-03-08 at 17.41.51.png (1×1 px, 146 KB)

Screenshot 2022-03-08 at 18.04.16.png (1×1 px, 192 KB)