Page MenuHomePhabricator

DiscussionTools does not detect signature when using {{Section resolved|1=~~~~}}
Open, Needs TriagePublic

Description

When Discussion Tools (specifically the Reply tool) is used to add the template {{Section resolved|1=~~~~}}, it does not detect the signature and skip adding one (intended functionality), but instead duplicates it.

Steps to reproduce

  1. Go to https://commons.wikimedia.org/wiki/Commons:Bots/Work_requests with Microsoft Edge Dev version 92.0.884.2, on Windows 10 version 20H2
  2. Make sure you are logged in with New Vector as the skin
  3. Under any section, click on "Reply" for any of the comments
  4. In the editing area, paste in {{Section resolved|1=~~~~}}
  5. Click "Reply"

Actual results
The signature is duplicated. See diffs 1, 2, 3, 4, 5, 6, 7, and 8.

Expected results
Reply tool detects the signature, and skips adding a duplicate one.

Event Timeline

Oh, an additional note as well: DiscussionTools doesn't detect signatures in many cases, not just with the Section Resolved template.