Maniphest T283018

Fix or drop disabled unit tests in Scap
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• LarsWirzenius
	May 17 2021, 3:58 PM

Tags

Referenced Files

None

Subscribers

Description

This is a tentative task, pending on Gerrit request https://gerrit.wikimedia.org/r/c/mediawiki/tools/scap/+/688351 being merged. If it's not merged, this task can be closed as invalid.

I had to disable three unit tests by renaming them with a fixme_ prefix, because they failed under Python3 and I couldn't understand what the tests test for or how they work. I chose to disable them rather than block the work.

Details

	Subject	Repo	Branch	Lines +/-
	Fix disabled unit tests in Scap	mediawiki/tools/scap	master	+11 -9

Customize query in gerrit

Event Timeline

• LarsWirzenius created this task.May 17 2021, 3:58 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 17 2021, 3:58 PM

• LarsWirzenius moved this task from INBOX to Next on the Release-Engineering-Team board.May 18 2021, 4:01 PM

• LarsWirzenius edited projects, added Release-Engineering-Team (Next); removed Release-Engineering-Team.

• LarsWirzenius assigned this task to dancy.Jun 15 2021, 5:01 AM

• LarsWirzenius triaged this task as Medium priority.

• LarsWirzenius unsubscribed.Jun 15 2021, 5:04 AM

The problem is that assert_called() does not exist in Python 3.5. It showed up in 3.6.

Change 702221 had a related patch set uploaded (by Ahmon Dancy; author: Ahmon Dancy):

[mediawiki/tools/scap@master] Fix disabled unit tests in Scap

https://gerrit.wikimedia.org/r/702221

gerritbot added a project: Patch-For-Review.Jun 29 2021, 7:39 PM

Change 702221 merged by jenkins-bot:

[mediawiki/tools/scap@master] Fix disabled unit tests in Scap

https://gerrit.wikimedia.org/r/702221

dancy closed this task as Resolved.Jun 29 2021, 10:29 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 29 2021, 11:11 PM