Page MenuHomePhabricator

Cleanup extensions that include jquery (and common plugins) themselves
Closed, ResolvedPublic


We should really look at cleaning up extensions that include jquery themselves

Quick look at the extensions directory, there are various inclusions if jquery 1.3.2, 1.4.2, 1.7.1, 1.7.2, 1.8

And then other plugins, oddities and numerous other things

20 folders, 326 other items..

MW svn head has for a while included Jquery for a while, and therefore only conditional inclusion is needed for those that care for back compatibility back to the stone age (*cough*)

Version: unspecified
Severity: enhancement



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:20 PM
bzimport set Reference to bz26306.
bzimport added a subscriber: Unknown Object (MLST).

Just so you know, jQuery !== jQuery UI.
Versions 1.7.1, 1.7.2, 1.8 are not versions of jQuery but of jQuery UI.
Although a big one, "jQuery UI" is 'just' a plugin, just like jQuery.cookie for example.
Dont confuse one with the other when cleaning up :)

Yeah.. I was just looking at that, and then pressed submit by accident ;)

Tweak title a bit

Still, jQuery UI is in core too and shouldn't be included by extensions either (unless they're trying for 1.16 b/c and properly using RL in 1.17).

Hence Reedy changed the summary to include "(and common plugins)", which I guess means anything in /resources/ by default.

OpenID had a copy of jQuery 1.3.2 & jquery.cookie; I've converted it to use ResourceLoader and MW's stock jquery modules in r87845. (Also removed a manually-maintained sprite by switching to icon embedding in the CSS, yay!)

Collection ext in r87847: stray copies of jquery, jquery.ui, and jquery.json.

jquery & jquery.ui copies here were unused -- already replaced with references to core loaded via RL.
jquery.json is also available in core, so switched to using the core copy of that too.

Ouch, we've got inclusions of versions 1.2.2 and 1.3.1 of jQuery....

Krinkle set Security to None.
Krinkle added a project: JavaScript.
Krinkle edited subscribers, added: Krinkle; removed: Unknown Object (MLST).