Title highlighting is wrong
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Sebastian_Berlin-WMSE
	May 18 2021, 9:24 AM

Project Tags

Referenced Files

	F34458688: highlighting-title-error.png
	May 18 2021, 9:24 AM

Subscribers

Description

Both the segment and token highlighting positions are wrong. This appears to only happen when run as a consumer.

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix highlighting being wrong for the title when using the new skin	mediawiki/extensions/Wikispeech	master	+60 -12

		Status	Subtype	Assigned	Task
		Resolved		Sebastian_Berlin-WMSE	T281662 ☂Enable running Wikispeech via gadget
		Resolved		Sebastian_Berlin-WMSE	T283063 Title highlighting is wrong

The segments for the title are the same whether you run locally or from consumer, so that's not the issue.

Apparently the new skin is the culprit. It's probably adding something to the h1 element that's not in the ~~page parse~~ display title.

Change 693433 had a related patch set uploaded (by Sebastian Berlin (WMSE); author: Sebastian Berlin (WMSE)):

[mediawiki/extensions/Wikispeech@master] Fix highlighting being wrong for the title when using the new skin

Change 693433 merged by jenkins-bot:

[mediawiki/extensions/Wikispeech@master] Fix highlighting being wrong for the title when using the new skin