Page MenuHomePhabricator
Create Task
Maniphest T283068

Add SVGO to Wikimedia deployed extensions
Closed, ResolvedPublic
Actions

Description

Derived from T278656, extensions with SVGs should make use of SVGO in our own configuration.

Extensions in need:

  • GrowthExperiments
  • Math
  • Thanks
  • TimedMediaHandler
  • Translate

Details

SubjectRepoBranchLines +/-
build: Add SVGO latest v2.8.0 and re-crush SVGsmediawiki/extensions/TimedMediaHandlermaster+418 -16
build: Add SVGO latest v2.8.0 and re-crush SVGsmediawiki/extensions/Thanksmaster+396 -5
build: Add SVGO to latest v2.3.0 and re-crush SVGsmediawiki/extensions/Mathmaster+696 -11 K
build: Add SVGO to latest v2.3.0 and re-crush SVGsmediawiki/extensions/Translatemaster+331 -80
build: Add SVGO to latest v2.3.0 and re-crush SVGsmediawiki/extensions/GrowthExperimentsmaster+2 K -2 K
Customize query in gerrit

Related Objects

Event Timeline

Volker_E created this task.May 18 2021, 11:30 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 18 2021, 11:30 AM
Aklapper added projects: TimedMediaHandler, MediaWiki-extensions-Translate, GrowthExperiments.May 18 2021, 11:36 AM
gerritbot added a comment.May 18 2021, 4:32 PM

Change 692641 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/GrowthExperiments@master] build: Add SVGO to latest v2.3.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/692641

gerritbot added a project: Patch-For-Review.May 18 2021, 4:32 PM
gerritbot added a comment.May 19 2021, 8:15 AM

Change 692848 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/Math@master] build: Add SVGO to latest v2.3.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/692848

gerritbot added a comment.May 19 2021, 9:27 AM

Change 692854 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/Translate@master] build: Add SVGO to latest v2.3.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/692854

Tgr edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.May 21 2021, 12:55 PM
Tgr moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
Tgr triaged this task as Low priority.May 21 2021, 1:00 PM
Nikerabbit moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.May 24 2021, 10:36 AM
Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.May 24 2021, 7:11 PM
gerritbot added a comment.May 24 2021, 7:28 PM

Change 692641 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] build: Add SVGO to latest v2.3.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/692641

gerritbot added a comment.May 25 2021, 5:47 AM

Change 692854 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] build: Add SVGO to latest v2.3.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/692854

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.9; 2021-06-07).May 25 2021, 6:00 AM
Physikerwelt subscribed.May 28 2021, 8:52 AM

I am not sure if is a good idea to add indention to math images. This will increase the size to be transferred via network connections.

Volker_E added a comment.May 28 2021, 11:36 AM

@Physikerwelt You're most definitely right for math SVGs, The only change needed would be to set pretty: false on the repo's '.svgo.config.js'.

Volker_E updated the task description. (Show Details)May 28 2021, 11:36 AM
gerritbot added a comment.Jun 10 2021, 6:51 PM

Change 692848 abandoned by VolkerE:

[mediawiki/extensions/Math@master] build: Add SVGO to latest v2.3.0 and re-crush SVGs

Reason:

It seems they are only used for testing.
Hence abandoning.

https://gerrit.wikimedia.org/r/692848

Volker_E updated the task description. (Show Details)Jun 10 2021, 6:51 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 10 2021, 7:10 PM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 14 2021, 11:14 PM
Etonkovidova subscribed.

Checked GrowthExperiments in wmf.9 - no regression issues have been found. @Volker_E - the task should be open for addressing Thanks and
TimedMediaHandler?

Volker_E added a comment.Jun 15 2021, 10:18 AM

@Etonkovidova Thanks for your service! :)
Yes, correct. Task remains open with other two extensions to go.

Etonkovidova removed a project: Growth-Team (Sprint 0 (Growth Team)).Jul 12 2021, 12:31 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 12 2021, 12:31 AM
• mewoph moved this task from Inbox to Triaged on the Growth-Team board.Jul 12 2021, 9:44 PM
Volker_E added a project: SVG.Feb 6 2022, 9:55 PM
gerritbot added a comment.Feb 7 2022, 12:33 PM

Change 760544 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/TimedMediaHandler@master] build: Add SVGO latest v2.8.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/760544

gerritbot added a project: Patch-For-Review.Feb 7 2022, 12:33 PM
gerritbot added a comment.Feb 7 2022, 1:12 PM

Change 760568 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/Thanks@master] build: Add SVGO latest v2.8.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/760568

gerritbot added a comment.Feb 7 2022, 6:02 PM

Change 760568 merged by jenkins-bot:

[mediawiki/extensions/Thanks@master] build: Add SVGO latest v2.8.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/760568

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.21; 2022-02-07).Feb 7 2022, 7:00 PM
Volker_E updated the task description. (Show Details)Feb 7 2022, 10:52 PM
gerritbot added a comment.Feb 7 2022, 10:59 PM

Change 760544 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] build: Add SVGO latest v2.8.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/760544

Volker_E closed this task as Resolved.Feb 7 2022, 11:00 PM
Volker_E claimed this task.
Volker_E removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL