PHP Notice: Undefined property: ChangeTagsRevisionList::$page
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	dancy
	May 18 2021, 5:56 PM

Description

Error

mwversion: 1.37.0-wmf.5
reqId: 42a29b90-f49e-4379-82b5-a4d3e496be45
Find reqId in Logstash
Find normalized_message in Logstash

normalized_message

[{reqId}] {exception_url}   PHP Notice: Undefined property: ChangeTagsRevisionList::$page

exception.trace

from /srv/mediawiki/php-1.37.0-wmf.5/includes/debug/DeprecationHelper.php(152)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.37.0-wmf.5/includes/debug/DeprecationHelper.php(152): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.37.0-wmf.5/includes/changetags/ChangeTagsRevisionList.php(48): RevisionListBase->__get(string)
#3 /srv/mediawiki/php-1.37.0-wmf.5/includes/revisionlist/RevisionListBase.php(109): ChangeTagsRevisionList->doQuery(Wikimedia\Rdbms\MaintainableDBConnRef)
#4 /srv/mediawiki/php-1.37.0-wmf.5/includes/specials/SpecialEditTags.php(244): RevisionListBase->reset()
#5 /srv/mediawiki/php-1.37.0-wmf.5/includes/specials/SpecialEditTags.php(158): SpecialEditTags->showForm()
#6 /srv/mediawiki/php-1.37.0-wmf.5/includes/specialpage/SpecialPage.php(646): SpecialEditTags->execute(string)
#7 /srv/mediawiki/php-1.37.0-wmf.5/includes/actions/SpecialPageAction.php(81): SpecialPage->run(string)
#8 /srv/mediawiki/php-1.37.0-wmf.5/includes/MediaWiki.php(535): SpecialPageAction->show()
#9 /srv/mediawiki/php-1.37.0-wmf.5/includes/MediaWiki.php(319): MediaWiki->performAction(Article, Title)
#10 /srv/mediawiki/php-1.37.0-wmf.5/includes/MediaWiki.php(916): MediaWiki->performRequest()
#11 /srv/mediawiki/php-1.37.0-wmf.5/includes/MediaWiki.php(550): MediaWiki->main()
#12 /srv/mediawiki/php-1.37.0-wmf.5/index.php(53): MediaWiki->run()
#13 /srv/mediawiki/php-1.37.0-wmf.5/index.php(46): wfIndexMain()
#14 /srv/mediawiki/w/index.php(3): require(string)
#15 {main}

Notes

These have been appearing slowly but steadily since 2021-05-13 (week of wmf.5 rollout).

Details

Request URL: https://meta.wikimedia.org/w/index.php?title=*&action=editchangetags&type=*&ids%5B21469674%5D=*&ids%5B21436344%5D=*&ids%5B21335244%5D=*

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Fix call to non-existent var	mediawiki/core	wmf/1.37.0-wmf.5	+1 -1
Fix call to non-existent var	mediawiki/core	wmf/1.37.0-wmf.6	+1 -1
Fix call to non-existent var	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	• mmodell	T281148 1.37.0-wmf.7 deployment blockers
		Resolved	PRODUCTION ERROR	Zabe	T283098 PHP Notice: Undefined property: ChangeTagsRevisionList::$page

Event Timeline

dancy created this task.May 18 2021, 5:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 18 2021, 5:56 PM

dancy mentioned this in T283099: Error: Call to a member function getId() on null.May 18 2021, 5:59 PM

dancy added a parent task: T281148: 1.37.0-wmf.7 deployment blockers.May 18 2021, 6:32 PM

dancy mentioned this in T281148: 1.37.0-wmf.7 deployment blockers.

Change 692685 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Fix call to non-existent var

https://gerrit.wikimedia.org/r/692685

gerritbot added a project: Patch-For-Review.May 18 2021, 6:45 PM

Caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/685570

Zabe moved this task from Untriaged to May 2021 on the Wikimedia-production-error board.May 18 2021, 7:09 PM

Change 692685 merged by jenkins-bot:

[mediawiki/core@master] Fix call to non-existent var

https://gerrit.wikimedia.org/r/692685

Change 692654 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@wmf/1.37.0-wmf.5] Fix call to non-existent var

https://gerrit.wikimedia.org/r/692654

Change 692655 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@wmf/1.37.0-wmf.6] Fix call to non-existent var

https://gerrit.wikimedia.org/r/692655

In T283098#7096459, @Zabe wrote:

Caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/685570

Ref for "Mentions" tracking purposes: T278459

Reedy triaged this task as High priority.May 19 2021, 2:41 AM

Change 692655 merged by jenkins-bot:

[mediawiki/core@wmf/1.37.0-wmf.6] Fix call to non-existent var

https://gerrit.wikimedia.org/r/692655

Change 692654 merged by jenkins-bot:

[mediawiki/core@wmf/1.37.0-wmf.5] Fix call to non-existent var

https://gerrit.wikimedia.org/r/692654

Mentioned in SAL (#wikimedia-operations) [2021-05-19T03:01:47Z] <reedy@deploy1002> Synchronized php-1.37.0-wmf.6/includes/changetags/ChangeTagsRevisionList.php: T283098 T283099 (duration: 02m 35s)

Mentioned in SAL (#wikimedia-operations) [2021-05-19T03:03:10Z] <reedy@deploy1002> Synchronized php-1.37.0-wmf.5/includes/changetags/ChangeTagsRevisionList.php: T283098 T283099 (duration: 01m 05s)