Page MenuHomePhabricator

DiscussionTools overlaps text when replying on an RfA
Closed, ResolvedPublic

Description

How to reproduce

  1. Go to https://en.wikipedia.org/wiki/Wikipedia:Requests_for_adminship/Ashleyyoursmile
  2. Make sure you are logged in
  3. Scroll down to optional question 7
  4. Click on "reply" on Ashleyyoursmile's reply to the question

Actual behaviour
The below appears. It is a scrollable, overlapping chunk of text.

Screen Shot 2021-05-19 at 9.10.52 AM.png (631×997 px, 430 KB)

Video:
https://files.catbox.moe/tiyhbo.mp4
(I hosted it externally as Phabricator wouldn't let me upload a video (probably intended functionality))
Expected behaviour
The normal replying interface appears.

Event Timeline

I can reproduce. There's an error in browser console:

Uncaught DOMException: Failed to execute 'insertBefore' on 'Node': Only one element on document allowed.
    at Object.addListItem (https://en.wikipedia.org/w/load.php?lang=en&modules=ext.discussionTools.init%7Cjquery%2Coojs-ui-core&skin=vector&version=130xy:37:72)
    at CommentController.js.CommentController.setup (https://en.wikipedia.org/w/load.php?lang=en&modules=ext.discussionTools.init%7Cjquery%2Coojs-ui-core&skin=vector&version=130xy:17:589)
    at https://en.wikipedia.org/w/load.php?lang=en&modules=ext.discussionTools.init%7Cjquery%2Coojs-ui-core&skin=vector&version=130xy:10:712
    at CommentController.OO.EventEmitter.emit (<anonymous>:430:652)
    at CommentController.js.CommentController.onReplyLinkClick (https://en.wikipedia.org/w/load.php?lang=en&modules=ext.discussionTools.init%7Cjquery%2Coojs-ui-core&skin=vector&version=130xy:16:323)
    at HTMLAnchorElement.dispatch (https://en.wikipedia.org/w/load.php?lang=en&modules=ext.discussionTools.init%7Cjquery%2Coojs-ui-core&skin=vector&version=130xy:322:214)
    at HTMLAnchorElement.elemData.handle (https://en.wikipedia.org/w/load.php?lang=en&modules=ext.discussionTools.init%7Cjquery%2Coojs-ui-core&skin=vector&version=130xy:318:848)

Based on this error message, and based on the contents of the page with the issue, I think this is likely the same bug as T279445 and likely to be fixed by the patch there.

(I hosted it externally as Phabricator wouldn't let me upload a video (probably intended functionality))

Our Phabricator allows video uploads, but only up to 4 MB, due to abuse a few years ago. If you use WEBM, there's even an inline player. We have a bug report about making it produce a better error message: T155130.

Thanks for the task link. As a note: the error message in DiscussionTools also displays the same error with any other message.

This is likely fixed by the patch for T279445 (which should be deployed to Wikimedia wikis two weeks from now, with software version 1.37.0-wmf.9). If it turns out not to be fixed, then I'll investigate.

ppelberg claimed this task.