Page MenuHomePhabricator
Create Task
Maniphest T283212

Allow banner to be shown on Main Page
Closed, ResolvedPublic
Actions

Description

Currently, it's not possible to add a banner to the main page of a wiki. It would be useful on some wikis to be able to show a banner on the main page.

Does this need a new configuration variable, e.g. $wgWPBEnableMainPage? I'm not sure of the background as to why banners are prevented on the main page.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add $wgWPBEnableMainPage to enable banners on Main Pagemediawiki/extensions/WikidataPageBannerREL1_36+42 -17
Add $wgWPBEnableMainPage to enable banners on Main Pagemediawiki/extensions/WikidataPageBannerREL1_35+42 -17
Add $wgWPBEnableMainPage to enable banners on Main Pagemediawiki/extensions/WikidataPageBannermaster+42 -17
Customize query in gerrit

Event Timeline

Samwilson created this task.May 20 2021, 12:20 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2021, 12:20 AM
Maintenance_bot added a project: Wikidata.May 20 2021, 12:45 AM
Jdlrobson added projects: patch-welcome, Web-Team-Backlog-Archived (Tracking).May 24 2021, 4:00 PM
Jdlrobson subscribed.

I think it needs a new config value. I am currently the only one who writes and reviews patches for this repo, so if you can provide a patch I'll happily do that.

Samwilson added a project: Wikimedia Australia.May 24 2021, 10:48 PM

Will do, thanks!

gerritbot added a comment.May 25 2021, 2:02 AM

Change 694011 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/WikidataPageBanner@master] Add $wgWPBEnableMainPage to enable banners on Main Page

https://gerrit.wikimedia.org/r/694011

gerritbot added a project: Patch-For-Review.May 25 2021, 2:02 AM
gerritbot added a comment.May 27 2021, 7:02 PM

Change 694011 merged by jenkins-bot:

[mediawiki/extensions/WikidataPageBanner@master] Add $wgWPBEnableMainPage to enable banners on Main Page

https://gerrit.wikimedia.org/r/694011

Maintenance_bot removed a project: Patch-For-Review.May 27 2021, 7:10 PM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.9; 2021-06-07).May 27 2021, 8:00 PM
gerritbot added a comment.May 27 2021, 10:43 PM

Change 696532 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/WikidataPageBanner@REL1_35] Add $wgWPBEnableMainPage to enable banners on Main Page

https://gerrit.wikimedia.org/r/696532

gerritbot added a project: Patch-For-Review.May 27 2021, 10:43 PM
gerritbot added a comment.Jun 1 2021, 6:59 PM

Change 696532 merged by jenkins-bot:

[mediawiki/extensions/WikidataPageBanner@REL1_35] Add $wgWPBEnableMainPage to enable banners on Main Page

https://gerrit.wikimedia.org/r/696532

Maintenance_bot removed a project: Patch-For-Review.Jun 1 2021, 7:10 PM
Jdlrobson closed this task as Resolved.Jun 1 2021, 7:32 PM
Jdlrobson claimed this task.
gerritbot added a comment.Sep 22 2021, 2:29 AM

Change 722710 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/WikidataPageBanner@REL1_36] Add $wgWPBEnableMainPage to enable banners on Main Page

https://gerrit.wikimedia.org/r/722710

gerritbot added a project: Patch-For-Review.Sep 22 2021, 2:29 AM
gerritbot added a comment.Sep 22 2021, 3:21 AM

Change 722710 merged by jenkins-bot:

[mediawiki/extensions/WikidataPageBanner@REL1_36] Add $wgWPBEnableMainPage to enable banners on Main Page

https://gerrit.wikimedia.org/r/722710

Maintenance_bot removed a project: Patch-For-Review.Sep 22 2021, 4:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits