Use DomainDB abstraction in all places in Wikibase where DB connections are created or ILBFactory / ILoadBalancer are otherwise used
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Michael
	May 20 2021, 3:05 PM

Description

In T283354 a new abstraction was created to have a clearer boundary between MediaWiki and Wikibase. This abstraction should now be used in all places that are currently using ILBFactory or ILoadBalancer directly.

The child tasks of this task should cover almost every usage in Wikibase. Some places might require some more refactoring or limited extending of the new DbDomain class. Tickets for the remaining usages should be created once the current tickets are mostly implemented and a path forward is more clear.

We may want to consider adding another ticket for creating a test that asserts that LBFactory etc. is not used outside these services. For comparison see the Forbidden Client/Repo usage tests. => T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

⇉ More or less all usage of load balancer and load balancer factories except usage in the services for the new DbDomain factories should be refactored away: https://codesearch.wmcloud.org/extensions/?q=getDBLoadBalancer&i=nope&files=&excludeFiles=tests&repos=Extension:Wikibase

Related Objects
Search...

Status	Assigned	Task
Resolved	Addshore	T281453 Abstract database connections between Client and Repository
Resolved	Addshore	T283246 Use DomainDB abstraction in all places in Wikibase where DB connections are created or ILBFactory / ILoadBalancer are otherwise used
Resolved	Michael	T283328 Replace LBFactory with injecting new Db-Service in Client's ChangeModificationNotificationJob and child-classes
Resolved	• toan	T283330 [unusual] Replace LBFactory with injecting new Db-Service in Client's InjectRCRecordsJob
Resolved	Michael	T283331 Replace LBFactory with injecting new Db-Service in Client's BulkSubscriptionUpdater and UpdateSubscriptions maint script
Resolved	Lucas_Werkmeister_WMDE	T283334 Replace LBFactory with injecting new Db-Service in Client's DirectSqlStore
Resolved	Ladsgroup	T283339 Replace LBFactory with injecting new Db-Service in Client's EntityUsageTable class
Resolved	Lucas_Werkmeister_WMDE	T284651 Replace LBFactory with injecting new Db-Service in SiteLinkTable
Resolved	ItamarWMDE	T283340 Replace LBFactory with injecting new Db-Service in Client's EntityUsageTableBuilder
Resolved	Jakob_WMDE	T283342 Replace ILBFactory and ILoadBalancer with injecting new Db-Service in Lib's MatchingTermsLookupFactory and created classes: NameTableStore, DatabaseMatchingTermsLookup
Resolved	Michael	T283344 Replace ILBFactory and ILoadBalancer with injecting new Db-Service in Lib's WikiPageEntityMetaDataLookup and places that construct it
Resolved	Ladsgroup	T283343 Replace ILBFactory and ILoadBalancer with injecting new Db-Service in Lib's PropertyInfoTable and places that construct it
Resolved	Jakob_WMDE	T283348 Replace ILBFactory and ILoadBalancer with injecting new Db-Service in Lib's TermInLangIdsResolverFactory
Resolved	Jakob_WMDE	T283349 Replace ILBFactory and ILoadBalancer with injecting new Db-Service in Lib's DatabaseTermInLangIdsAcquirer and ReplicaMasterAwareRecordIdsAcquirer
Resolved	Michael	T283350 Replace ILBFactory and ILoadBalancer with injecting new Db-Service in Repo's SqlSubscriptionLookup
Resolved	Jakob_WMDE	T283354 Replace ILBFactory and ILoadBalancer with injecting new Db-Service in Repo's PurgeEntityDataJob
Resolved	Ladsgroup	T283932 Replace ILBFactory and ILoadBalancer with injecting new Db-Service in Repo's ChangePruner class and pruneChanges maint script
Resolved	Ladsgroup	T283934 Replace ILBFactory and ILoadBalancer with injecting new Db-Service in Repo's WikibasePingback class
Resolved	ItamarWMDE	T283937 Replace ILBFactory with injecting new Db-Service in Repo's DispatchChangeDeletionNotificationJob
Resolved	Ladsgroup	T283939 [unusual] Replace LBFactory with injecting new Db-Service in Repo's DatabaseSchemaUpdater and its child classes ItemTermsRebuilder and PropertyTermsRebuilder
Resolved	ItamarWMDE	T283941 Replace ILBFactory with injecting new Db-Service in Repo's RebuildItemsPerSite maintenance script and associated class ItemsPerSiteBuilder
Resolved	dang	T283946 Replace ILBFactory with the new Db-Service in Repo's CleanTermsIfUnusedJob and related classes
Resolved	Lucas_Werkmeister_WMDE	T283945 Remove RemoveDeletedItemsFromTermStore maintenance script
Resolved	Ladsgroup	T285036 Replace ILBFactory with the new Db-Service in Repo's WikibaseRepo.EntityConstraintProvider service and SqlSiteLinkConflictLookup class
Resolved	Lucas_Werkmeister_WMDE	T285037 Replace ILBFactory with the new Db-Service in Repo's WikibaseRepo.IdGenerator service and its IdGenerator classes
Resolved	Lucas_Werkmeister_WMDE	T285038 Replace ILBFactory with the new Db-Service in Repo's WikibaseRepo.TermsCollisionDetectorFactory service and classes created therein
Resolved	Lucas_Werkmeister_WMDE	T285042 [unusual] Replace LoadBalancer in client's ChangesListSpecialPageHookHandler
Resolved	• toan	T285087 Add convenience methods to create RepoDomainDb/ClientDomainDb from IDatabase
Resolved	• toan	T285088 Replace ILoadBalancer with injecting new Db-Service in Lib's SqlChangeStore
Resolved	Lucas_Werkmeister_WMDE	T285089 Replace ILoadBalancer with injecting new Db-Service in Repo's WikiPageEntityRedirectLookup
Resolved	Ladsgroup	T285224 Replace ILoadBalancer with using the new Db-Service in Client's DirectSqlStore
Resolved	Lucas_Werkmeister_WMDE	T285227 Replace ILBFactory by injecting new Db-Service in Repo's PropertyInfoTableBuilder
Resolved	Ladsgroup	T285228 Replace ILBFactory by using the new Db-Service in Repo's dispatchChanges maint. script and classes SqlChangeDispatchCoordinator and LockManagerSqlChangeDispatchCoordinator
Resolved	Ladsgroup	T285230 Replace ILBFactory by injecting new Db-Service in Repo's pruneItemsPerSite maintenance script
Resolved	Ladsgroup	T285288 Use DomainDb in SpecialUnconnectedPages
Resolved	Ladsgroup	T285290 Replace ILBFactory by injecting new Db-Service in Client's UpdateRepo class and add MaxLag functionality
Resolved	Ladsgroup	T286250 Replace wfGetDB() by injecting new Db-Service in Repo's DispatchStats class
Resolved	Ladsgroup	T286251 Replace wfGetDB() by injecting new Db-Service in Repo's SqlEntityIdPager class
Resolved	Ladsgroup	T286252 Replace wfGetDB() by injecting new Db-Service in Repo's SqlItemsWithoutSitelinksFinder class
Resolved	Ladsgroup	T286253 Replace wfGetDB() by injecting new Db-Service in Repo's WikiPageEntityStore class
Resolved	Ladsgroup	T286254 Replace wfGetDB() by injecting new Db-Service in Repo's SiteLinkUniquenessValidator class
Resolved	Ladsgroup	T286280 Replace wfGetDB() by injecting new Db-Service in Client's SpecialEntityUsage class
Resolved	Ladsgroup	T286282 Replace wfGetDB() by injecting new Db-Service in Client's populateInterwiki. maintenance script

Event Timeline

Michael created this task.May 20 2021, 3:05 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2021, 3:05 PM

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.May 20 2021, 3:15 PM

Maintenance_bot moved this task from Inbox to Active on the [DEPRECATED] wdwb-tech board.

Michael claimed this task.May 21 2021, 8:56 AM

Michael moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Restricted Application added a project: User-Michael. · View Herald TranscriptMay 21 2021, 8:56 AM

Michael mentioned this in T283245: Create database connection service abstraction.May 21 2021, 9:42 AM

Things that do not strictly fall under this ticket as usage and so do not have a subtask (yet):

LBFactory mentioned in config in WikibaseClient.example.php
LBFactory mentioned in DataUpdateHookHandler comment: * @param mixed $ticket Prior result of LBFactory::getEmptyTransactionTicket()
ChangesListSpecialPageHookHandler::factory and SpecialUnconnectedPages get an ILoadBalancer injected via the extension-client.json - what do we do with that?