Page MenuHomePhabricator

Make MW master tests pass on PHP 8.0
Closed, ResolvedPublic

Description

See also: T292847: Make MW 1.37 tests pass on PHP 8.0, T283208: Make MW 1.36 tests pass on PHP 8.0, T274966: Make MW 1.35 tests pass on PHP 8.0; possibly some overlap...

But CI won't run due to older versions of elasticsearch libraries that don't support PHP 8.0 :(

19:42:31   Problem 1
19:42:31     - elasticsearch/elasticsearch v6.5.1 requires php ^7.0 -> your PHP version (8.0.5) does not satisfy that requirement.
19:42:31     - elasticsearch/elasticsearch v6.5.1 requires php ^7.0 -> your PHP version (8.0.5) does not satisfy that requirement.
19:42:31     - elasticsearch/elasticsearch v6.5.1 requires php ^7.0 -> your PHP version (8.0.5) does not satisfy that requirement.
19:42:31     - Installation request for elasticsearch/elasticsearch 6.5.1 -> satisfiable by elasticsearch/elasticsearch[v6.5.1].

Related Objects

StatusSubtypeAssignedTask
ResolvedNone
ResolvedJdforrester-WMF
ResolvedNone
ResolvedEBernhardson
ResolvedGehel
ResolvedEBernhardson
ResolvedEBernhardson
Resolveddcausse
Resolveddcausse
Resolveddcausse
Resolveddcausse
Resolveddcausse
OpenNone
ResolvedEBernhardson
DuplicateNone
ResolvedEBernhardson
Resolved EJoseph
ResolvedEBernhardson
DuplicateNone
ResolvedGehel
Resolved EJoseph
Resolvedbking
Resolvedbking
ResolvedRKemper
ResolvedRKemper
ResolvedRKemper
ResolvedRKemper
ResolvedGehel
Resolvedbking
Resolvedbking
Resolvedbking
Resolvedbking
Resolvedbking
Resolvedbking
Resolvedbking
ResolvedEBernhardson
ResolvedEBernhardson
ResolvedTJones
Resolved Zbyszko
DeclinedNone
DeclinedNone
ResolvedTJones
ResolvedEBernhardson
DeclinedNone
Resolvedbd808
DeclinedNone
ResolvedEBernhardson
DeclinedNone
Resolveddcausse
ResolvedEBernhardson
ResolvedEBernhardson
ResolvedEBernhardson
Resolvedbking
ResolvedGehel
ResolvedGehel
ResolvedRKemper
ResolvedBUG REPORTEBernhardson
ResolvedEBernhardson
ResolvedRKemper
ResolvedEBernhardson
Resolvedkostajh

Event Timeline

Change 755844 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Fix PHP 8.0 failure of RefreshSecondaryDataUpdateTest

https://gerrit.wikimedia.org/r/755844

Change 755845 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Fix PHP 8.0 failure of WikiExporterFactoryTest

https://gerrit.wikimedia.org/r/755845

Change 755846 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] MapCacheLRU: Restore key type checks

https://gerrit.wikimedia.org/r/755846

Composer works now, following gerrit 748168. All core tests pass for me after my changes above and the one linked to T268847.

Change 755934 had a related patch set uploaded (by Reedy; author: Tim Starling):

[mediawiki/core@REL1_37] Fix PHP 8.0 failure of RefreshSecondaryDataUpdateTest

https://gerrit.wikimedia.org/r/755934

Change 755935 had a related patch set uploaded (by Reedy; author: Tim Starling):

[mediawiki/core@REL1_37] Fix PHP 8.0 failure of WikiExporterFactoryTest

https://gerrit.wikimedia.org/r/755935

Change 755937 had a related patch set uploaded (by Reedy; author: Tim Starling):

[mediawiki/core@REL1_36] Fix PHP 8.0 failure of WikiExporterFactoryTest

https://gerrit.wikimedia.org/r/755937

Change 755938 had a related patch set uploaded (by Reedy; author: Tim Starling):

[mediawiki/core@REL1_35] Fix PHP 8.0 failure of WikiExporterFactoryTest

https://gerrit.wikimedia.org/r/755938

Change 755943 had a related patch set uploaded (by Reedy; author: Tim Starling):

[mediawiki/core@REL1_37] MapCacheLRU: Restore key type checks

https://gerrit.wikimedia.org/r/755943

Change 755844 merged by jenkins-bot:

[mediawiki/core@master] Fix PHP 8.0 failure of RefreshSecondaryDataUpdateTest

https://gerrit.wikimedia.org/r/755844

Change 755845 merged by jenkins-bot:

[mediawiki/core@master] Fix PHP 8.0 failure of WikiExporterFactoryTest

https://gerrit.wikimedia.org/r/755845

Change 755846 merged by jenkins-bot:

[mediawiki/core@master] MapCacheLRU: Restore key type checks

https://gerrit.wikimedia.org/r/755846

Change 755938 merged by jenkins-bot:

[mediawiki/core@REL1_35] Fix PHP 8.0 failure of WikiExporterFactoryTest

https://gerrit.wikimedia.org/r/755938

Change 755937 merged by jenkins-bot:

[mediawiki/core@REL1_36] Fix PHP 8.0 failure of WikiExporterFactoryTest

https://gerrit.wikimedia.org/r/755937

Change 755934 merged by jenkins-bot:

[mediawiki/core@REL1_37] Fix PHP 8.0 failure of RefreshSecondaryDataUpdateTest

https://gerrit.wikimedia.org/r/755934

Change 755935 merged by jenkins-bot:

[mediawiki/core@REL1_37] Fix PHP 8.0 failure of WikiExporterFactoryTest

https://gerrit.wikimedia.org/r/755935

Change 755943 merged by jenkins-bot:

[mediawiki/core@REL1_37] MapCacheLRU: Restore key type checks

https://gerrit.wikimedia.org/r/755943

So this is passing now on master, at least for the "composer" version of tests.

Not sure if this should remain open for the "vendor" version of these tests or not.

So this is passing now on master, at least for the "composer" version of tests.

Not sure if this should remain open for the "vendor" version of these tests or not.

I was planning to keep it open until the full suite is running, yes.

Now resolved for core. Great work, all!