Maniphest T283307

Adyen Checkout: normalize API error codes
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Map some reasonable subset of the most common Adyen-side API error codes onto our normalized error codes at the SmashPig layer.

https://docs.adyen.com/development-resources/error-codes#checkout-error-codes

Details

	Subject	Repo	Branch	Lines +/-
	Map Adyen API error codes to exceptions	wikimedia/fundraising/SmashPig	master	+309 -2
	Rename mapErrors function	wikimedia/fundraising/SmashPig	master	+6 -6

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T277120 Epic: Adyen reintegration, Drop In Web
		Resolved		Ejegg	T283307 Adyen Checkout: normalize API error codes

Event Timeline

Ejegg created this task.May 21 2021, 2:16 AM

• DStrine moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.May 21 2021, 8:27 PM

• DStrine moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Jun 22 2021, 7:39 PM

• DStrine added a project: Fundraising Sprint Mandatory corn dogs.Jun 22 2021, 7:42 PM

• DStrine triaged this task as High priority.Jun 22 2021, 9:19 PM

• DStrine added a project: fundraising Sprint NULL calorie food cart.Jul 20 2021, 8:22 PM

Here is an example error response:
{

"body": {
    "status": 422,
    "errorCode": "130",
    "message": "Required field 'reference' is not provided.",
    "errorType": "validation",
    "pspReference": "861626821535792F"
},
"headers": {
    "Date": "Tue, 20 Jul 2021 22:52:15 GMT",
    "Server": "Apache",
    "Set-Cookie": "JSESSIONID=D009A0331113A91D6683A5A18639F75B.test108e; Path=\/checkout; Secure; HttpOnly",
    "pspReference": "861626821535792F",
    "Transfer-Encoding": "chunked",
    "Content-Type": "application\/json;charset=UTF-8"
},
"status": 422

}

Cstone added a comment.Jul 21 2021, 1:46 AM

This comment was removed by Cstone.

Ejegg moved this task from Backlog to Pending Deployment on the fundraising Sprint NULL calorie food cart board.Jul 23 2021, 3:31 AM

Ejegg moved this task from Pending Deployment to Backlog on the fundraising Sprint NULL calorie food cart board.

• DStrine added a project: fundraising sprint onion pit.Aug 3 2021, 8:41 PM

XenoRyet set the point value for this task to 2.Aug 10 2021, 8:02 PM

Ejegg claimed this task.Aug 11 2021, 5:13 PM

Ejegg moved this task from Backlog to Doing on the fundraising sprint onion pit board.

Change 711606 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Rename mapErrors function

https://gerrit.wikimedia.org/r/711606

gerritbot added a project: Patch-For-Review.Aug 11 2021, 5:14 PM

Change 711700 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Map Adyen API error codes to exceptions

https://gerrit.wikimedia.org/r/711700

Ejegg moved this task from Doing to Review on the fundraising sprint onion pit board.Aug 11 2021, 10:40 PM

Change 711606 abandoned by Ejegg:

[wikimedia/fundraising/SmashPig@master] Rename mapErrors function

Reason:

https://gerrit.wikimedia.org/r/711606

Change 711700 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Map Adyen API error codes to exceptions

https://gerrit.wikimedia.org/r/711700

Cstone moved this task from Review to Pending Deployment on the fundraising sprint onion pit board.Aug 13 2021, 2:58 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 13 2021, 3:10 PM

• DStrine added a project: fundraising sprint Parallel processing roller coaster.Aug 17 2021, 8:46 PM

Cstone moved this task from Backlog to Pending Deployment on the fundraising sprint Parallel processing roller coaster board.Aug 18 2021, 3:39 PM

XenoRyet added a project: fundraising sprint Quantum Leapfrog.Aug 31 2021, 8:35 PM

Ejegg moved this task from Backlog to Pending Deployment on the fundraising sprint Quantum Leapfrog board.Sep 2 2021, 1:46 AM

• DStrine added a project: fundraising sprint Roller Toaster.Sep 14 2021, 7:42 PM

Cstone moved this task from Backlog to Pending Deployment on the fundraising sprint Roller Toaster board.Sep 17 2021, 3:44 PM

XenoRyet added a project: fundraising sprint Screaming Goats Yelling Zoo.Sep 28 2021, 7:51 PM

Ejegg closed this task as Resolved.Oct 12 2021, 7:10 PM

Ejegg moved this task from Backlog to Done on the fundraising sprint Screaming Goats Yelling Zoo board.