Maniphest T283343

Replace ILBFactory and ILoadBalancer with injecting new Db-Service in Lib's PropertyInfoTable and places that construct it
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Michael
	May 21 2021, 11:39 AM

Tags

Referenced Files

None

Subscribers

Description

PropertyInfoTable has a failry standard usage pattern:

$this->loadBalancer = $lbFactory->getMainLB( $databaseName );

public function getWriteConnection(): IDatabase {
	return $this->loadBalancer->getConnectionRef( ILoadBalancer::DB_PRIMARY, [], $this->dbName );
}

private function getReadConnection(): IDatabase {
	return $this->loadBalancer->getConnectionRef( ILoadBalancer::DB_REPLICA, [], $this->dbName );
}

Details

	Subject	Repo	Branch	Lines +/-
	Use DomainDb in PropertyInfoTable	mediawiki/extensions/Wikibase	master	+28 -43

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Addshore	T281453 Abstract database connections between Client and Repository
		Resolved		Addshore	T283246 Use DomainDB abstraction in all places in Wikibase where DB connections are created or ILBFactory / ILoadBalancer are otherwise used
		Resolved		Ladsgroup	T283343 Replace ILBFactory and ILoadBalancer with injecting new Db-Service in Lib's PropertyInfoTable and places that construct it

Event Timeline

Michael created this task.May 21 2021, 11:39 AM

Michael removed a project: [DEPRECATED] wdwb-tech.May 21 2021, 3:34 PM

Michael moved this task from To Do (prioritised from top to bottom) to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 25 2021, 9:52 AM

Michael moved this task from Stalled/Waiting to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 8 2021, 10:58 AM

Ladsgroup claimed this task.Jun 9 2021, 6:27 AM

Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJun 9 2021, 6:27 AM

Change 698942 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/Wikibase@master] Use DomainDb in PropertyInfoTable

https://gerrit.wikimedia.org/r/698942

gerritbot added a project: Patch-For-Review.Jun 9 2021, 6:51 AM

Error: Call to undefined method Wikibase\Lib\Rdbms\RepoDomainDbFactory::newForEntityType()

wat?

Aha. My localhost was old and this has been removed.

Ladsgroup moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 9 2021, 7:42 AM

Change 698942 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use DomainDb in PropertyInfoTable

https://gerrit.wikimedia.org/r/698942

Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 9 2021, 10:15 AM

Maintenance_bot removed a project: Patch-For-Review.Jun 9 2021, 11:10 AM

Ladsgroup closed this task as Resolved.Jun 11 2021, 9:27 AM

Michael mentioned this in T283939: [unusual] Replace LBFactory with injecting new Db-Service in Repo's DatabaseSchemaUpdater and its child classes ItemTermsRebuilder and PropertyTermsRebuilder.Jun 11 2021, 7:41 PM

valhallasw mentioned this in T284587: ReleaseTaggerBot skipping some Tasks/Patches?.Jun 12 2021, 8:03 PM

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 12 2021, 8:11 PM