| Tgr | |
| May 21 2021, 1:26 PM |
| F59066307: Screenshot 2025-04-14 at 7.59.20 PM.png | |
| Apr 15 2025, 3:05 AM |
this edit is made by a restricted VisualEiditor interface (Add-Link-Structured-Task) which only adds links so this is probably a Parsoid roundtrip issue. The old text is
<onlyinclude>{| ...
...
|}</onlyinclude>the new text is
<onlyinclude>
{| ...
...
|}
</onlyinclude>(the link edit was to a completely different part of the page).
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| ve.dm.MWIncludesNode: Preserve HTML attributes | mediawiki/extensions/VisualEditor | master | +2 -0 |
I couldn't reproduce readily with a bunch of simplified test cases on the command line. So, this looks like some edge case specific to this page, if at all.
It's reproducible with,
https://ar.wikipedia.org/w/index.php?title=%D8%A8%D9%8A%D9%86%D9%8A_%D8%AF%D8%B1%D9%8A%D8%AF%D9%81%D9%88%D9%84_(%D9%85%D8%B3%D9%84%D8%B3%D9%84)&oldid=53445436&veaction=edit
It looks like what's being sent is,
<meta typeof="mw:Includes/OnlyInclude" id="mwXA"><table class="wikitable" style="text-align: center;" id="mwXQ"> <tbody id="mwXg"><tr id="mwXw"> ... </tbody></table><meta typeof="mw:Includes/OnlyInclude/End" id="mwgw">
and returned,
<meta typeof="mw:Includes/OnlyInclude"><table class="wikitable" style="text-align: center;" id="mwXQ"> <tbody id="mwXg"><tr id="mwXw"> ... </tbody></table><meta typeof="mw:Includes/OnlyInclude/End">
so the ids on the meta tags are being stripped, which makes Parsoid believe this is new content and normalizes it when serializing.
Change #1134380 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.dm.MWIncludesNode: Preserve HTML attributes
Change #1134380 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.dm.MWIncludesNode: Preserve HTML attributes
That should fix it, but I'd also like to Editing team to double-check it. I hope you don't mind me putting this on your board, and can find some time to QA it. Thanks!
I tested this on the page where it was reported originally by adding a link to a text. I don't see any line break being added inside the <onlyinclude> markup anymore.
Is removing of all project tags expected, @VPuffetMichel? It is now much harder to find this task and to track previous work for those projects.