Maniphest T283387

transformFilePath complains when $wgLogo points to a dynamic url
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

MarkAHershberger

Authored By

	MarkAHershberger
	May 21 2021, 5:59 PM

Tags

Referenced Files

None

Subscribers

MarkAHershberger

Description

List of steps to reproduce:

Set $wgLogo to something like "/thumb.php?f=Wiki.svg?width=120"
Create similar entries for $wgLogoHD
Load the wiki and observe that the logo appears

What happens?:
Check the logs for messages like "failed to hash .../thumb.php?f=Wiki.svg?width=120" from OutputPage::transformFilePath()

Over time the log will fill with these superfluous messages.

What should have happened instead?:

MW should recognize that this is not a file and not try to use md5_file on it.

Details

	Subject	Repo	Branch	Lines +/-
	Stop logging and md5'ing if the file does not exist	mediawiki/core	master	+11 -6

Customize query in gerrit

Event Timeline

MarkAHershberger created this task.May 21 2021, 5:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 21 2021, 5:59 PM

Change 693478 had a related patch set uploaded (by MarkAHershberger; author: MarkAHershberger):

[mediawiki/core@master] Stop logging and md5'ing if the file does not exist

https://gerrit.wikimedia.org/r/693478

gerritbot added a project: Patch-For-Review.May 21 2021, 6:17 PM

Maintenance_bot added a project: Commons.May 21 2021, 6:45 PM

Change 693478 merged by jenkins-bot:

[mediawiki/core@master] Stop logging and md5'ing if the file does not exist

https://gerrit.wikimedia.org/r/693478

MarkAHershberger closed this task as Resolved.May 21 2021, 7:44 PM

MarkAHershberger claimed this task.

Krinkle edited projects, added MediaWiki-ResourceLoader; removed Commons, MediaWiki-File-management.May 21 2021, 7:55 PM

Restricted Application added a project: Performance-Team. · View Herald TranscriptMay 21 2021, 7:55 PM

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.7; 2021-05-25).May 21 2021, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 21 2021, 8:10 PM

MarkAHershberger updated the task description. (Show Details)May 21 2021, 8:29 PM