Page MenuHomePhabricator

SimpleSearch: Highlight state shouldn't be remembered
Closed, ResolvedPublic

Description

wgVectorPreferences={"editwarning": {"enable": 1}, "simplesearch": {"enable": "", "disablesuggest": 0}},

  1. Enter some text in the search box
  2. Wait for the dropdown box to appear
  3. Now no item is highlighted
  4. Mouseover the 'contains...' item, it gets highlighted
  5. Clear the search box and click somewhere else to make the dropdown box disappear
  6. Now it looks as if nothing has happened
  7. Repeat steps 1 and 2
  8. Without doing step 4, the item is highlighted

Version: unspecified
Severity: enhancement

Details

Reference
bz26350

Event Timeline

bzimport raised the priority of this task from to Low.
bzimport set Reference to bz26350.

SimpleSearch issues => Moving to Vector (as per $wgVectorUseSimpleSearch)

The whole mess is actually in core.

Still happening as described.

(Only applies to the "containing…" box, though.)

Change 82098 had a related patch set uploaded by Matmarex:
jquery.suggestions: Remove any highlights when hiding suggestions

https://gerrit.wikimedia.org/r/82098

maddiemadan wrote:

The "containing..." box still gets highlighted and it doesnt happen with any other suggestion.

Change 82098 merged by jenkins-bot:
jquery.suggestions: Remove any highlights when hiding suggestions

https://gerrit.wikimedia.org/r/82098

Fixed, and it only took three years and a change! Ah, the wonders of open-source software development!