Page MenuHomePhabricator

TypeError: backButton is undefined ve.ui.MWTransclusionDialog.prototype.updateActionSet
Closed, ResolvedPublic1 Estimated Story Points

Description

613 errors in last 12hrs began in most recent deploy
https://logstash.wikimedia.org/goto/d23e46a8ac853a5ae51156dc7790b915
Close to the criteria of issues that should block the train https://wikitech.wikimedia.org/wiki/Deployments/Holding_the_train#Issues_that_hold_the_train (1000 per 12hrs) so should be prioritized accordingly

at ve.ui.MWTransclusionDialog.prototype.updateActionSet URL1:1534:391
at ve.ui.MWTransclusionDialog.prototype.onReplacePart URL1:1530:454
at OO.EventEmitter.prototype.emit URL2:334:652
at ve.dm.MWTransclusionModel.prototype.process URL1:1466:9
at ve.dm.MWTransclusionModel.prototype.fetchRequestAlways URL1:1468:142
at fire URL2:213:897
at fireWith URL2:215:96
at Deferred/</deferred[tuple[0]] URL2:218:590
at ajax/xhr< URL2:416:391
at fire URL2:213:897
at fireWith URL2:215:96
at done URL2:297:491
at callback/< URL2:301:135

URL1: https://af.wikipedia.org/w/load.php?lang=af&modules=ext.visualEditor.articleTarget%2Cbase%2Ccore%2CdesktopArticleTarget%2CdesktopTarget%2Cdiffing%2Cicons%2Clanguage%2Cmediawiki%2Cmwalienextension%2Cmwcore%2Cmwextensions%2Cmwformatting%2Cmwgallery%2Cmwimage%2Cmwlanguage%2Cmwlink%2Cmwmeta%2Cmwsave%2Cmwsignature%2Cmwtransclusion%2Cmwwikitext%2Csanitize%2Cswitching%2Cwelcome%7Cext.visualEditor.core.desktop%2Cutils%7Cext.visualEditor.mwextensions.desktop%7Cext.visualEditor.mwimage.core&skin=vector&version=dvpin
URL2: https://af.wikipedia.org/w/load.php?lang=af&modules=ext.centralNotice.choiceData%2Cdisplay%2CgeoIP%2CkvStore%2CstartUp%7Cext.centralauth.ForeignApi%7Cext.centralauth.centralautologin.clearcookie%7Cext.cite.ux-enhancements%7Cext.cx.entrypoints.contributionsmenu%7Cext.cx.eventlogging.campaigns%7Cext.cx.interlanguagelink.init%7Cext.cx.widgets.callout%7Cext.echo.api%2Cinit%7Cext.eventLogging%2CnavigationTiming%2Cpopups%2CwikimediaEvents%7Cext.uls.common%2Ccompactlinks%2Cinterface%2Cpreferences%2Cwebfonts%7Cjquery%2Coojs%2Coojs-router%2Csite%7Cjquery.client%2Ccookie%2CtextSelection%7Cjquery.uls.data%7Cmediawiki.ForeignApi%2CString%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2Ccookie%2Cexperiments%2CjqueryMsg%2Clanguage%2Cstorage%2Cuser%2Cutil%2CvisibleTimeout%7Cmediawiki.ForeignApi.core%7Cmediawiki.editfont.styles%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.page.watch.ajax%7Cmediawiki.ui.button%2Cicon%7Cmmv.bootstrap%2Chead%7Cmmv.bootstrap.autostart%7Cskins.vector.legacy.js%7Cuser.defaults&skin=vector&version=yucd5

Event Timeline

Change 695075 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] Don't update backButton visibility if not set

https://gerrit.wikimedia.org/r/695075

Change 695075 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Don't update backButton visibility if not set

https://gerrit.wikimedia.org/r/695075

matmarex moved this task from To Triage to Triaged on the VisualEditor board.

Thanks for the quick response, I guess we should leave it for you to close?

Change 695831 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@wmf/1.37.0-wmf.7] Don't update backButton visibility if not set

https://gerrit.wikimedia.org/r/695831

Change 695832 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@wmf/1.37.0-wmf.6] Don't update backButton visibility if not set

https://gerrit.wikimedia.org/r/695832

Change 695832 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.37.0-wmf.6] Don't update backButton visibility if not set

https://gerrit.wikimedia.org/r/695832

Mentioned in SAL (#wikimedia-operations) [2021-05-27T11:51:03Z] <tgr@deploy1002> Synchronized php-1.37.0-wmf.6/extensions/VisualEditor/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js: Backport: [[gerrit:695832|Don't update backButton visibility if not set (T283511)]] (duration: 01m 06s)

Change 695831 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.37.0-wmf.7] Don't update backButton visibility if not set

https://gerrit.wikimedia.org/r/695831

Mentioned in SAL (#wikimedia-operations) [2021-05-27T12:25:19Z] <tgr@deploy1002> Synchronized php-1.37.0-wmf.7/extensions/VisualEditor/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js: Backport: [[gerrit:695831|Don't update backButton visibility if not set (T283511)]] (duration: 01m 06s)

Thanks for the quick response, I guess we should leave it for you to close?

Yes, thanks. Backports seem to have fixed the issue from appearing in production. We'll have a last round of review and will then close this ticket.

awight claimed this task.