Page MenuHomePhabricator

Wikibase Quality Constraints causes TypeError when accessing Special:SpecialPages
Closed, ResolvedPublic

Description

Steps to reproduce

  1. Install WikiBase Repository, WikiBase Client and Wikibase Quality Constraints
  2. Go to Special:SpecialPages and a TypeError appears instead of the page working correctly.
Argument 4 passed to WikibaseQuality\ConstraintReport\Specials\SpecialConstraintReport::__construct() must be an instance of Wikibase\Repo\EntityIdHtmlLinkFormatterFactory, instance of Wikibase\Repo\FederatedProperties\WrappingEntityIdFormatterFactory given, called in /srv/mediawiki/w/extensions/WikibaseQualityConstraints/src/Specials/SpecialConstraintReport.php on line 113
#0 /srv/mediawiki/w/extensions/WikibaseQualityConstraints/src/Specials/SpecialConstraintReport.php(113): WikibaseQuality\ConstraintReport\Specials\SpecialConstraintReport->__construct(Wikibase\DataModel\Services\Lookup\ExceptionIgnoringEntityLookup, Wikibase\Repo\Store\TypeDispatchingEntityTitleStoreLookup, Wikibase\Repo\EntityIdLabelFormatterFactory, Wikibase\Repo\FederatedProperties\WrappingEntityIdFormatterFactory, Wikibase\DataModel\Entity\DispatchingEntityIdParser, Wikibase\Lib\Formatters\OutputFormatValueFormatterFactory, WikibaseQuality\ConstraintReport\ConstraintCheck\DelegatingConstraintChecker, GlobalVarConfig, BufferingStatsdDataFactory)
#1 /srv/mediawiki/w/vendor/wikimedia/object-factory/src/ObjectFactory.php(172): WikibaseQuality\ConstraintReport\Specials\SpecialConstraintReport::newFromGlobalState(GlobalVarConfig, BufferingStatsdDataFactory, Wikibase\DataModel\Services\Lookup\ExceptionIgnoringEntityLookup, WikibaseQuality\ConstraintReport\ConstraintCheck\DelegatingConstraintChecker)
#2 /srv/mediawiki/w/vendor/wikimedia/object-factory/src/ObjectFactory.php(102): Wikimedia\ObjectFactory::getObjectFromSpec(array, array)
#3 /srv/mediawiki/w/includes/specialpage/SpecialPageFactory.php(470): Wikimedia\ObjectFactory->createObject(array, array)
#4 /srv/mediawiki/w/includes/specialpage/SpecialPageFactory.php(502): MediaWiki\SpecialPage\SpecialPageFactory->getPage(string)
#5 /srv/mediawiki/w/includes/specials/SpecialSpecialpages.php(56): MediaWiki\SpecialPage\SpecialPageFactory->getUsablePages(User)
#6 /srv/mediawiki/w/includes/specials/SpecialSpecialpages.php(44): SpecialSpecialpages->getPageGroups()
#7 /srv/mediawiki/w/includes/specialpage/SpecialPage.php(600): SpecialSpecialpages->execute(NULL)
#8 /srv/mediawiki/w/includes/specialpage/SpecialPageFactory.php(635): SpecialPage->run(NULL)
#9 /srv/mediawiki/w/includes/MediaWiki.php(307): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#10 /srv/mediawiki/w/includes/MediaWiki.php(940): MediaWiki->performRequest()
#11 /srv/mediawiki/w/includes/MediaWiki.php(543): MediaWiki->main()
#12 /srv/mediawiki/w/index.php(53): MediaWiki->run()
#13 /srv/mediawiki/w/index.php(46): wfIndexMain()
#14 {main}

Version: 1.35.2
PHP: 7.3.27-1~deb10u1 (fpm-fcgi)
MariaDB: 10.4.15-MariaDB-1:10.4.15+maria~buster-log

Event Timeline

Change 693655 had a related patch set uploaded (by Paladox; author: Tobias Andersson):

[mediawiki/extensions/WikibaseQualityConstraints@REL1_35] SpecialConstraintReport: Use factory interface instead of implementation

https://gerrit.wikimedia.org/r/693655

Change 693655 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@REL1_35] SpecialConstraintReport: Use factory interface instead of implementation

https://gerrit.wikimedia.org/r/693655

Reedy assigned this task to Paladox.
Reedy added a project: MW-1.35-release.