Remove fallback to global state in WikiImporter
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Zabe
	May 24 2021, 7:05 PM

Description

Services should be injected into WikiImporter. There is a fallback provided in the constructor. All usages should start injecting the services into WikiImporter or start using the WikiImporterFactory service. The fallback to global state provided in the WikiImporter constructor should be hard-deprecated and eventually removed.

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Don't allow null values for services in WikiImporter	mediawiki/core	master	+18 -18
Remove fallback to global state in WikiImporter	mediawiki/core	master	+9 -23
Using WikiImporterFactory service	mediawiki/extensions/Wikibase	master	+1 -3

Customize query in gerrit

Event Timeline

Zabe created this task.May 24 2021, 7:05 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 24 2021, 7:05 PM

until dependency injection is introduced

@Zabe: Any idea which specific ticket this depends on? Or should this directly be tagged as Dependency injection ?

In T283530#7109624, @Aklapper wrote:

@Zabe: Any idea which specific ticket this depends on? Or should this directly be tagged as Dependency injection ?

This is a follow-up task to https://gerrit.wikimedia.org/r/c/mediawiki/core/+/691341, where dependency injection is added for the WikiImporter service. The patch isn't merged yet, thus I stalled this task.

In T283530#7109624, @Aklapper wrote:

Or should this directly be tagged as Dependency injection ?

Intuitively no, as this task isn't about the dependency injection itself, but rather about the removal of the fallback to global state. Maybe my task describtion doesn't make that clear.

Zabe changed the task status from Stalled to Open.May 26 2021, 4:58 PM

Change 695422 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/Wikibase@master] Using WikiImporterFactory service

https://gerrit.wikimedia.org/r/695422

gerritbot added a project: Patch-For-Review.May 26 2021, 5:15 PM

Change 695422 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Using WikiImporterFactory service

https://gerrit.wikimedia.org/r/695422

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.14; 2021-07-12).Jul 12 2021, 12:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 12 2021, 12:11 PM

Change 704111 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Remove fallback to global state in WikiImporter