Page MenuHomePhabricator
Create Task
Maniphest T283561

Fix trigger sql issues
Closed, ResolvedPublic
Actions

Description

I'm finding it hard to generate the updates to our triggers now - 2 changes mean the sql is kinda hard to compare

  1. - I assume this is at the civi end - the sql seems to be out of order
  2. - after we installed rpow it started adding the db before the table. Perhaps this is OK & if I just accept it & commit it then my diffs will be clean again but you wouldn't normally commit the db name

This has stung me time-wise a few times lately & will be a thing again with the next minor update so might be worth sorting out

Details

SubjectRepoBranchLines +/-
Remove trailing white spacewikimedia/fundraising/crmmaster+4 -4
Update triggers with shorter versionwikimedia/fundraising/crmmaster+7 -5 K
Commit meaninful trigger changeswikimedia/fundraising/crmmaster+54 -6
Fix sorting for drop triggerswikimedia/fundraising/crm/civicrmmaster+1 -1
Commit some more of the 'noise' trigger changeswikimedia/fundraising/crmmaster+47 -47
Fix trigger alpha sorting to key sortwikimedia/fundraising/crm/civicrmmaster+2 -2
Update triggers sqlwikimedia/fundraising/crmmaster+247 -103
Update trigger sqlwikimedia/fundraising/crmmaster+4 K -3 K
Sort trigger data before processingwikimedia/fundraising/crm/civicrmmaster+7 -0
Fix Schema calculation of usePrefix to cope with rpow:wikimedia/fundraising/crm/civicrmmaster+36 -13
Customize query in gerrit

Event Timeline

Eileenmcnaughton created this task.May 25 2021, 6:10 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 25 2021, 6:10 AM
• DStrine moved this task from Triage to Current Sprint on the Fundraising-Backlog board.May 25 2021, 8:19 PM
• DStrine added a project: Fundraising Sprint Ketchup Flume Ride.May 25 2021, 8:34 PM
• DStrine triaged this task as Medium priority.May 26 2021, 3:21 PM
Eileenmcnaughton claimed this task.Jun 1 2021, 4:05 AM
Eileenmcnaughton moved this task from Backlog to Doing on the Fundraising Sprint Ketchup Flume Ride board.
gerritbot added a comment.Jun 8 2021, 12:02 AM

Change 698645 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm/civicrm@master] Fix Schema calculation of usePrefix to cope with rpow:

https://gerrit.wikimedia.org/r/698645

gerritbot added a project: Patch-For-Review.Jun 8 2021, 12:02 AM
gerritbot added a comment.Jun 8 2021, 12:42 AM

Change 698648 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm/civicrm@master] Sort trigger data before processing

https://gerrit.wikimedia.org/r/698648

Eileenmcnaughton moved this task from Doing to Review on the Fundraising Sprint Ketchup Flume Ride board.Jun 8 2021, 12:59 AM

I've put up a couple of patches that will give us cleaner trigger output - it would be good, I think, to regenerate the trigger output with them prior to upgrading

• DStrine added a project: fundraising sprint Legø Trampoline.Jun 8 2021, 8:15 PM
Eileenmcnaughton moved this task from Backlog to Review on the fundraising sprint Legø Trampoline board.Jun 9 2021, 10:42 PM
gerritbot added a comment.Jun 10 2021, 4:03 PM

Change 698645 merged by jenkins-bot:

[wikimedia/fundraising/crm/civicrm@master] Fix Schema calculation of usePrefix to cope with rpow:

https://gerrit.wikimedia.org/r/698645

gerritbot added a comment.Jun 10 2021, 4:03 PM

Change 698648 merged by jenkins-bot:

[wikimedia/fundraising/crm/civicrm@master] Sort trigger data before processing

https://gerrit.wikimedia.org/r/698648

Maintenance_bot removed a project: Patch-For-Review.Jun 10 2021, 4:10 PM
gerritbot added a comment.Jun 15 2021, 12:46 AM

Change 699822 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Update trigger sql

https://gerrit.wikimedia.org/r/699822

gerritbot added a project: Patch-For-Review.Jun 15 2021, 12:46 AM
gerritbot added a comment.Jun 15 2021, 1:29 AM

Change 699822 abandoned by Eileen:

[wikimedia/fundraising/crm@master] Update trigger sql

Reason:

https://gerrit.wikimedia.org/r/699822

Maintenance_bot removed a project: Patch-For-Review.Jun 15 2021, 2:10 AM
Eileenmcnaughton moved this task from Review to Doing on the fundraising sprint Legø Trampoline board.Jun 16 2021, 1:10 AM
gerritbot added a comment.Jun 16 2021, 11:02 PM

Change 700112 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Update triggers sql

https://gerrit.wikimedia.org/r/700112

gerritbot added a project: Patch-For-Review.Jun 16 2021, 11:02 PM
gerritbot added a comment.Jun 17 2021, 12:10 AM

Change 700112 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Update triggers sql

https://gerrit.wikimedia.org/r/700112

gerritbot added a comment.Jun 17 2021, 2:17 AM

Change 700114 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm/civicrm@master] Fix trigger alpha sorting to key sort

https://gerrit.wikimedia.org/r/700114

Eileenmcnaughton moved this task from Doing to Review on the fundraising sprint Legø Trampoline board.Jun 17 2021, 2:18 AM

I need this merged

https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/civicrm/+/700114

and then I'll pull it back & do another comparison - I added the asort but should have added ksort

gerritbot added a comment.Jun 17 2021, 1:55 PM

Change 700114 merged by jenkins-bot:

[wikimedia/fundraising/crm/civicrm@master] Fix trigger alpha sorting to key sort

https://gerrit.wikimedia.org/r/700114

Eileenmcnaughton moved this task from Review to Doing on the fundraising sprint Legø Trampoline board.Jun 21 2021, 7:51 PM
gerritbot added a comment.Jun 21 2021, 10:56 PM

Change 700714 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Commit some more of the 'noise' trigger changes

https://gerrit.wikimedia.org/r/700714

gerritbot added a comment.Jun 21 2021, 10:59 PM

Change 700715 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Commit meaninful trigger changes

https://gerrit.wikimedia.org/r/700715

gerritbot added a comment.Jun 22 2021, 3:05 PM

Change 700714 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Commit some more of the 'noise' trigger changes

https://gerrit.wikimedia.org/r/700714

• DStrine added a project: Fundraising Sprint Mandatory corn dogs.Jun 22 2021, 7:43 PM
Eileenmcnaughton moved this task from Backlog to Doing on the Fundraising Sprint Mandatory corn dogs board.Jun 23 2021, 1:18 AM
Eileenmcnaughton moved this task from Doing to Review on the Fundraising Sprint Mandatory corn dogs board.Jun 23 2021, 5:06 AM
gerritbot added a comment.Jun 23 2021, 5:07 AM

Change 701014 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm/civicrm@master] Fix sorting for drop triggers

https://gerrit.wikimedia.org/r/701014

Eileenmcnaughton added a comment.Jun 23 2021, 5:08 AM

Ok - I overdid the sorting last time.... https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/civicrm/+/701014

gerritbot added a comment.Jun 23 2021, 3:18 PM

Change 701014 merged by jenkins-bot:

[wikimedia/fundraising/crm/civicrm@master] Fix sorting for drop triggers

https://gerrit.wikimedia.org/r/701014

gerritbot added a comment.Jun 25 2021, 2:40 AM

Change 700715 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Commit meaninful trigger changes

https://gerrit.wikimedia.org/r/700715

gerritbot added a comment.Jun 28 2021, 10:35 PM

Change 701986 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Update triggers with shorter version

https://gerrit.wikimedia.org/r/701986

gerritbot added a comment.Jun 28 2021, 10:39 PM

Change 701987 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove trailing white space

https://gerrit.wikimedia.org/r/701987

gerritbot added a comment.Jun 29 2021, 12:13 AM

Change 701986 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Update triggers with shorter version

https://gerrit.wikimedia.org/r/701986

gerritbot added a comment.Jun 29 2021, 12:24 AM

Change 701987 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove trailing white space

https://gerrit.wikimedia.org/r/701987

Eileenmcnaughton moved this task from Review to Done on the Fundraising Sprint Mandatory corn dogs board.Jun 29 2021, 12:41 AM
• DStrine closed this task as Resolved.Jul 20 2021, 7:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL