Impose the tidyverse style for R code wherever possible
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	GoranSMilovanovic
	May 25 2021, 10:21 AM

Description

The Wikidata Analytics core codebase is now already mature, but
it was under constant development since March 2017 with no formal coding style imposed.

Because of the nature of data engineering/wrangling operations on Big Data, the tidyverse R code style probably cannot be imposed everywhere in the codebase, but it seems reasonable to apply it wherever it is possible.

This ticket will also encompass some (more cosmetic) changes in respect to the {golem} approach to Shiny dashboards production/{shinyproxy} deployment.

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T283568 [Epic] Wikidata Analytics Core Codebase Maintenance
		Resolved		GoranSMilovanovic	T283570 Impose the tidyverse style for R code wherever possible

Event Timeline

GoranSMilovanovic created this task.May 25 2021, 10:21 AM

GoranSMilovanovic moved this task from Technical Wishlist to Wikidata Analytics on the User-GoranSMilovanovic board.May 25 2021, 10:34 AM

Manuel unsubscribed.Jun 17 2021, 10:13 AM

Change 713691 had a related patch set uploaded (by GoranSMilovanovic; author: GoranSMilovanovic):

[analytics/wmde/WD/WikidataAnalytics@master] T283570

https://gerrit.wikimedia.org/r/713691

Change 713691 merged by GoranSMilovanovic:

[analytics/wmde/WD/WikidataAnalytics@master] T283570

https://gerrit.wikimedia.org/r/713691

Production: Wikidata Languages Landscape:
namespaces implemented across the codebase.

Change 713694 had a related patch set uploaded (by GoranSMilovanovic; author: GoranSMilovanovic):

[analytics/wmde/WD/WikidataAnalytics@master] T283570

https://gerrit.wikimedia.org/r/713694

Change 713694 merged by GoranSMilovanovic:

[analytics/wmde/WD/WikidataAnalytics@master] T283570

https://gerrit.wikimedia.org/r/713694

tidyverse style almost perfectly applied across the Wikidata Languages Landscape code.
locally overridden convention: numbered filenames (for sequentially run scripts) - not applied; we have the orchestration script which determines the sequence of scripts to run.

Maintenance_bot removed a project: Patch-For-Review.Aug 18 2021, 8:10 PM

GoranSMilovanovic mentioned this in rAWWA5dd046788a31: T283570.Aug 18 2021, 10:41 PM

GoranSMilovanovic mentioned this in rAWWA4c9b59cc0967: T283570.

Change 713715 had a related patch set uploaded (by GoranSMilovanovic; author: GoranSMilovanovic):

[analytics/wmde/WD/WikidataAnalytics@master] T283570

https://gerrit.wikimedia.org/r/713715

Change 713715 merged by GoranSMilovanovic:

[analytics/wmde/WD/WikidataAnalytics@master] T283570

https://gerrit.wikimedia.org/r/713715

GoranSMilovanovic mentioned this in rAWWAd4216af21c1e: T283570.Aug 18 2021, 11:22 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 19 2021, 12:10 AM

Change 713809 had a related patch set uploaded (by GoranSMilovanovic; author: GoranSMilovanovic):