Page MenuHomePhabricator
Create Task
Maniphest T283642

Eliminate DatabaseBlock::forcedUserId
Closed, ResolvedPublic
Actions

Description

forcedUserId in DatabaseBlock was added as a workaround for inability to represent cross-wiki users in the code. Now that UserIdentity is cross-wiki capable, we can remove this workaround.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Remove DatabaseBlock::forcedUserId featurePpchelkomediawiki/coremaster+1 -22
Provide UserIdentity as cross-wiki block targetPpchelkomediawiki/extensions/CentralAuthmaster+1 -2
Provide user identities to blocks in testsPpchelkomediawiki/extensions/EventBusmaster+23 -18
Customize query in gerrit

Event Timeline

• Pchelolo created this task.May 25 2021, 10:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 25 2021, 10:17 PM
gerritbot added a comment.May 25 2021, 10:19 PM

Change 694733 had a related patch set uploaded (by Ppchelko; author: Ppchelko):

[mediawiki/extensions/CentralAuth@master] Provide UserIdentity as cross-wiki block target

https://gerrit.wikimedia.org/r/694733

gerritbot added a project: Patch-For-Review.May 25 2021, 10:19 PM
gerritbot added a comment.May 25 2021, 10:37 PM

Change 694742 had a related patch set uploaded (by Ppchelko; author: Ppchelko):

[mediawiki/core@master] Provide UserIdentities to blocks in tests

https://gerrit.wikimedia.org/r/694742

gerritbot added a comment.May 25 2021, 10:41 PM

Change 694748 had a related patch set uploaded (by Ppchelko; author: Ppchelko):

[mediawiki/extensions/EventBus@master] Provide user identities to blocks in tests

https://gerrit.wikimedia.org/r/694748

gerritbot added a comment.Jun 2 2021, 9:29 AM

Change 694748 merged by jenkins-bot:

[mediawiki/extensions/EventBus@master] Provide user identities to blocks in tests

https://gerrit.wikimedia.org/r/694748

gerritbot added a comment.Jun 2 2021, 9:29 AM

Change 694733 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Provide UserIdentity as cross-wiki block target

https://gerrit.wikimedia.org/r/694733

gerritbot added a comment.Jun 2 2021, 9:31 AM

Change 694742 merged by jenkins-bot:

[mediawiki/core@master] Remove DatabaseBlock::forcedUserId feature

https://gerrit.wikimedia.org/r/694742

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.9; 2021-06-07).Jun 2 2021, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 2 2021, 10:10 AM
• Pchelolo moved this task from Unsorted pile to On the train on the Platform Team Workboards (MW Expedition) board.Jun 3 2021, 6:51 PM
• Pchelolo closed this task as Resolved.Jun 14 2021, 7:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits