Replace Content::getNativeData() calls with TextContent::getText() in JsonConfig
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Aklapper
	May 26 2021, 10:35 AM

Description

See parent task.

JsonConfig/includes/JCCache.php:				$result = $result->getNativeData();
JsonConfig/includes/JCCache.php:				$value = $value->getNativeData();
JsonConfig/includes/JCContentHandler.php:			return $content->getNativeData(); // Invalid JSON - can't do anything with it
JsonConfig/includes/JCContent.php:		$rawText = $this->getNativeData();
JsonConfig/includes/JCContent.php:		$text = trim( $this->getNativeData() );
JsonConfig/includes/JCContent.php:		if ( $this->getNativeData() !== $formatted ) {

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Drop use of getNativeData()	mediawiki/extensions/JsonConfig	master	+6 -5
	Replace getNativeData to getText for JsonConfig	mediawiki/extensions/JsonConfig	master	+8 -5

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Stalled		None	T155582 Deprecate Content::getNativeData(), defined TextContent::getText() to replace it.
		Resolved		cscott	T283677 Replace Content::getNativeData() calls with TextContent::getText() in JsonConfig

Event Timeline

Aklapper created this task.May 26 2021, 10:35 AM

RussRogovetz claimed this task.Mar 15 2022, 9:47 AM

Change 770919 had a related patch set uploaded (by Russ Rogovetz; author: Russ Rogovetz):

[mediawiki/extensions/JsonConfig@master] Replace getNativeData to getText for JsonConfig

https://gerrit.wikimedia.org/r/770919

gerritbot added a project: Patch-For-Review.Mar 15 2022, 2:16 PM

RussRogovetz added subscribers: martincodes-de, Jdforrester-WMF.May 17 2022, 10:40 AM

Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Jul 2 2024, 6:56 PM

@RussRogovetz: Removing task assignee as this open task has been assigned for more than two years - See the email sent to task assignee on October 11th.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

Change #770919 abandoned by Jdlrobson:

[mediawiki/extensions/JsonConfig@master] Replace getNativeData to getText for JsonConfig

https://gerrit.wikimedia.org/r/770919

Change #1251449 had a related patch set uploaded (by Lewis Cawte; author: Lewis Cawte):

[mediawiki/extensions/JsonConfig@master] Drop use of getNativeData()

https://gerrit.wikimedia.org/r/1251449

gerritbot added a project: Patch-For-Review.Fri, Mar 13, 7:43 PM

Restricted Application removed a project: Patch-Needs-Improvement. · View Herald TranscriptFri, Mar 13, 7:43 PM

Change #1251449 merged by jenkins-bot:

[mediawiki/extensions/JsonConfig@master] Drop use of getNativeData()

https://gerrit.wikimedia.org/r/1251449

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.20; 2026-03-17).Fri, Mar 13, 11:01 PM

cscott closed this task as Resolved.Fri, Mar 13, 11:04 PM

cscott claimed this task.

Replace Content::getNativeData() calls with TextContent::getText() in JsonConfigClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Replace Content::getNativeData() calls with TextContent::getText() in JsonConfig
Closed, ResolvedPublic
Actions

Related Objects
Search...