Replace Content::getNativeData() calls with TextContent::getText() in PageForms
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Aklapper
	May 26 2021, 10:45 AM

Description

See parent task.

PageForms/includes/PF_AutoeditAPI.php:		return $wikiPage->getContent( Revision::RAW )->getNativeData();
PageForms/includes/PF_Utils.php:			return $content->getNativeData();
PageForms/specials/PF_MultiPageEdit.php:		$formContent = $formWikiPage->getContent( Revision::RAW )->getNativeData();

Details

	Subject	Repo	Branch	Lines +/-
	Remove unconditional usages of Revision::RAW and Content::getNativeData	mediawiki/extensions/PageForms	REL1_37	+23 -28
	Remove unconditional usages of Revision::RAW and Content::getNativeData	mediawiki/extensions/PageForms	master	+23 -28

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Stalled		None	T155582 Deprecate Content::getNativeData(), defined TextContent::getText() to replace it.
		Resolved		Yaron_Koren	T283696 Replace Content::getNativeData() calls with TextContent::getText() in PageForms

Event Timeline

Aklapper created this task.May 26 2021, 10:45 AM

Yaron_Koren mentioned this in T292637: PageForms is not compatible with MediaWiki 1.37: Class 'Revision' not found.Oct 7 2021, 1:46 AM

Change 727018 had a related patch set uploaded (by Nikerabbit; author: Nikerabbit):

[mediawiki/extensions/PageForms@master] Remove unconditional usages of Revision::RAW and Content::getNativeData

https://gerrit.wikimedia.org/r/727018

gerritbot added a project: Patch-For-Review.Oct 7 2021, 6:24 AM

Change 727018 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] Remove unconditional usages of Revision::RAW and Content::getNativeData

https://gerrit.wikimedia.org/r/727018

Maintenance_bot removed a project: Patch-For-Review.Oct 7 2021, 3:11 PM

I believe this is fixed now.

Change 740875 had a related patch set uploaded (by Reedy; author: Nikerabbit):

[mediawiki/extensions/PageForms@REL1_37] Remove unconditional usages of Revision::RAW and Content::getNativeData

https://gerrit.wikimedia.org/r/740875

gerritbot added a project: Patch-For-Review.Nov 24 2021, 3:06 AM

Change 740875 merged by jenkins-bot: