- Need to create SessionProviderTestTrait with SessionProviderTestTrait::initProvider method in order to facilitate the initializing of an SessionProvider in tests. The new method must be like a constructor which in the end calls SessionProvider::init with passed parameters to initProvider. Some logic can be taken from AuthenticationProviderTestTrait::initProvider.
- Find all uses of SessionProvider::init in tests of the core and CentralAuth extension and replace it with new SessionProviderTestTrait::initProvider method.
Description
Description
Details
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Create SessionProviderTestTrait to facilitate testing of an SessionProvider | mediawiki/core | master | +118 -203 |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Vlad.shapik | T283709 Create SessionProviderTestTrait to facilitate testing of an SessionProvider | |||
Resolved | Vlad.shapik | T283736 extensions / CentralAuth - use SessionProviderTestTrait::initProvider instead of SessionProvider::init in tests |
Event Timeline
Comment Actions
Change 695370 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):
[mediawiki/core@master] Create SessionProviderTestTrait to facilitate testing of an SessionProvider
Comment Actions
Change 695370 merged by jenkins-bot:
[mediawiki/core@master] Create SessionProviderTestTrait to facilitate testing of an SessionProvider