What is the problem?
If a user is blocked specifically from sending thanks, there is some undesirable UI behaviour on Structured Discussions pages.
- After clicking "Thank", the error popup is not very informative. It says: Thank action failed (error code: blocked). Please try again.
- After refreshing the page, "Thank" becomes "Thanked", even though the thank was not successfully sent
- I think this is just stored in cookie/browser storage. After I cleared cookies and cache it became "Thank" again.
I raised T283720 to remove the "Thank" link entirely when the user is blocked. However, this issue might still exist if the user has other errors while trying to send thanks.
Observed while testing T242785#7106962.
Steps to reproduce problem
- Login as an admin user
- Go to Special:Block/$user (for a $user you can login as)
- Uncheck "Editing" and check "Sending thanks"
- Select an expiration time and submit the form
- Login as $user
- Go to any Structured Discussion page
- (You might need to go to Special:Preferences#mw-prefsection-betafeatures and enable it on your own user_talk page)
- Underneath replies from other users, click the "Thank" link
Expected behavior: An informative error message, in this case including information about the block effecting the user, such as was done in T270803
Observed behavior: Thank action failed (error code: blocked). Please try again.
- Refresh the page
Expected behavior: The link still states "Thank"
Observed behavior: The link states "Thanked"
Environment
Wiki(s): https://en.wikipedia.beta.wmflabs.org Thanks 1.2.0 (ca5b333) 07:55, 24 May 2021