Under the "advanced options" section, at the third option ("Use non-JavaScript interface"), the small text under reads: "Loads RecentChanges without filters search or highlighting functionality.". This should be corrected to "Loads RecentChanges without filters, search or highlighting functionality.".
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| RCFilters: Make preference help string more broadly applicable | mediawiki/core | master | +1 -1 |
Event Timeline
Comment Actions
I believe that this label might be intentionally talking about the "filters search" functionality. Tagging with the relevant project; this isn't an issue with the preferences system.
Comment Actions
@MMiller_WMF @Trizek-WMF we added this message a while back. Does the proposed change look OK to you?
Comment Actions
Hmm, if it is so, then perhaps correcting it to "filter search" would be appropriate?
Comment Actions
Yeah, you can search for a given filter. I let native English speakers decide on the right way to explain it. :)
While we are here, if we are correcting this sentence, we should cover the fact that is is also covering Special:Watchlist and Special:RecentChangesLinked. And probably other pages in the future. Maybe we should have something more neutral and capable of dealing with the diversity of the usages?
Comment Actions
OK, so how about:
Loads RecentChanges, Watchlist, and similar pages without the filtered search or the highlighting functionality.
?
Comment Actions
Change 697716 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):
[mediawiki/core@master] RCFilters: Make preference help string more broadly applicable
Comment Actions
Change 697716 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Make preference help string more broadly applicable
Comment Actions
Um, actually, if it's fine, I'd suggest a clarification to this:
Loads RecentChanges, Watchlist, and similar pages without the filtered search or highlighting functionality.
I think this makes it clearer and more concise.
Comment Actions
I intentionally re-injected the definite article to clarify that the highlighting functionality is distinguishable from the search functionality, especially for non-English translations, but perhaps?