Page MenuHomePhabricator

'Talk' link should always be in user menu , even when new user messages bar is shown
Closed, ResolvedPublic2 Estimated Story Points

Description

Description

Currently, as a carryover from the behavior in Legacy Vector, when you have a new message on your Talk page the Talk link is removed from the menu and shown as an alert (yellow box) in the site header.

image.png (532×624 px, 41 KB)
image.png (586×1 px, 80 KB)

Goal

The Talk link should remain in the user menu regardless of whether or not the alert is present.

QA Results - Beta

ACStatusDetails
1T283811#7147841

Event Timeline

ovasileva triaged this task as Medium priority.May 27 2021, 2:11 PM

Change 695648 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/extensions/Echo@master] POC: Add talk notification instead of transforming the talk link

https://gerrit.wikimedia.org/r/695648

I think the next question to figure out is whether we want this to only affect modern Vector or whether we want this in other skins as well (e.g legacy Vector, etc). We could, for example, get rid of the transformation logic in other skins and always have the talk link show e.g. in legacy Vector it could look like:

talk.png (362×2 px, 170 KB)

The logic in Echo to do this would be easy (see above patch), but we would have to be careful to not break anything that depends on #pt-mytalk [1] and expects that to be a notification. That's the tricky part.

[1] https://codesearch.wmcloud.org/search/?q=pt-mytalk&i=nope&files=&excludeFiles=&repos=

@alexhollender we took a stab at estimating this, and came out large due to an open question.

This will result in two talk page links in the menu, with different labels. Currently Nick proposes to do this for all skins. Here is how it would look for legacy Vector:

Screen Shot 2021-06-02 at 10.40.19 AM.png (158×894 px, 38 KB)

Screen Shot 2021-06-02 at 10.42.41 AM.png (100×1 px, 38 KB)

Screen Shot 2021-06-02 at 10.42.53 AM.png (134×888 px, 21 KB)

@alexhollender does this make sense or do we only want to do this for modern Vector?

Screen Shot 2021-06-02 at 10.42.16 AM.png (380×880 px, 40 KB)

apologies for the delay. I think your proposal, @nray, sounds good — showing both the notification and the Talk link seems reasonable to me.

I've created T284173 — at some point in the future whoever works on Echo next can hopefully help cleanup this situation.

@alexhollender just to make it explicit, it sounds like you are okay with changing the default for all skins to show this link twice?

@alexhollender just to make it explicit, it sounds like you are okay with changing the default for all skins to show this link twice?

yes, I feel relatively confident that such a change won't rock the boat too much for legacy vector, monobook, and modern users. Though it might make sense to wait for @ovasileva to return before we finalize this?

Jdlrobson renamed this task from 'Talk' link should always be in user menu to 'Talk' link should always be in user menu , even when new user messages bar is shown.Jun 3 2021, 5:28 PM

@alexhollender just to make it explicit, it sounds like you are okay with changing the default for all skins to show this link twice?

yes, I feel relatively confident that such a change won't rock the boat too much for legacy vector, monobook, and modern users. Though it might make sense to wait for @ovasileva to return before we finalize this?

This seems fine to me and can't envision any objections from the communities. @MMiller_WMF, @RHo - let us know if you have any concerns with this new treatment.

@alexhollender just to make it explicit, it sounds like you are okay with changing the default for all skins to show this link twice?

yes, I feel relatively confident that such a change won't rock the boat too much for legacy vector, monobook, and modern users. Though it might make sense to wait for @ovasileva to return before we finalize this?

This seems fine to me and can't envision any objections from the communities. @MMiller_WMF, @RHo - let us know if you have any concerns with this new treatment.

Thanks @ovasileva - no concerns from me. New users wouldn't come across legacy skins too often anyway, and it seems prudent to have this become an extra extra 'notification' link rather than the transformation of a global menu item for everyone.

Change 695648 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Add talk notification instead of transforming the talk link

https://gerrit.wikimedia.org/r/695648

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: The Talk link should remain in the user menu regardless of whether or not the alert is present.

Screen Shot 2021-06-10 at 12.42.43 AM.png (788×1 px, 193 KB)

Edtadros added a subscriber: Edtadros.

@ovasileva, moving this per our conversation to be tested after it's deployed.