DataCloneError: Failed to execute 'pushState' on 'History': HTMLLIElement object could not be cloned / DataCloneError: The object could not be cloned in changeUrl
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Traffic is low (6 errors in last 7 days) but raising in case it breaks an important workflow.

https://logstash.wikimedia.org/app/dashboards#/doc/logstash-*/logstash-2021.05.22?id=ttANlXkBStjVNP_PKf3W

message

DataCloneError: Failed to execute 'pushState' on 'History': HTMLLIElement object could not be cloned.

trace

at Object.changeUrl  URL1:98:850
at Object.changeFilter  URL1:98:423
at HTMLButtonElement.<anonymous>  URL1:83:358
at HTMLButtonElement.dispatch  URL1:176:214
at HTMLButtonElement.elemData.handle  URL1:172:848

URL1: https://meta.wikimedia.org/w/load.php?lang=en&modules=ext.translate.base%2Cdropdownmenu%2Ceditor%2Cgroupselector%2Cloader%2Cmessagetable%2Cparsers%2Crecentgroups%2Cstatsbar%7Cext.translate.special.translate%7Cjquery%7Cjquery.makeCollapsible.styles%7Cjquery.ui&skin=vector&version=1o4qi

Using mediawiki.router might help here.

Impact

No user visible impact other than error on the developer console.

Details

Request URL: https://meta.wikimedia.org/w/index.php?title=Special:Translate&group=page-Wikivoyage%2FWhy&action=page&filter=%21translated&language=tl

	Subject	Repo	Branch	Lines +/-
	Fix rare JavaScript DataCloneError on Special:Translate	mediawiki/extensions/Translate	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: Blog Post: Production Excellence #32: May 2021

Event Timeline

Jdlrobson created this task.May 27 2021, 2:58 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 27 2021, 2:58 PM

Nikerabbit triaged this task as Low priority.May 27 2021, 6:01 PM

Nikerabbit moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.

thcipriani moved this task from Untriaged to May 2021 on the Wikimedia-production-error board.Jun 9 2021, 6:50 PM

Location: https://meta.wikimedia.org/w/index.php?title=Special:Translate&group=page-Wikivoyage%2FWhy&action=page&filter=%21translated&language=tl.
Browser: Chrome 90.

ext.translate.special.translate.js

	changeFilter: function ( filter ) {
		if ( !checkDirty() ) {
			return;
		}
		mw.translate.changeUrl( { filter: filter, showMessage: null } );
		state.messageList.changeSettings( { filter: getActualFilter( filter ) } );
	},

	changeUrl: function ( params, forceChange ) {
		var uri = new mw.Uri( window.location.href );
		uri.extend( params );
		Object.keys( params ).forEach( function ( key ) {
			if ( params[ key ] === null ) {
				delete uri.query[ key ];
			}
		} );

		if ( uri.toString() === window.location.href ) {
			return;
		}

		if ( !forceChange && history.pushState && $( '.tux-messagelist' ).length ) {
			history.pushState( uri, null, uri.toString() );

I don't think using a different way to changing the URL will avoid this error. It seems the problem is that a DOM element is making its way into the serialization here, which is not something browsers generally support. As for how, I don't know. The above code shows null being passed, so I'm not sure what is leading it to serialize a DOM element here.

Krinkle updated the task description. (Show Details)Jun 12 2021, 4:48 PM

Krinkle changed the subtype of this task from "Task" to "Production Error".

Krinkle set Request URL to https://meta.wikimedia.org/w/index.php?title=Special:Translate&group=page-Wikivoyage%2FWhy&action=page&filter=%21translated&language=tl.

Krinkle mentioned this in Blog Post: Production Excellence #32: May 2021.Jun 21 2021, 1:31 AM

Change 719099 had a related patch set uploaded (by Nikerabbit; author: Nikerabbit):

[mediawiki/extensions/Translate@master] Fix rare JavaScript DataCloneError on Special:Translate

https://gerrit.wikimedia.org/r/719099

gerritbot added a project: Patch-For-Review.Sep 6 2021, 11:49 AM

Adding to the sprint for review. Turns out the fix is trivial.

Nikerabbit moved this task from Quarter Backlog to In Review on the Language-Team (Language-2021-July-September) board.Sep 6 2021, 11:52 AM

abi_ moved this task from In Review to Recheck after deployment on the Language-Team (Language-2021-July-September) board.Sep 7 2021, 10:58 AM

Change 719099 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Fix rare JavaScript DataCloneError on Special:Translate

https://gerrit.wikimedia.org/r/719099

Maintenance_bot removed a project: Patch-For-Review.Sep 7 2021, 12:10 PM

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 7 2021, 3:01 PM

Nikerabbit updated the task description. (Show Details)Sep 13 2021, 8:23 AM

QAd on translatewiki.net. Keeping open for up to week to confirm from Logstash.

Last seen on 2021-09-15. Looks good to me.

DataCloneError: Failed to execute 'pushState' on 'History': HTMLLIElement object could not be cloned / DataCloneError: The object could not be cloned in changeUrlClosed, ResolvedPublicPRODUCTION ERRORActions