Page MenuHomePhabricator
Create Task
Maniphest T283853

VE paste surface read by screenreader
Closed, ResolvedPublic
Actions

Description

When I use Safari/VoiceOver, copy something in DT visual mode and then try to navigate out of the editable surface, the next element in the navigation suequence is another editable, which seems to contain a copy of my last selected VE text. This should probably be hidden from screenreaders using aria-hidden.

<div class="ve-ce-surface-paste noime" tabindex="-1" contenteditable="true"><p>☀<span style="caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0); font-family: -webkit-standard; font-size: medium;">om</span></p></div>

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (3891890c2)mediawiki/extensions/VisualEditormaster+1 -1
Set aria-hidden on pasteTargetVisualEditor/VisualEditormaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

TheDJ created this task.May 27 2021, 6:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 27 2021, 6:34 PM
matmarex subscribed.May 27 2021, 6:58 PM

I'm happy to add that if you think it helps, but how is the focus ending up on that element given that it has tabindex="-1"? Maybe it's some problem with our own focus handling.

TheDJ added a comment.EditedMay 27 2021, 7:20 PM

There is a difference between tabbable (keyboard navigation) and focusable (able to receive focus/interact with it). You can MAKE a non-interactive element tabbable AND focusable by setting tabindex=0, but you cannot make an interactive element unfocusable by setting tabindex=-1, that only removes it from the tab order, but the accessibility cursor is independent of the tab order. The focus 'follows' the tab order (like a dog following its owner), but it is not the same thing.

This might be interpreted slightly more strict here because it is in a form.

TheDJ added a comment.EditedMay 27 2021, 7:26 PM

https://html.spec.whatwg.org/multipage/interaction.html#the-tabindex-attribute

−1 (or other negative integer values)
Causes the element to be focusable, and indicates that the author would prefer the element to be click focusable but not sequentially focusable.

This is also why jQuery UI has :focusable and :tabbable selectors

gerritbot added a comment.Jun 3 2021, 7:37 PM

Change 698021 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Set aria-hidden on pasteTarget

https://gerrit.wikimedia.org/r/698021

gerritbot added a project: Patch-For-Review.Jun 3 2021, 7:37 PM
Esanders moved this task from To Triage to Triaged on the VisualEditor board.Jun 3 2021, 7:53 PM
gerritbot added a comment.Jun 5 2021, 8:57 PM

Change 698021 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Set aria-hidden on pasteTarget

https://gerrit.wikimedia.org/r/698021

Maintenance_bot removed a project: Patch-For-Review.Jun 5 2021, 9:10 PM
matmarex closed this task as Resolved.Jun 7 2021, 6:43 PM
matmarex assigned this task to Esanders.

Hopefully that fixes it, @TheDJ we'd appreciate if you could confirm.

In T283853#7120669, @TheDJ wrote:

There is a difference between tabbable (keyboard navigation) and focusable (able to receive focus/interact with it). You can MAKE a non-interactive element tabbable AND focusable by setting tabindex=0, but you cannot make an interactive element unfocusable by setting tabindex=-1, that only removes it from the tab order, but the accessibility cursor is independent of the tab order. The focus 'follows' the tab order (like a dog following its owner), but it is not the same thing.

This might be interpreted slightly more strict here because it is in a form.

I'm aware of the difference, I'm just surprised that focus can apparently end up in a non-tabbable, non-clickable, invisible element, without us making that happen in our code.

gerritbot added a comment.Jun 7 2021, 8:13 PM

Change 698619 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (3891890c2)

https://gerrit.wikimedia.org/r/698619

gerritbot added a project: Patch-For-Review.Jun 7 2021, 8:13 PM
gerritbot added a comment.Jun 7 2021, 8:51 PM

Change 698619 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (3891890c2)

https://gerrit.wikimedia.org/r/698619

Maintenance_bot removed a project: Patch-For-Review.Jun 7 2021, 9:10 PM
TheDJ added a comment.Jun 9 2021, 9:14 AM

@matmarex I can no longer reproduce the issue on https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Main_Page so looks like it might be fixed.

valhallasw mentioned this in T284587: ReleaseTaggerBot skipping some Tasks/Patches?.Jun 12 2021, 8:03 PM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 12 2021, 8:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL