Page MenuHomePhabricator
Create Task
Maniphest T283862

Wikibase\Lib\Store\RevisionedUnresolvedRedirectException: Unresolved redirect from Q107001580 to Q41215189
Closed, ResolvedPublic3 Estimated Story PointsPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   Wikibase\Lib\Store\RevisionedUnresolvedRedirectException: Unresolved redirect from Q107001580 to Q41215189
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.7/extensions/Wikibase/lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php(118)
#0 /srv/mediawiki/php-1.37.0-wmf.7/extensions/Wikibase/lib/includes/Store/TypeDispatchingEntityRevisionLookup.php(54): Wikibase\Lib\Store\Sql\WikiPageEntityRevisionLookup->getEntityRevision(Wikibase\DataModel\Entity\ItemId, integer, string)
#1 /srv/mediawiki/php-1.37.0-wmf.7/extensions/Wikibase/data-access/src/ByTypeDispatchingEntityRevisionLookup.php(55): Wikibase\Lib\Store\TypeDispatchingEntityRevisionLookup->getEntityRevision(Wikibase\DataModel\Entity\ItemId, integer, string)
#2 /srv/mediawiki/php-1.37.0-wmf.7/extensions/Wikibase/lib/includes/Store/TypeDispatchingEntityRevisionLookup.php(54): Wikibase\DataAccess\ByTypeDispatchingEntityRevisionLookup->getEntityRevision(Wikibase\DataModel\Entity\ItemId, integer, string)
#3 /srv/mediawiki/php-1.37.0-wmf.7/extensions/Wikibase/repo/includes/Api/ModifyEntity.php(199): Wikibase\Lib\Store\TypeDispatchingEntityRevisionLookup->getEntityRevision(Wikibase\DataModel\Entity\ItemId, integer, string)
#4 /srv/mediawiki/php-1.37.0-wmf.7/extensions/Wikibase/repo/includes/Api/SetLabel.php(76): Wikibase\Repo\Api\ModifyEntity->applyChangeOp(Wikibase\Repo\ChangeOp\ChangeOpFingerprint, Wikibase\DataModel\Entity\Item, Wikibase\Lib\Summary)
#5 /srv/mediawiki/php-1.37.0-wmf.7/extensions/Wikibase/repo/includes/Api/ModifyEntity.php(319): Wikibase\Repo\Api\SetLabel->modifyEntity(Wikibase\DataModel\Entity\Item, Wikibase\Repo\ChangeOp\ChangeOpFingerprint, array)
#6 /srv/mediawiki/php-1.37.0-wmf.7/includes/api/ApiMain.php(1669): Wikibase\Repo\Api\ModifyEntity->execute()
#7 /srv/mediawiki/php-1.37.0-wmf.7/includes/api/ApiMain.php(639): ApiMain->executeAction()
#8 /srv/mediawiki/php-1.37.0-wmf.7/includes/api/ApiMain.php(610): ApiMain->executeActionWithErrorHandling()
#9 /srv/mediawiki/php-1.37.0-wmf.7/api.php(90): ApiMain->execute()
#10 /srv/mediawiki/php-1.37.0-wmf.7/api.php(45): wfApiMain()
#11 /srv/mediawiki/w/api.php(3): require(string)
#12 {main}
Impact

logspam

Notes

This error currently occurs in SetLabel.

Data integrity errors should really not be showing up in production error logs for mediawiki. Can we put errors like this in a different logstash channel? If it's not a problem with the code or production service level then I think it shouldn't be in the exception channel.

Acceptance Criteria 🏕️🌟
  • We should give the user some nice error when they try to edit something that is now a redirect via the api
  • We should audit and fix ALL other APIs that use entity IDs to ensure that this issue does not occur anywhere else

Details

Request URL
https://www.wikidata.org/w/api.php
SubjectRepoBranchLines +/-
Return exception when current version of the item is now redirectmediawiki/extensions/Wikibasemaster+58 -5
Customize query in gerrit

Related Objects

Event Timeline

• mmodell created this task.May 27 2021, 7:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 27 2021, 7:23 PM
Maintenance_bot added a project: Wikidata.May 27 2021, 7:45 PM
Restricted Application added a project: [DEPRECATED] wdwb-tech. · View Herald TranscriptMay 27 2021, 7:45 PM
thcipriani added a project: Wikidata-Campsite.Jun 9 2021, 6:50 PM
thcipriani moved this task from Untriaged to May 2021 on the Wikimedia-production-error board.
Krinkle mentioned this in Blog Post: Production Excellence #32: May 2021.Jun 21 2021, 1:31 AM
Addshore subscribed.Jun 28 2021, 3:37 PM

We should give the user some nice error when they try to edit something that is now a redirect

Addshore moved this task from Inbox to To Prioritize on the [DEPRECATED] wdwb-tech board.Jun 28 2021, 3:37 PM
Michael subscribed.Jun 29 2021, 11:40 AM
Addshore moved this task from To Prioritize to Triaged Low (0-50) on the [DEPRECATED] wdwb-tech board.Jun 30 2021, 6:56 AM
Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.Jun 30 2021, 6:58 AM
Addshore edited projects, added Wikidata-Campsite; removed Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).
Addshore moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.Jun 30 2021, 7:01 AM
Addshore updated the task description. (Show Details)Jun 30 2021, 8:22 AM
Addshore triaged this task as Medium priority.Jun 30 2021, 8:42 AM
Addshore set the point value for this task to 3.Jun 30 2021, 10:19 AM
Addshore moved this task from Prioritized Wikidata Tech Backlog (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Jun 30 2021, 10:53 AM
Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Addshore moved this task from Triaged Low (0-50) to Active on the [DEPRECATED] wdwb-tech board.Jun 30 2021, 10:58 AM
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jun 30 2021, 11:16 AM
Ladsgroup claimed this task.Jul 1 2021, 5:47 PM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Ladsgroup subscribed.

This happens basically on every type of edit entity API endpoint not setlabel. It also doesn't happen on redirects per se, it's when you edit on a redirect but with baserevid of pre-becoming-redirect revision. Fun stuff.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJul 1 2021, 5:47 PM
Maintenance_bot moved this task from Incoming to In progress on the User-Ladsgroup board.Jul 1 2021, 6:15 PM
gerritbot added a comment.Jul 1 2021, 7:26 PM

Change 702744 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/Wikibase@master] Return exception when current version of the item is now redirect

https://gerrit.wikimedia.org/r/702744

gerritbot added a project: Patch-For-Review.Jul 1 2021, 7:26 PM
Ladsgroup moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 1 2021, 7:31 PM
gerritbot added a comment.Jul 2 2021, 10:19 AM

Change 702744 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Return exception when current version of the item is now redirect

https://gerrit.wikimedia.org/r/702744

Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 2 2021, 10:20 AM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.14; 2021-07-12).Jul 2 2021, 11:01 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 2 2021, 11:11 AM
Addshore closed this task as Resolved.Jul 15 2021, 9:29 AM
Krinkle mentioned this in T143756: UnresolvedRedirectException in EntityAccessor::getEntity (scribunto).Aug 18 2021, 8:39 PM
Krinkle mentioned this in T112243: Overwriting a redirect using wbeditentity causes an exception.
hashar mentioned this in T291215: Wikibase\Lib\Store\RevisionedUnresolvedRedirectException: Unresolved redirect from Q100917584 to Q95304986.Sep 16 2021, 7:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits