[M] TypeError: searchOptions[this.currentTab] is not an Object. (evaluating 'key in searchOptions[this.currentTab]')
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	egardner
	May 27 2021, 7:30 PM

Description

Error

Link to sample error in Logstash

normalized_message

TypeError: searchOptions[this.currentTab] is not an Object. (evaluating 'key in searchOptions[this.currentTab]')

exception.trace

at https://commons.m.wikimedia.org/w/load.php?lang=en&modules=jquery%7Cwikibase.mediainfo.mediasearch.vue&skin=minerva&version=1s3fi:206:475
at onPopState https://commons.m.wikimedia.org/w/load.php?lang=en&modules=jquery%7Cwikibase.mediainfo.mediasearch.vue&skin=minerva&version=1s3fi:206:450

Impact

Error seems limited to Mobile Safari on iOS.
Roughly 50 occurrences per day, seems more or less constant over the last few weeks.

Notes

This seems to be happening inside the clearFilterQueryParams in App.vue, but the outer layer of the callstack is the onPopState handler. This implies that some previous history state is not being stored correctly when the user navigates "back" to a previous search state.

Details

	Subject	Repo	Branch	Lines +/-
	Check for null "searchOptions" when restoring filter state	mediawiki/extensions/MediaSearch	master	+5 -2

Customize query in gerrit

Related Objects

Mentioned In: rEMED381c68f156e0: Check for null "searchOptions" when restoring filter state

Event Timeline

egardner created this task.May 27 2021, 7:30 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptMay 27 2021, 7:30 PM

egardner removed a project: Wikimedia-production-error.May 27 2021, 8:11 PM

CBogen edited projects, added Structured-Data-Backlog; removed Structured-Data-Backlog (Current Work).Jun 11 2021, 2:14 PM

CBogen edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Jun 14 2021, 4:53 PM

CBogen moved this task from Incoming to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.Jun 14 2021, 5:04 PM

CBogen renamed this task from TypeError: searchOptions[this.currentTab] is not an Object. (evaluating 'key in searchOptions[this.currentTab]') to [M] TypeError: searchOptions[this.currentTab] is not an Object. (evaluating 'key in searchOptions[this.currentTab]').Jul 14 2021, 4:22 PM

CBogen moved this task from Ready for Estimation to Ready for Development on the Structured-Data-Backlog (Current Work) board.Jul 14 2021, 4:25 PM

egardner claimed this task.Jul 14 2021, 5:27 PM

egardner moved this task from Ready for Development to Doing on the Structured-Data-Backlog (Current Work) board.Aug 18 2021, 10:18 PM

Change 713917 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/extensions/MediaSearch@master] Check for null \"searchOptions\" when restoring filter state

https://gerrit.wikimedia.org/r/713917

gerritbot added a project: Patch-For-Review.Aug 19 2021, 6:34 PM

egardner moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.Aug 19 2021, 6:34 PM

Change 713917 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] Check for null \"searchOptions\" when restoring filter state

https://gerrit.wikimedia.org/r/713917

egardner mentioned this in rEMED381c68f156e0: Check for null "searchOptions" when restoring filter state.Aug 31 2021, 9:13 AM

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Aug 31 2021, 10:00 AM

Maintenance_bot removed a project: Patch-For-Review.Aug 31 2021, 10:10 AM

egardner moved this task from Code Review to Verify on Production on the Structured-Data-Backlog (Current Work) board.Sep 7 2021, 4:13 PM

@egardner - on commons wmf.23 there are similar looking errors (59 errors for the last 24 hours), Is it a related or a separate bug?