Page MenuHomePhabricator

Misaligned title in process dialog, indicators on buttons due to invalid Less calculation.
Closed, ResolvedPublic

Description

  1. https://doc.wikimedia.org/oojs-ui/master/demos/?page=dialogs&theme=wikimediaui&direction=ltr&platform=desktop
  2. Open "Process dialog (medium)".

capture-bug-ooui-process-medium.png (1×2 px, 135 KB)

There's a misaligned title in process dialog. I suspect this is a very recently regression as I'd have noticed it in production otherwise (possibly not yet released?).

Misaligned down indicator on buttons

image.png (191×529 px, 30 KB)

Event Timeline

Aklapper renamed this task from Misaligned title in proces dialog to Misaligned title in process dialog.May 30 2021, 12:45 PM
Aklapper updated the task description. (Show Details)

Change 709087 had a related patch set uploaded (by Lens0021; author: Lens0021):

[oojs/ui@master] Use parentheses to wrap division-like expressions

https://gerrit.wikimedia.org/r/709087

Volker_E renamed this task from Misaligned title in process dialog to Misaligned title in process dialog, indicators on buttons due to invalid Less calculation..Aug 18 2021, 7:49 AM
Volker_E triaged this task as Medium priority.
Volker_E updated the task description. (Show Details)

Luckily (I'm not serious here T288498) we're on 'grunt-contrib-less' v3.0.0 in OOUI https://github.com/gruntjs/grunt-contrib-less/blob/main/package.json while in MW we're lacking behind.

Change 709087 merged by jenkins-bot:

[oojs/ui@master] themes: Use parentheses to wrap division-like expressions

https://gerrit.wikimedia.org/r/709087

Volker_E moved this task from Backlog to OOUI-0.42.0 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.42.0); removed OOUI.

Change 713803 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update OOUI to v0.42.0

https://gerrit.wikimedia.org/r/713803

Change 713803 merged by jenkins-bot:

[mediawiki/core@master] Update OOUI to v0.42.0

https://gerrit.wikimedia.org/r/713803