Replace ILBFactory and ILoadBalancer with injecting new Db-Service in Repo's ChangePruner class and pruneChanges maint script
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Michael
	May 28 2021, 1:21 PM

Description

This uses only the base-functionality with the local database.

			$this->lbFactory->waitForReplication( [
				'domain' => $this->lbFactory->getLocalDomainID(),
			] );

$dbr = $this->lbFactory->getMainLB()->getConnection( DB_REPLICA );

$dbw = $this->lbFactory->getMainLB()->getConnection( DB_PRIMARY );

NOTE: The pruneChanges.php maintenance script is planned to be refactored into a job in T48643: [Story] Dispatching via job queue (instead of cron script). This task here should probably done before or after that refactoring in order to avoid merge conflicts.

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Migrate pruning changes to use RepoDomainDb	mediawiki/extensions/Wikibase	master	+21 -21

Status	Assigned	Task
Resolved	Addshore	T281453 Abstract database connections between Client and Repository
Resolved	Addshore	T283246 Use DomainDB abstraction in all places in Wikibase where DB connections are created or ILBFactory / ILoadBalancer are otherwise used
Resolved	Ladsgroup	T283932 Replace ILBFactory and ILoadBalancer with injecting new Db-Service in Repo's ChangePruner class and pruneChanges maint script

Change 698905 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/Wikibase@master] Migrate pruning changes to use RepoDomainDb

Change 698905 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Migrate pruning changes to use RepoDomainDb

Ladsgroup closed this task as Resolved.Jun 11 2021, 9:28 AM