Page MenuHomePhabricator

Replace ILBFactory with injecting new Db-Service in Repo's RebuildItemsPerSite maintenance script and associated class ItemsPerSiteBuilder
Closed, ResolvedPublic

Description

This seems like a fairly straightforward refactoring as the only usage of ILBFactory seems to be

		// Wait for the replicas, just in case we e.g. hit a range of ids which need a lot of writes.
		$this->lbFactory->waitForReplication( [
			'domain' => $this->lbFactory->getLocalDomainID(),
		] );

Event Timeline

Change 698809 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] Typehint files to be modified

https://gerrit.wikimedia.org/r/698809

Change 698810 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] Replace ILBFactory with RepoDomainDb

https://gerrit.wikimedia.org/r/698810

Change 698809 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Typehint files to be modified

https://gerrit.wikimedia.org/r/698809

Change 698810 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Replace ILBFactory with RepoDomainDb

https://gerrit.wikimedia.org/r/698810

Nothing left to removed here by the looks of it, everything is merged. Moving to verification.