Page MenuHomePhabricator
Create Task
Maniphest T283945

Remove RemoveDeletedItemsFromTermStore maintenance script
Closed, ResolvedPublic
Actions

Description

This script was created as part of T270247 and is now no longer used after it served its main purpose. While there might be the off-chance that it could theoretically be useful again in the future, it is not worth the effort or refactoring it to replace ILBFactory with DomainDb.

Therefore, this script should just be deleted.

Related Objects
Search...

Event Timeline

Michael created this task.May 28 2021, 3:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 28 2021, 3:36 PM
Michael mentioned this in T283946: Replace ILBFactory with the new Db-Service in Repo's CleanTermsIfUnusedJob and related classes.May 28 2021, 3:44 PM
Michael edited parent tasks, added: T283946: Replace ILBFactory with the new Db-Service in Repo's CleanTermsIfUnusedJob and related classes; removed: T283246: Use DomainDB abstraction in all places in Wikibase where DB connections are created or ILBFactory / ILoadBalancer are otherwise used.
Michael added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Jun 11 2021, 7:45 PM
Lucas_Werkmeister_WMDE claimed this task.Jun 14 2021, 9:10 AM
Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Lucas_Werkmeister_WMDE added a comment.Jun 14 2021, 9:13 AM

This makes EntityExistenceChecker::existsBatch() unused, but I think we should keep that method for now, since the implementations aren’t overly complicated and it might be useful again later.

gerritbot added a comment.Jun 14 2021, 9:14 AM

Change 699708 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove RemoveDeletedItemsFromTermStore maintenance script

https://gerrit.wikimedia.org/r/699708

gerritbot added a project: Patch-For-Review.Jun 14 2021, 9:14 AM
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 14 2021, 9:14 AM
gerritbot added a comment.Jun 14 2021, 10:11 AM

Change 699708 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove RemoveDeletedItemsFromTermStore maintenance script

https://gerrit.wikimedia.org/r/699708

Lucas_Werkmeister_WMDE closed this task as Resolved.Jun 14 2021, 10:24 AM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 14 2021, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 14 2021, 11:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits