Align the numerals on the language switching button to local scripts
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	sgrabarczuk
	May 29 2021, 2:24 AM

Description

https://bn.wikipedia.org/wiki/বাংলা_সংখ্যা_পদ্ধতি?languageinheader=1&uselang=bn
gives this:

Bengali numeral for 3 should be displayed before the translated word for "languages".

See T283955#7142655, which was informed by a suggestion on how to fix this.

QA Results - Prod

AC	Status	Details
1	✅	T283955#7177214

Details

	Subject	Repo	Branch	Lines +/-
	Skin: Convert number of languages to interface language	mediawiki/skins/Vector	master	+5 -4

Customize query in gerrit

Related Objects

Mentioned Here: T285118: beta: Error: Unsupported operand types
T285119: beta: Error: invalid magic word 'ns'

Event Timeline

sgrabarczuk created this task.May 29 2021, 2:24 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 29 2021, 2:24 AM

sgrabarczuk added a project: Web-Team-Backlog (Kanbanana-FY-2020-21).May 29 2021, 2:30 AM

sgrabarczuk updated the task description. (Show Details)

sgrabarczuk added a subscriber: Aftabuzzaman.

Needs priority before it's put on sprint board.

Jdlrobson assigned this task to ovasileva.Jun 1 2021, 5:36 PM

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.

ovasileva triaged this task as High priority.Jun 7 2021, 3:56 PM

ovasileva edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog.

Jdlrobson removed ovasileva as the assignee of this task.Jun 7 2021, 5:03 PM

Jdlrobson added a subscriber: ovasileva.

LGoto assigned this task to phuedx.Jun 7 2021, 5:27 PM

The Message object doesn't guess at how parameters should be handled but needs to be told. Message::numParams() tags the passed parameter as a number so that it can be formatted when needed. AIUI we have to change

Vector/includes/SkinVector.php

$languageButtonData = [
    // ...

    'label' => $this->msg(
        'vector-language-button-label',
        count( $this->getLanguagesCached() )
    )->escaped(),

    // ...
];

Vector/includes/SkinVector.php

$label = $this->msg( 'vector-language-button-label' )
    ->numParams( count( $this->getLanguagesCached() ) )
    ->escaped();

$languageButtonData = [
    // ...

    'label' => $label,

    // ...
];

phuedx updated the task description. (Show Details)Jun 8 2021, 3:23 PM

phuedx removed phuedx as the assignee of this task.Jun 8 2021, 3:59 PM

phuedx moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

phuedx subscribed.

Change 698817 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/skins/Vector@master] WIP: skin: Convert number of languages to interface language

https://gerrit.wikimedia.org/r/698817

gerritbot added a project: Patch-For-Review.Jun 8 2021, 4:19 PM

LGoto set the point value for this task to 2.Jun 8 2021, 5:30 PM

LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Change 698817 abandoned by Phuedx:

[mediawiki/skins/Vector@master] WIP: skin: Convert number of languages to interface language

Reason:

https://gerrit.wikimedia.org/r/698817

Maintenance_bot removed a project: Patch-For-Review.Jun 10 2021, 6:11 PM

Change 698817 restored by Bernard Wang:

[mediawiki/skins/Vector@master] WIP: skin: Convert number of languages to interface language

https://gerrit.wikimedia.org/r/698817

gerritbot added a project: Patch-For-Review.Jun 18 2021, 5:07 PM

bwang moved this task from Ready for Development to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jun 18 2021, 5:21 PM

Jdlrobson assigned this task to Edtadros.Jun 21 2021, 2:04 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Change 698817 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Skin: Convert number of languages to interface language

https://gerrit.wikimedia.org/r/698817

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 21 2021, 3:00 PM

@Jdlrobson Here's what I get without uselang=bn

With uselang=bn

Screen Shot 2021-06-21 at 9.13.59 PM.png (264×1 px, 52 KB)

I suspect something in beta is broken because I don't expect it to say "language". I tried some other beta wikis and I get an error. Here's what happens when I try goto https://he.wikipedia.beta.wmflabs.org/

Screen Shot 2021-06-21 at 9.28.50 PM.png (989×1 px, 415 KB)

I only show that so you can see the URL becomes:

https://he.wikipedia.beta.wmflabs.org/wiki/<mainpage>

Here's the full text of the error:

MediaWiki internal error.

Original exception: [YNFm1deIExsM261ykzSzkwAAABU] /wiki/%E2%A7%BCmainpage%E2%A7%BD MWException: Error: invalid magic word 'ns'
Backtrace:
from /srv/mediawiki/php-master/includes/MagicWord.php(129)
#0 /srv/mediawiki/php-master/includes/MagicWordFactory.php(230): MagicWord->load(string)
#1 /srv/mediawiki/php-master/includes/parser/Parser.php(4939): MagicWordFactory->get(string)
#2 /srv/mediawiki/php-master/includes/parser/CoreParserFunctions.php(64): Parser->setFunctionHook(string, array, integer)
#3 /srv/mediawiki/php-master/includes/parser/Parser.php(477): CoreParserFunctions::register(Parser)
#4 /srv/mediawiki/php-master/includes/parser/ParserFactory.php(181): Parser->__construct(MediaWiki\Config\ServiceOptions, MagicWordFactory, Language, ParserFactory, string, MediaWiki\SpecialPage\SpecialPageFactory, MediaWiki\Linker\LinkRendererFactory, NamespaceInfo, Monolog\Logger, MediaWiki\BadFileLookup, MediaWiki\Languages\LanguageConverterFactory, MediaWiki\HookContainer\HookContainer, MediaWiki\Tidy\RemexDriver, WANObjectCache, MediaWiki\User\UserOptionsManager, MediaWiki\User\UserFactory, MediaWikiTitleCodec)
#5 /srv/mediawiki/php-master/includes/ServiceWiring.php(1010): ParserFactory->create()
#6 /srv/mediawiki/php-master/vendor/wikimedia/services/src/ServiceContainer.php(447): Wikimedia\Services\ServiceContainer::{closure}(MediaWiki\MediaWikiServices)
#7 /srv/mediawiki/php-master/vendor/wikimedia/services/src/ServiceContainer.php(416): Wikimedia\Services\ServiceContainer->createService(string)
#8 /srv/mediawiki/php-master/includes/MediaWikiServices.php(269): Wikimedia\Services\ServiceContainer->getService(string)
#9 /srv/mediawiki/php-master/includes/MediaWikiServices.php(1205): MediaWiki\MediaWikiServices->getService(string)
#10 /srv/mediawiki/php-master/includes/OutputPage.php(2125): MediaWiki\MediaWikiServices->getParser()
#11 /srv/mediawiki/php-master/includes/OutputPage.php(1876): OutputPage->parseInternal(string, Title, boolean, boolean)
#12 /srv/mediawiki/php-master/includes/OutputPage.php(1807): OutputPage->addWikiTextTitleInternal(string, Title, boolean, boolean)
#13 /srv/mediawiki/php-master/includes/page/Article.php(1496): OutputPage->addWikiTextAsInterface(string)
#14 /srv/mediawiki/php-master/includes/page/Article.php(638): Article->showMissingArticle()
#15 /srv/mediawiki/php-master/includes/page/Article.php(561): Article->generateContentOutput(User, ParserOptions, integer, OutputPage, array)
#16 /srv/mediawiki/php-master/includes/actions/ViewAction.php(74): Article->view()
#17 /srv/mediawiki/php-master/includes/MediaWiki.php(536): ViewAction->show()
#18 /srv/mediawiki/php-master/includes/MediaWiki.php(320): MediaWiki->performAction(Article, Title)
#19 /srv/mediawiki/php-master/includes/MediaWiki.php(917): MediaWiki->performRequest()
#20 /srv/mediawiki/php-master/includes/MediaWiki.php(551): MediaWiki->main()
#21 /srv/mediawiki/php-master/index.php(53): MediaWiki->run()
#22 /srv/mediawiki/php-master/index.php(46): wfIndexMain()
#23 /srv/mediawiki/w/index.php(3): require(string)
#24 {main}

Exception caught inside exception handler: [YNFm1deIExsM261ykzSzkwAAABU] /wiki/%E2%A7%BCmainpage%E2%A7%BD MWException: Error: invalid magic word 'ns'
Backtrace:
from /srv/mediawiki/php-master/includes/MagicWord.php(129)
#0 /srv/mediawiki/php-master/includes/MagicWordFactory.php(230): MagicWord->load(string)
#1 /srv/mediawiki/php-master/includes/parser/Parser.php(4939): MagicWordFactory->get(string)
#2 /srv/mediawiki/php-master/includes/parser/CoreParserFunctions.php(64): Parser->setFunctionHook(string, array, integer)
#3 /srv/mediawiki/php-master/includes/parser/Parser.php(477): CoreParserFunctions::register(Parser)
#4 /srv/mediawiki/php-master/includes/parser/ParserFactory.php(181): Parser->__construct(MediaWiki\Config\ServiceOptions, MagicWordFactory, Language, ParserFactory, string, MediaWiki\SpecialPage\SpecialPageFactory, MediaWiki\Linker\LinkRendererFactory, NamespaceInfo, Monolog\Logger, MediaWiki\BadFileLookup, MediaWiki\Languages\LanguageConverterFactory, MediaWiki\HookContainer\HookContainer, MediaWiki\Tidy\RemexDriver, WANObjectCache, MediaWiki\User\UserOptionsManager, MediaWiki\User\UserFactory, MediaWikiTitleCodec)
#5 /srv/mediawiki/php-master/extensions/FeaturedFeeds/includes/FeaturedFeedChannel.php(50): ParserFactory->create()
#6 /srv/mediawiki/php-master/extensions/FeaturedFeeds/includes/FeaturedFeeds.php(210): MediaWiki\Extension\FeaturedFeeds\FeaturedFeedChannel->__construct(string, array, string)
#7 /srv/mediawiki/php-master/extensions/FeaturedFeeds/includes/FeaturedFeeds.php(115): MediaWiki\Extension\FeaturedFeeds\FeaturedFeeds::getFeedsQuick(string)
#8 /srv/mediawiki/php-master/includes/HookContainer/HookContainer.php(338): MediaWiki\Extension\FeaturedFeeds\FeaturedFeeds::beforePageDisplay(OutputPage, SkinVector)
#9 /srv/mediawiki/php-master/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#10 /srv/mediawiki/php-master/includes/HookContainer/HookRunner.php(960): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#11 /srv/mediawiki/php-master/includes/OutputPage.php(2641): MediaWiki\HookContainer\HookRunner->onBeforePageDisplay(OutputPage, SkinVector)
#12 /srv/mediawiki/php-master/includes/exception/MWException.php(193): OutputPage->output()
#13 /srv/mediawiki/php-master/includes/exception/MWException.php(231): MWException->reportHTML()
#14 /srv/mediawiki/php-master/includes/exception/MWExceptionHandler.php(104): MWException->report()
#15 /srv/mediawiki/php-master/includes/exception/MWExceptionHandler.php(185): MWExceptionHandler::report(MWException)
#16 /srv/mediawiki/php-master/includes/MediaWiki.php(570): MWExceptionHandler::handleException(MWException, string)
#17 /srv/mediawiki/php-master/index.php(53): MediaWiki->run()
#18 /srv/mediawiki/php-master/index.php(46): wfIndexMain()
#19 /srv/mediawiki/w/index.php(3): require(string)
#20 {main}

This is blocked on others:
T285119 T285118

Given the blockers, let's skip QA in beta cluster, and QA this in production later today.

Jdlrobson reassigned this task from Jdlrobson to Edtadros.Jun 24 2021, 5:10 PM

Test Result - Prod

Status: ✅ PASS
Environment: bnwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Visit https://bn.wikipedia.org/wiki/%E0%A6%AC%E0%A6%BE%E0%A6%82%E0%A6%B2%E0%A6%BE_%E0%A6%B8%E0%A6%82%E0%A6%96%E0%A7%8D%E0%A6%AF%E0%A6%BE_%E0%A6%AA%E0%A6%A6%E0%A7%8D%E0%A6%A7%E0%A6%A4%E0%A6%BF?languageinheader=1&uselang=bn

✅ AC1: Bengali numeral for 3 should be displayed before the translated word for "languages".

E000F85F-AD2C-426F-BC75-D3E8C8E60D9C.jpeg (1×1 px, 985 KB)

BF63AF0A-82AF-4AA8-9EEE-18D35E812AAD.jpeg (1×1 px, 251 KB)

Edtadros updated the task description. (Show Details)Jun 25 2021, 1:10 PM

Aftabuzzaman awarded a token.Jun 25 2021, 1:35 PM

All done!

	F34527126: BF63AF0A-82AF-4AA8-9EEE-18D35E812AAD.jpeg
	Jun 25 2021, 1:05 PM

	F34527127: E000F85F-AD2C-426F-BC75-D3E8C8E60D9C.jpeg
	Jun 25 2021, 1:05 PM

	F34519890: Screen Shot 2021-06-21 at 9.28.50 PM.png
	Jun 22 2021, 4:32 AM

	F34519882: Screen Shot 2021-06-21 at 9.13.59 PM.png
	Jun 22 2021, 4:32 AM

	F34519884: Screen Shot 2021-06-21 at 9.22.24 PM.png
	Jun 22 2021, 4:32 AM

Align the numerals on the language switching button to local scriptsClosed, ResolvedPublic2 Estimated Story PointsActions

Description

QA Results - Prod

Details

Related Objects

Event Timeline

Test Result - Prod

QA Steps

Align the numerals on the language switching button to local scripts
Closed, ResolvedPublic2 Estimated Story Points
Actions