Page MenuHomePhabricator

Remove wfReadOnly, wfReadOnlyReason after release of MediaWiki 1.39
Closed, ResolvedPublic

Description

With ReadOnlyMode there is now a service doing that job, which makes this global function pretty much useless.

Codesearch: https://codesearch.wmcloud.org/deployed/?q=wf(Configured)%3FReadOnly(Reason)%3F%5Cs*%5C(%5Cs*%5C)&i=nope&files=&excludeFiles=&repos=

Details

SubjectRepoBranchLines +/-
mediawiki/coremaster+2 -73
mediawiki/coremaster+36 -3
mediawiki/coremaster+9 -2
mediawiki/coremaster+3 -1
mediawiki/coremaster+22 -18
mediawiki/coremaster+4 -9
mediawiki/extensions/Echomaster+29 -13
mediawiki/extensions/CentralNoticemaster+3 -1
mediawiki/extensions/FlaggedRevsmaster+10 -6
mediawiki/extensions/PageFormsmaster+7 -9
mediawiki/extensions/MultiLanguageManagermaster+3 -3
mediawiki/extensions/UserStatusmaster+6 -1
mediawiki/extensions/RegexBlockmaster+3 -2
mediawiki/extensions/BlueSpicePermissionManagermaster+2 -2
mediawiki/extensions/BlueSpiceFoundationmaster+6 -4
mediawiki/extensions/EditAccountmaster+2 -6
mediawiki/extensions/BlueSpiceDashboardsmaster+1 -18
mediawiki/extensions/WikiForummaster+10 -5
mediawiki/extensions/Favoritesmaster+1 -1
mediawiki/extensions/MassEditRegexmaster+3 -1
mediawiki/extensions/GlobalUserrightsmaster+2 -2
mediawiki/extensions/Formmaster+3 -2
mediawiki/extensions/DynamicPageListmaster+1 -1
mediawiki/extensions/Commentsmaster+25 -3
mediawiki/extensions/CreateAPagemaster+1 -1
mediawiki/extensions/ConfirmAccountmaster+2 -2
mediawiki/extensions/CategoryWatchmaster+2 -2
mediawiki/extensions/ArticleFeedbackv5master+5 -3
mediawiki/extensions/AdvancedMetamaster+2 -3
mediawiki/extensions/GrowthExperimentsmaster+10 -2
mediawiki/extensions/GraphVizmaster+1 -1
mediawiki/extensions/Mathmaster+1 -1
mediawiki/extensions/UserProtectmaster+5 -3
mediawiki/extensions/CheckUsermaster+3 -2
mediawiki/extensions/Newslettermaster+3 -2
mediawiki/extensions/VoteNYmaster+1 -1
mediawiki/extensions/VisualEditormaster+15 -7
mediawiki/extensions/WhosOnlinemaster+4 -1
mediawiki/extensions/OAuthmaster+8 -5
mediawiki/extensions/HAWelcomemaster+10 -1
mediawiki/extensions/Translatemaster+1 -1
mediawiki/extensions/EntitySchemamaster+6 -4
mediawiki/extensions/MobileFrontendmaster+5 -1
mediawiki/extensions/CentralAuthmaster+35 -8
mediawiki/extensions/Wikibasemaster+3 -2
mediawiki/coremaster+6 -0
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 749912 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Replace usage of deprecated global function wfReadOnly()

https://gerrit.wikimedia.org/r/749912

Change 749895 merged by jenkins-bot:

[mediawiki/extensions/WhosOnline@master] Replace usage of deprecated global function wfReadOnly()

https://gerrit.wikimedia.org/r/749895

Change 749858 merged by jenkins-bot:

[mediawiki/extensions/Newsletter@master] Replace usage of deprecated global function wfReadOnly()

https://gerrit.wikimedia.org/r/749858

Change 749896 merged by jenkins-bot:

[mediawiki/extensions/VoteNY@master] Replace usage of deprecated global function wfReadOnly()

https://gerrit.wikimedia.org/r/749896

Change 749893 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Replace usage of deprecated global function wfReadOnly()

https://gerrit.wikimedia.org/r/749893

Change 749894 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Replace usage of deprecated global function wfReadOnly()

https://gerrit.wikimedia.org/r/749894

Change 749897 merged by jenkins-bot:

[mediawiki/extensions/UserProtect@master] Replace usage of deprecated global function wfReadOnly()

https://gerrit.wikimedia.org/r/749897

Change 759582 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GraphViz@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759582

Change 759582 merged by jenkins-bot:

[mediawiki/extensions/GraphViz@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759582

Change 759584 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GrowthExperiments@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759584

Change 759587 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AdvancedMeta@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759587

Change 759589 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ArticleFeedbackv5@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759589

Change 759593 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CategoryWatch@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759593

Change 759584 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759584

Change 759594 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Comments@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759594

Change 759595 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ConfirmAccount@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759595

Change 759596 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CreateAPage@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759596

Change 759597 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/DynamicPageList@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759597

Change 759598 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/EditAccount@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759598

Change 759599 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Echo@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759599

Change 759600 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Favorites@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759600

Change 759601 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Form@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759601

Change 759602 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GlobalUserrights@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759602

Change 759603 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MassEditRegex@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759603

Change 759606 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/UserStatus@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759606

Change 759587 merged by jenkins-bot:

[mediawiki/extensions/AdvancedMeta@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759587

Change 759607 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/RegexBlock@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759607

Change 759589 merged by jenkins-bot:

[mediawiki/extensions/ArticleFeedbackv5@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759589

Change 759593 merged by jenkins-bot:

[mediawiki/extensions/CategoryWatch@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759593

Change 759595 merged by jenkins-bot:

[mediawiki/extensions/ConfirmAccount@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759595

Change 759596 merged by jenkins-bot:

[mediawiki/extensions/CreateAPage@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759596

Change 759594 merged by jenkins-bot:

[mediawiki/extensions/Comments@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759594

Change 759608 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/BlueSpiceDashboards@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759608

Change 759597 merged by jenkins-bot:

[mediawiki/extensions/DynamicPageList@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759597

Change 759609 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/BlueSpiceFoundation@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759609

Change 759610 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/BlueSpicePermissionManager@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759610

Change 759601 merged by jenkins-bot:

[mediawiki/extensions/Form@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759601

Change 759611 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/FlaggedRevs@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759611

Change 759602 merged by jenkins-bot:

[mediawiki/extensions/GlobalUserrights@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759602

Change 759603 merged by jenkins-bot:

[mediawiki/extensions/MassEditRegex@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759603

Change 759612 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MultiLanguageManager@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759612

Change 759613 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikiForum@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759613

Change 759615 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PageForms@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759615

Change 759618 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CentralNotice@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759618

Should the read of $wgReadOnly / $wgReadOnlyFile in extensions deprecated as well?
Writing to both globals in LocalSettings.php should be the only use case. Reading through the service. Not sure if a deprecation warning is possible or only grep for it and replace all usage.

https://codesearch.wmcloud.org/deployed/?q=wgReadOnly&i=nope&files=&excludeFiles=&repos=

Change 759600 merged by jenkins-bot:

[mediawiki/extensions/Favorites@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759600

Change 759613 merged by jenkins-bot:

[mediawiki/extensions/WikiForum@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759613

Change 759608 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceDashboards@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759608

Change 759598 merged by jenkins-bot:

[mediawiki/extensions/EditAccount@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759598

Change 759609 merged by Pwirth:

[mediawiki/extensions/BlueSpiceFoundation@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759609

Change 759610 merged by Pwirth:

[mediawiki/extensions/BlueSpicePermissionManager@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759610

Change 759607 merged by Umherirrender:

[mediawiki/extensions/RegexBlock@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759607

Change 759606 merged by jenkins-bot:

[mediawiki/extensions/UserStatus@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759606

Change 759612 merged by jenkins-bot:

[mediawiki/extensions/MultiLanguageManager@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759612

Change 759615 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759615

Change 759611 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759611

Change 759618 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759618

Change 759599 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Replace deprecated wfReadOnly()

https://gerrit.wikimedia.org/r/759599

Change 806918 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Replace deprecated wfReadOnly/wfReadOnlyReason

https://gerrit.wikimedia.org/r/806918

Change 806923 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] specialpage: Replace deprecated wfReadOnly

https://gerrit.wikimedia.org/r/806923

Change 806926 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] MediaWiki.php: Replace deprecated wfReadOnly

https://gerrit.wikimedia.org/r/806926

Change 806918 merged by jenkins-bot:

[mediawiki/core@master] Replace deprecated wfReadOnly/wfReadOnlyReason

https://gerrit.wikimedia.org/r/806918

Change 806926 merged by jenkins-bot:

[mediawiki/core@master] MediaWiki.php: Replace deprecated wfReadOnly

https://gerrit.wikimedia.org/r/806926

Change 806923 merged by jenkins-bot:

[mediawiki/core@master] specialpage: Replace deprecated wfReadOnly

https://gerrit.wikimedia.org/r/806923

Umherirrender triaged this task as Low priority.

Change 809244 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Hard deprecate wfReadOnly/wfReadOnlyReason

https://gerrit.wikimedia.org/r/809244

Change 809244 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecate wfReadOnly/wfReadOnlyReason

https://gerrit.wikimedia.org/r/809244

Umherirrender renamed this task from Deprecate and remove wfReadOnly, wfReadOnlyReason, and wfConfiguredReadOnlyReason to Remove wfReadOnly, wfReadOnlyReason after release of MediaWiki 1.39.Jun 30 2022, 5:21 PM
Umherirrender changed the task status from Open to Stalled.
Umherirrender removed Umherirrender as the assignee of this task.
Umherirrender removed a project: Patch-For-Review.

Change 732431 abandoned by Zabe:

[mediawiki/core@master] Inject ReadOnlyMode into SpecialPage

Reason:

https://gerrit.wikimedia.org/r/732431

Change 834613 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Remove hard-deprecated wfReadOnly/wfReadOnlyReason

https://gerrit.wikimedia.org/r/834613

Umherirrender changed the task status from Stalled to Open.Sep 23 2022, 8:28 PM
Umherirrender claimed this task.

Change 834613 merged by jenkins-bot:

[mediawiki/core@master] Remove hard-deprecated wfReadOnly/wfReadOnlyReason

https://gerrit.wikimedia.org/r/834613