Maniphest T283993

Use DBTableOptions on Cargo table creation
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Anysite
	May 30 2021, 7:38 PM

Tags

Referenced Files

None

Subscribers

Description

For now, Cargo's code of tables creation not using DBTableOptions. This block site's manger to decide which charset to create cargo tables in.
By using $wgDBTableOptions we let him the ability to choose.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	create: Use CargoDBTableOptions on table creation.	mediawiki/extensions/Cargo	master	+16 -5
	create: Use DBTableOptions on Cargo table creation.	mediawiki/extensions/Cargo	master	+13 -5
	Use DBTableOptions on Cargo table creation.	mediawiki/extensions/Cargo	master	+4 -1
	create: Use DBTableOptions on Cargo table creation	mediawiki/extensions/Cargo	master	+13 -5

Customize query in gerrit

Event Timeline

Anysite created this task.May 30 2021, 7:38 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 30 2021, 7:38 PM

Here's suggestion for fix:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cargo/+/697182

Change 697182 had a related patch set uploaded (by Aklapper; author: Anysite):

[mediawiki/extensions/Cargo@master] Use DBTableOptions on Cargo table creation.

https://gerrit.wikimedia.org/r/697182

gerritbot added a project: Patch-For-Review.May 31 2021, 11:24 AM

Change #1032040 had a related patch set uploaded (by Anysite; author: Anysite):

[mediawiki/extensions/Cargo@master] create: Use DBTableOptions on Cargo table creation

https://gerrit.wikimedia.org/r/1032040

Change #1032040 abandoned by Anysite:

[mediawiki/extensions/Cargo@master] create: Use DBTableOptions on Cargo table creation

Reason:

https://gerrit.wikimedia.org/r/1032040

Change #1032045 had a related patch set uploaded (by Anysite; author: Anysite):

[mediawiki/extensions/Cargo@master] create: Use DBTableOptions on Cargo table creation.

https://gerrit.wikimedia.org/r/1032045

Change #697182 abandoned by Yaron Koren:

[mediawiki/extensions/Cargo@master] Use DBTableOptions on Cargo table creation.

Reason:

Replaced by 1032045

https://gerrit.wikimedia.org/r/697182

Change #1179271 had a related patch set uploaded (by Anysite; author: Anysite):

[mediawiki/extensions/Cargo@master] create: Use CargoDBTableOptions on table creation.

https://gerrit.wikimedia.org/r/1179271

Change #1179271 merged by jenkins-bot:

[mediawiki/extensions/Cargo@master] create: Use CargoDBTableOptions on table creation.

https://gerrit.wikimedia.org/r/1179271

@Anysite - thank you for this addition!