Page MenuHomePhabricator

Add a link in bnwiki: numbers in summary are Arabic numerals instead of Bengali numerals
Closed, ResolvedPublic

Description

In bnwiki, after doing any ''add a link'' suggested edit, the numbers being shown in the summary section (e.g. Accepted: 3, Rejected: ...) are Arabic numerals, instead of Bengali ones.

0, 1, 2, 3, 4, 5, 6, 7, 8, 9 should be ০, ১, ২, ৩, ৪, ৫, ৬, ৭, ৮, ৯ (Ref: Bengali numerals article)

bnwiki_add_a_link_arabic_numeral.jpg (390×1 px, 26 KB)

The translatewiki message with this sentence can be found here: https://translatewiki.net/wiki/MediaWiki:Growthexperiments-addlink-summary-summary/bn

Something similar happened before, so I think this can be relevant: https://phabricator.wikimedia.org/T274379.

Event Timeline

Restricted Application added subscribers: alaa, Aklapper. · View Herald Transcript

(not Epic; please also review the subscribers list)

Change 697585 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] AddLinkSaveDialogMixin.js: Use mw.language.convertNumber to convert numbers

https://gerrit.wikimedia.org/r/697585

IIRC, it is not the first time. So I'm wondering if there is a process to automatically have the right numbers for a given language?

kostajh moved this task from Backlog to Done / QA on the Add-Link board.

IIRC, it is not the first time. So I'm wondering if there is a process to automatically have the right numbers for a given language?

It's just something we need to catch in code review; when a number is referenced in a message on the client-side, we should be passing it through mw.language.convertNumber().

(not Epic; please also review the subscribers list)

@Aklapper I think this is an unfortunate side effect of clicking "Create subtask" from a parent task with an epic tag. Is there a way to configure Phabricator to prevent propagation of certain tags (e.g. the Epic tag) or subscribers from being applied to subtasks created this way?

Change 697585 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] AddLinkSaveDialogMixin.js: Use mw.language.convertNumber to convert numbers

https://gerrit.wikimedia.org/r/697585

Etonkovidova added a subscriber: Etonkovidova.

Checked on bnwiki wmf.9 - the "Review your changes" summary displays numbers in the correct format:

Screen Shot 2021-06-10 at 2.43.33 PM.png (1×1 px, 442 KB)