Page MenuHomePhabricator

Allow setting "preferred" in Special:EditLexicon
Closed, ResolvedPublicFeature

Description

When there are homographs in the lexicon, sometimes a more unusual pronunciation is chosen above a more common one. This can be fixed by adding preferred: true to the entry that should be prioritised. There should be a way to do this in Special:EditLexicon.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Sebastian_Berlin-WMSE changed the subtype of this task from "Task" to "Feature Request".Jun 2 2021, 10:27 AM

I did a quick hack and added a checkbox field for preferred and passed its value to updateEntryItem(), which was enough to get it working.

We'll have to figure out how to represent this to the user in a good way, since there now are two actions: setting transcription and setting preferred, possibly at the same time. This probably means that we don't want transcription to be required, as you may just be interested in changing preferred. In that case the user should be be able to choose not to change the transcription. That could be done by leaving the transcription field empty, though this should have some help text to explain the behaviour.

Change 793011 had a related patch set uploaded (by Sebastian Berlin (WMSE); author: Sebastian Berlin (WMSE)):

[mediawiki/extensions/Wikispeech@master] Add option to edit preferred to Special:EditLexicon

https://gerrit.wikimedia.org/r/793011

Sebastian_Berlin-WMSE changed the task status from Open to In Progress.May 18 2022, 1:13 PM
Sebastian_Berlin-WMSE claimed this task.

Change 798733 had a related patch set uploaded (by Sebastian Berlin (WMSE); author: Sebastian Berlin (WMSE)):

[mediawiki/extensions/Wikispeech@master] Add option to edit preferred to Special:EditLexicon

https://gerrit.wikimedia.org/r/798733

Change 798733 abandoned by Sebastian Berlin (WMSE):

[mediawiki/extensions/Wikispeech@master] Add option to edit preferred to Special:EditLexicon

Reason:

Wrong change id.

https://gerrit.wikimedia.org/r/798733

It appears that Speechoid removes preferred from any other entry with the same language and word when preferred is set to true (which makes sense). This means the same needs to be done for local lexicons to not make them out of sync.

It may be an idea to update the local storage with the entry from Speechoid storage after it has been updated. This should catch any side affects to other entry items.

Sebastian_Berlin-WMSE renamed this task from Allow setting `preferred` in Special:EditLexicon to Allow setting "preferred" in Special:EditLexicon.Sep 9 2022, 9:04 AM

Change 793011 merged by Sebastian Berlin (WMSE):

[mediawiki/extensions/Wikispeech@master] Add option to edit preferred to Special:EditLexicon

https://gerrit.wikimedia.org/r/793011

Change 964528 had a related patch set uploaded (by Sebastian Berlin (WMSE); author: Sebastian Berlin (WMSE)):

[mediawiki/extensions/Wikispeech@REL1_39] Add option to edit preferred to Special:EditLexicon

https://gerrit.wikimedia.org/r/964528

Change 964528 abandoned by Sebastian Berlin (WMSE):

[mediawiki/extensions/Wikispeech@REL1_39] Add option to edit preferred to Special:EditLexicon

Reason:

Just testing what pushing cherry picks looks like.

https://gerrit.wikimedia.org/r/964528

Change 964528 restored by Sebastian Berlin (WMSE):

[mediawiki/extensions/Wikispeech@REL1_39] Add option to edit preferred to Special:EditLexicon

https://gerrit.wikimedia.org/r/964528

Change 964528 merged by jenkins-bot:

[mediawiki/extensions/Wikispeech@REL1_39] Add option to edit preferred to Special:EditLexicon

https://gerrit.wikimedia.org/r/964528