Page MenuHomePhabricator
Create Task
Maniphest T284078

Add a link: change the edit summary
Closed, ResolvedPublic
Actions

Assigned To
• mewoph
Authored By
Trizek-WMF
Jun 1 2021, 3:25 PM
Tags
Referenced Files
F34535872: Screen Shot 2021-07-02 at 7.49.30 AM.png
Jul 2 2021, 2:49 PM
F34535844: Screen Shot 2021-07-02 at 7.27.36 AM.png
Jul 2 2021, 2:47 PM
F34535835: Screen Shot 2021-07-02 at 7.40.10 AM.png
Jul 2 2021, 2:47 PM
F34535840: Screen Shot 2021-07-02 at 7.35.52 AM.png
Jul 2 2021, 2:47 PM
F34523981: Screen Shot 2021-06-23 at 11.02.34 AM.png
Jun 23 2021, 6:16 PM
Subscribers
Aklapper
Ankan_WMF
Dyolf77_WMF
Etonkovidova
• mewoph
MMiller_WMF
PPham
View All 10 Subscribers

Description

We have observed some feedback from various communities about the lack of understanding of what newcomers are doing. Experienced users thought that the edit summary was written by the user, and they warned them against doing it. This may happen when we will scale.

The new structure would be Link suggestions feature: 4 links added.

If only one link is added, it should say link singular.

This would include:

Details

SubjectRepoBranchLines +/-
Add a link: Pass additional parameters to growthexperiments-addlink-summary-summarymediawiki/extensions/GrowthExperimentsmaster+3 -1
Add a link: change the edit summarymediawiki/extensions/GrowthExperimentsmaster+5 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

Trizek-WMF created this task.Jun 1 2021, 3:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 1 2021, 3:25 PM
Trizek-WMF updated the task description. (Show Details)Jun 1 2021, 3:26 PM
MMiller_WMF added a project: Add-Link.Jun 1 2021, 3:36 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 1 2021, 3:36 PM
MMiller_WMF added a parent task: T276517: [EPIC] Growth: "add a link" structured task 3.0.Jun 1 2021, 3:37 PM
Tgr moved this task from Inbox to Needs Discussion on the Growth-Team board.Jun 1 2021, 8:51 PM
MMiller_WMF added subscribers: Ankan_WMF, PPham, Tgr.Jun 7 2021, 11:47 PM

@Trizek-WMF @Dyolf77_WMF @Urbanecm_WMF @Ankan_WMF @PPham -- I've gotten some additional feedback that we should shorten the edit summary and remove the counts for rejected and skipped. It would be like: "4 links added via link suggestions feature". What do you think? Or is it important to have the rejected and skipped counts?

Also, @Tgr -- if we were to remove the rejected and skipped counts from the edit summary, we would still have them in Special:Log, right? For analysis purposes?

Urbanecm_WMF added a comment.Jun 8 2021, 10:55 AM
In T284078#7140739, @MMiller_WMF wrote:

@Trizek-WMF @Dyolf77_WMF @Urbanecm_WMF @Ankan_WMF @PPham -- I've gotten some additional feedback that we should shorten the edit summary and remove the counts for rejected and skipped. It would be like: "4 links added via link suggestions feature". What do you think? Or is it important to have the rejected and skipped counts?

The summary you suggested looks good to me -- thanks.

Also, @Tgr -- if we were to remove the rejected and skipped counts from the edit summary, we would still have them in Special:Log, right? For analysis purposes?

Trizek-WMF added a comment.Jun 8 2021, 12:41 PM

Shortening makes sense. It is better to try out than to guess: we will see if we have feedback from communities with this new wording.

Dyolf77_WMF added a comment.Jun 8 2021, 2:47 PM
In T284078#7140739, @MMiller_WMF wrote:

@Trizek-WMF @Dyolf77_WMF @Urbanecm_WMF @Ankan_WMF @PPham -- I've gotten some additional feedback that we should shorten the edit summary and remove the counts for rejected and skipped. It would be like: "4 links added via link suggestions feature". What do you think? Or is it important to have the rejected and skipped counts?

It's Ok for me to shorten the summary.

Ankan_WMF added a comment.Jun 9 2021, 8:14 AM
In T284078#7140739, @MMiller_WMF wrote:

@Trizek-WMF @Dyolf77_WMF @Urbanecm_WMF @Ankan_WMF @PPham -- I've gotten some additional feedback that we should shorten the edit summary and remove the counts for rejected and skipped. It would be like: "4 links added via link suggestions feature". What do you think? Or is it important to have the rejected and skipped counts?

It's okay to remove the counts for rejected and skipped. In the current format, the rejected (or skipped) edits are not checked, so I think it doesn't matter if it is not written in the summary.

Tgr added a comment.Jun 9 2021, 7:47 PM
In T284078#7140739, @MMiller_WMF wrote:

Also, @Tgr -- if we were to remove the rejected and skipped counts from the edit summary, we would still have them in Special:Log, right? For analysis purposes?

Yeah, those are unrelated.

MMiller_WMF updated the task description. (Show Details)Jun 23 2021, 3:21 AM
MMiller_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
MMiller_WMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
MMiller_WMF added a subscriber: • mewoph.

@mewoph -- this is ready for development. Thank you!

MMiller_WMF triaged this task as High priority.Jun 23 2021, 3:32 AM
• mewoph claimed this task.Jun 23 2021, 3:48 PM
• mewoph moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

Hi @MMiller_WMF

A new label, saying the edit is done through a feature (with no link, to avoid link fatigue)

I'm not sure what this is, can you clarify?

Trizek-WMF added a comment.Jun 23 2021, 4:16 PM

IIRC our discussions:

The edit summary is Link suggestions feature: $ links added. with no links.
The tag is the one already used: Suggested: add links. But this tag now needs to link to https://www.mediawiki.org/wiki/Special:MyPage/Growth/Personalized_first_day/Structured_tasks/Add_a_link

Hope this helps!

gerritbot added a comment.Jun 23 2021, 6:14 PM

Change 701167 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add a link: change the edit summary

https://gerrit.wikimedia.org/r/701167

gerritbot added a project: Patch-For-Review.Jun 23 2021, 6:14 PM
• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 23 2021, 6:16 PM

Updated edit summary:

Screen Shot 2021-06-23 at 11.02.34 AM.png (214×1 px, 115 KB)

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 28 2021, 11:05 AM
kostajh moved this task from Backlog to Done / QA on the Add-Link board.
gerritbot added a comment.Jun 28 2021, 11:24 AM

Change 701167 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add a link: change the edit summary

https://gerrit.wikimedia.org/r/701167

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.12; 2021-06-28).Jun 28 2021, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 28 2021, 12:10 PM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 2 2021, 12:57 AM
Etonkovidova moved this task from Test in Production | Watching to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.EditedJul 2 2021, 2:47 PM
Etonkovidova subscribed.

In cswiki wmf.12 (and I also checked arwiki) the Edit summary is displayed incorrectly:

Screen Shot 2021-07-02 at 7.35.52 AM.png (1×2 px, 315 KB)

Screen Shot 2021-07-02 at 7.40.10 AM.png (330×2 px, 154 KB)

Screen Shot 2021-07-02 at 7.27.36 AM.png (1×2 px, 377 KB)

betalabs doesn't show the issue - moving the task back to In Progress.

Screen Shot 2021-07-02 at 7.49.30 AM.png (1×2 px, 411 KB)

• mewoph added a comment.Jul 2 2021, 4:49 PM

We should keep passing the parameters since translations won't be updated all at once.

gerritbot added a comment.Jul 2 2021, 4:51 PM

Change 702995 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add a link: Pass additional parameters to growthexperiments-addlink-summary-summary

https://gerrit.wikimedia.org/r/702995

gerritbot added a project: Patch-For-Review.Jul 2 2021, 4:51 PM
• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 2 2021, 4:52 PM
Tgr added a comment.Jul 2 2021, 5:47 PM

Since there are no more deploy windows until July 12, I'll add local overrides for the translations on the affected wikis (ar, bn, cs, vi). Those overrides can be deleted once the translations have been updated in Translatewiki (already the case for ar and cs) and deployed to production.

Etonkovidova added a comment.Jul 2 2021, 6:27 PM
In T284078#7194517, @mewoph wrote:

We should keep passing the parameters since translations won't be updated all at once.

I did realize that it’s about translation. But why it shows: Link suggestions: 3 accepted, $ 2 rejected, $ 3 skipped instead of Link suggestions: 3 accepted? I thought that $ 2 rejected, $ 3 skipped would be just removed.

• mewoph added a comment.Jul 2 2021, 8:34 PM

@Etonkovidova Unfortunately the previous value for the key is static Návrhy odkazů: $1 přijato, $2 odmítnuto, $3 přeskočeno. so the $2 and $3 parameters are still needed.

gerritbot added a comment.Jul 8 2021, 1:41 PM

Change 702995 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add a link: Pass additional parameters to growthexperiments-addlink-summary-summary

https://gerrit.wikimedia.org/r/702995

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.14; 2021-07-12); removed MW-1.37-notes (1.37.0-wmf.12; 2021-06-28).Jul 8 2021, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 8 2021, 2:10 PM
• mewoph moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 12 2021, 10:26 PM
Trizek-WMF added a comment.EditedJul 13 2021, 1:17 PM
In T284078#7194767, @Etonkovidova wrote:
In T284078#7194517, @mewoph wrote:

We should keep passing the parameters since translations won't be updated all at once.

I did realize that it’s about translation. But why it shows: Link suggestions: 3 accepted, $ 2 rejected, $ 3 skipped instead of Link suggestions: 3 accepted? I thought that $ 2 rejected, $ 3 skipped would be just removed.

Yes, me too. I thought that the conclusion of the discussions were in favor of keeping the number of added links only. I created this task after the discussion where we reached consensus about the content of the edit summary.

Also, I paste T286215: Encourage the use of PLURAL in MediaWiki:Logentry-growthexperiments-addlink here as a related task to work on.

Etonkovidova closed this task as Resolved.Jul 13 2021, 10:05 PM
Etonkovidova mentioned this in T286215: Encourage the use of PLURAL in MediaWiki:Logentry-growthexperiments-addlink.

Checked in testwiki wmf.14

  • Link suggestions feature: 0 links added - if all links were rejected
  • Link suggestions feature: 1 link added - if some links were accepted and some were rejected/skipped; in this example 1 link was accepted.
  • no record for the case when all links were skipped
MMiller_WMF mentioned this in T290784: Add an image: edit summary and publish.Oct 13 2021, 2:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL