Page MenuHomePhabricator
Create Task
Maniphest T284095

[GOAL] Fix page previews visual bugs and remove unnecessary code before end of quarter
Closed, ResolvedPublic
Actions

Description

Specific: What do we want to achieve?

We have not been focused on page previews. The goal is resolved when all subtasks are addressed or a date has passed (to be set when we begin on first task). We will focus on visual bugs and code removal

Measurable: How will we know when we've reached our goal?

This goal can be closed when there are no open subtasks. Subtasks can be removed if deemed too complicated given the timeframe.

Achievable: What support will we need to achieve our goal?

Yes. We may need support from WMDE for reference tooltips related issues.

Relevant: Is this goal worthwhile?

Yes. Page previews is one of our most used products.

Time-bound: What is the time frame? Can we achieve this goal in the timeframe I've set?

Should be completed by 1.37 release or the end of quarter 1 ( 09/30/2021 ), whichever is sooner.

Descoped tasks

Phab ticketWhy was this descoped
......

Sign off steps

  • When resolving the goal, make sure to create a follow up goal for further down the road for any de-scoped tasks.

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Jun 1 2021, 5:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 1 2021, 5:21 PM
Jdlrobson added a subtask: T268999: Show medium size (<320 wide, but >=250 high) images as well.Jun 1 2021, 5:22 PM
Jdlrobson mentioned this in T268999: Show medium size (<320 wide, but >=250 high) images as well.
Jdlrobson added a subtask: T267211: Remove non-VirtualPageView EventLogging code from the Page Previews codebase.
Jdlrobson updated the task description. (Show Details)Jun 1 2021, 5:27 PM
Jdlrobson mentioned this in T267211: Remove non-VirtualPageView EventLogging code from the Page Previews codebase.
Jdlrobson triaged this task as High priority.Jun 1 2021, 7:07 PM
Jdlrobson renamed this task from [GOAL] Page previews maintenance to [GOAL] Page previews maintenance timeboxed sprint.Jun 2 2021, 8:16 PM
Jdlrobson assigned this task to ovasileva.
Jdlrobson moved this task from Epics/Goals to Needs Prioritization on the Web-Team-Backlog-Archived board.
Jdlrobson added a subtask: T275000: Previews preference for anonymous users is not sticky.Jun 2 2021, 8:19 PM
Jdlrobson added a subtask: T282987: Punctuation marks wrap to a new line after inline templates in PagePreview.Jun 3 2021, 3:30 AM
ovasileva added a subtask: T284355: Settings icon displaced when site language direction is different from content language .Jun 7 2021, 3:54 PM
ovasileva moved this task from Needs Prioritization to Epics/Goals on the Web-Team-Backlog-Archived board.Jun 7 2021, 3:57 PM
Jdlrobson mentioned this in T192489: Page previews settings (“cog wheel“) are not keyboard accessible.Jun 8 2021, 7:44 PM
Jdlrobson mentioned this in T192408: Page preview pokey not positioned correctly when moving cursor quickly across a link.
Jdlrobson mentioned this in T195718: Cannot dismiss page preview with keyboard navigation.
Jdlrobson mentioned this in T198708: [Bug] Middle and control clicking popup footer doesn't open new tab.
Jdlrobson mentioned this in T213107: [Bug] Block quotes are truncated instead of faded out.
Jdlrobson added a subtask: T233099: [For visibility] Page previews should be externally extendable.Jun 8 2021, 8:30 PM
Jdlrobson updated the task description. (Show Details)
ovasileva added a project: Page-Previews.Jun 9 2021, 11:59 AM
ovasileva added a subtask: T284643: Regression: Page previews displaying images with different heights.
Jdlrobson moved this task from Epics/Goals to Kanbanana-FY-2020-21 on the Web-Team-Backlog-Archived board.Jun 10 2021, 11:27 PM
Jdlrobson edited projects, added Web-Team-Backlog-Archived (Kanbanana-FY-2020-21); removed Web-Team-Backlog-Archived.
Jdlrobson moved this task from Needs Analysis to Quarterly Goals on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.
Jdlrobson moved this task from Kanbanana-FY-2020-21 to Epics/Goals on the Web-Team-Backlog-Archived board.Jun 10 2021, 11:52 PM
Jdlrobson edited projects, added Web-Team-Backlog-Archived; removed Web-Team-Backlog-Archived (Kanbanana-FY-2020-21).
Jdlrobson moved this task from Epics/Goals to unsed on the Web-Team-Backlog-Archived board.Jun 11 2021, 4:43 PM
Jdlrobson added a subtask: T271763: Give Popups storybook instance some love.Jun 11 2021, 5:26 PM
Jdlrobson added a project: Goal.Jun 11 2021, 5:37 PM
Jdlrobson added a subtask: T192773: Entire page preview should be clickable.Jun 11 2021, 5:39 PM
Jdlrobson added a subtask: T255549: Portrait images in PagePreview popups are notably cut off (zoomed in).Jun 11 2021, 5:44 PM
Jdlrobson removed ovasileva as the assignee of this task.Jun 11 2021, 9:12 PM
Jdlrobson moved this task from unsed to Triaged but Future on the Web-Team-Backlog-Archived board.
Jdlrobson moved this task from Triaged but Future to unsed on the Web-Team-Backlog-Archived board.
Jdlrobson added a subscriber: ovasileva.
• alexhollender_WMF added a subtask: T192489: Page previews settings (“cog wheel“) are not keyboard accessible.Jun 14 2021, 2:50 PM
• alexhollender_WMF added a subtask: T195718: Cannot dismiss page preview with keyboard navigation.Jun 14 2021, 2:57 PM
• alexhollender_WMF added a subtask: T213107: [Bug] Block quotes are truncated instead of faded out.Jun 14 2021, 3:02 PM
Jdlrobson renamed this task from [GOAL] Page previews maintenance timeboxed sprint to [GOAL] Fix page previews visual and remove unnecessary code.Jun 22 2021, 8:11 PM
Jdlrobson renamed this task from [GOAL] Fix page previews visual and remove unnecessary code to [GOAL] Fix page previews visual bugs and remove unnecessary code.
Jdlrobson edited subtasks, added: T206356: [Bug] Popups should avoid presentation in the natural reading direction; removed: T233099: [For visibility] Page previews should be externally extendable, T275000: Previews preference for anonymous users is not sticky.
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from unsed to Kanbanana-FY-2020-21 on the Web-Team-Backlog-Archived board.Jun 22 2021, 8:15 PM
Jdlrobson edited projects, added Web-Team-Backlog-Archived (Kanbanana-FY-2020-21); removed Web-Team-Backlog-Archived.
LGoto closed subtask T284355: Settings icon displaced when site language direction is different from content language as Declined.Jul 13 2021, 9:55 PM
LGoto closed subtask T282987: Punctuation marks wrap to a new line after inline templates in PagePreview as Declined.
LGoto closed subtask T255549: Portrait images in PagePreview popups are notably cut off (zoomed in) as Declined.
LGoto closed subtask T206356: [Bug] Popups should avoid presentation in the natural reading direction as Declined.
LGoto closed subtask T192773: Entire page preview should be clickable as Declined.
stjn reopened subtask T282987: Punctuation marks wrap to a new line after inline templates in PagePreview as Open.Jul 15 2021, 6:18 PM
thiemowmde reopened subtask T255549: Portrait images in PagePreview popups are notably cut off (zoomed in) as Open.Jul 16 2021, 6:53 AM
Jdlrobson removed a subtask: T195718: Cannot dismiss page preview with keyboard navigation.Jul 21 2021, 4:08 PM
Jdlrobson removed a subtask: T192489: Page previews settings (“cog wheel“) are not keyboard accessible.
ovasileva added a subtask: T287119: Regression: Link tooltips overlap previews.Jul 22 2021, 1:51 PM
cjming closed subtask T271763: Give Popups storybook instance some love as Resolved.Jul 27 2021, 1:39 AM
Jdlrobson renamed this task from [GOAL] Fix page previews visual bugs and remove unnecessary code to [GOAL] Fix page previews visual bugs and remove unnecessary code before end of quarter.Jul 28 2021, 10:36 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: Volker_E.
LGoto edited projects, added Web-Team-Backlog-Archived (Kanbanana-FY-2021-22); removed Web-Team-Backlog-Archived (Kanbanana-FY-2020-21).Aug 2 2021, 9:25 PM
LGoto moved this task from Needs Analysis to Quarterly Goals on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
Jdlrobson removed a subtask: T282987: Punctuation marks wrap to a new line after inline templates in PagePreview.Aug 5 2021, 10:07 PM
Jdlrobson closed subtask T255549: Portrait images in PagePreview popups are notably cut off (zoomed in) as Resolved.Aug 20 2021, 5:57 PM
Jdlrobson closed subtask T267211: Remove non-VirtualPageView EventLogging code from the Page Previews codebase as Resolved.Aug 23 2021, 8:49 PM
Jdlrobson claimed this task.Aug 25 2021, 10:25 PM
Jdlrobson moved this task from Quarterly Goals to QA in Prod on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
Jdlrobson moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.

All tasks are now in upcoming, or in flight. As part of sign off we need to review the storybook and create any follow up tasks for later.

ovasileva closed subtask T287119: Regression: Link tooltips overlap previews as Resolved.Aug 26 2021, 2:49 PM
ovasileva closed subtask T268999: Show medium size (<320 wide, but >=250 high) images as well as Resolved.Aug 31 2021, 3:48 PM
ovasileva closed subtask T289362: Bug: page preview settings icon is too high in some cases as Resolved.Sep 2 2021, 4:02 PM
ovasileva closed subtask T213107: [Bug] Block quotes are truncated instead of faded out as Resolved.Sep 8 2021, 3:43 PM
ovasileva closed subtask T284643: Regression: Page previews displaying images with different heights as Resolved.Sep 10 2021, 4:00 PM
Jdlrobson reassigned this task from Jdlrobson to • alexhollender_WMF.Sep 10 2021, 4:28 PM
Jdlrobson added a subscriber: • alexhollender_WMF.

@alexhollender T290109 is the last remaining open subtask here so probably makes sense for you to sign this off. Looks good from a dev perspective

• alexhollender_WMF added a comment.Sep 13 2021, 4:13 PM
In T284095#7345087, @Jdlrobson wrote:

@alexhollender T290109 is the last remaining open subtask here so probably makes sense for you to sign this off. Looks good from a dev perspective

ok, should I wait until it's live in production?

• alexhollender_WMF closed subtask T290109: [Post-deployment] Update design documentation for page previews as Resolved.Sep 30 2021, 10:17 PM
• alexhollender_WMF closed this task as Resolved.Sep 30 2021, 10:22 PM

@Jdlrobson it seems like the bottoms of some letters are being clipped. I will file a new task.

image.png (1×2 px, 400 KB)
image.png (1×1 px, 440 KB)
image.png (1×2 px, 995 KB)
• alexhollender_WMF mentioned this in T295685: [page previews] clipped letters at the bottom of page previews.Nov 15 2021, 2:08 PM
In T284095#7393577, @alexhollender wrote:

@Jdlrobson it seems like the bottoms of some letters are being clipped. I will file a new task.

image.png (1×2 px, 400 KB)
image.png (1×1 px, 440 KB)
image.png (1×2 px, 995 KB)

filed: T295685

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits